Minor appearance changes (#2370)

* Minor appearance changes

* Remove that redundant deleted property

* Fixes and remove redundant checks

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
Co-authored-by: Víctor Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>

Content.Client/GameObjects/Components/Conveyor/ConveyorSwitchVisualizer.cs

@@ -60,12 +60,6 @@ namespace Content.Client.GameObjects.Components.Conveyor
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-
-            if (component.Owner.Deleted)
-            {
-                return;
-            }
-
             ChangeState(component);
         }
     }

Content.Client/GameObjects/Components/Conveyor/ConveyorVisualizer.cs

@@ -60,12 +60,6 @@ namespace Content.Client.GameObjects.Components.Conveyor
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-
-            if (component.Owner.Deleted)
-            {
-                return;
-            }
-
             ChangeState(component);
         }
     }

Content.Client/GameObjects/Components/Disposal/DisposalUnitVisualizer.cs

@@ -150,12 +150,6 @@ namespace Content.Client.GameObjects.Components.Disposal
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-
-            if (component.Owner.Deleted)
-            {
-                return;
-            }
-
             ChangeState(component);
         }
     }

Content.Client/GameObjects/Components/Disposal/DisposalVisualizer.cs

@@ -69,12 +69,6 @@ namespace Content.Client.GameObjects.Components.Disposal
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-
-            if (component.Owner.Deleted)
-            {
-                return;
-            }
-
             ChangeState(component);
         }
     }

Content.Client/GameObjects/Components/Doors/AirlockVisualizer.cs

@@ -103,8 +103,7 @@ namespace Content.Client.GameObjects.Components.Doors
 
         public override void OnChangeData(AppearanceComponent component)
         {
-            if (component.Owner.Deleted)
+            base.OnChangeData(component);
-                return;
 
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
             var animPlayer = component.Owner.GetComponent<AnimationPlayerComponent>();

Content.Client/GameObjects/Components/MedicalScanner/MedicalScannerVisualizer.cs

@@ -12,11 +12,6 @@ namespace Content.Client.GameObjects.Components.MedicalScanner
         {
             base.OnChangeData(component);
 
-            if (component.Owner.Deleted)
-            {
-                return;
-            }
-
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
             if (!component.TryGetData(MedicalScannerVisuals.Status, out MedicalScannerStatus status)) return;
             sprite.LayerSetState(MedicalScannerVisualLayers.Machine, StatusToMachineStateId(status));

Content.Client/GameObjects/Components/Nutrition/DrinkFoodVisualizer.cs

@@ -22,10 +22,8 @@ namespace Content.Client.GameObjects.Components.Nutrition
 
         public override void OnChangeData(AppearanceComponent component)
         {
-            if(!component.Owner.TryGetComponent<ISpriteComponent>(out var sprite))
+            base.OnChangeData(component);
-            {
+            var sprite = component.Owner.GetComponent<ISpriteComponent>();
-                return;
-            };
 
             if (!component.TryGetData<float>(SharedFoodComponent.FoodVisuals.MaxUses, out var maxUses))
             {

Content.Client/GameObjects/Components/PDA/PDAVisualizer.cs

@@ -49,10 +49,7 @@ namespace Content.Client.GameObjects.Components.PDA
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-            if (component.Owner.Deleted)
+
-            {
-                return;
-            }
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
             sprite.LayerSetVisible(PDAVisualLayers.Flashlight, false);
             if (component.TryGetData(PDAVisuals.FlashlightLit, out bool isScreenLit))

Content.Client/GameObjects/Components/ParticleAcceleratorPartVisualizer.cs

@@ -43,7 +43,7 @@ namespace Content.Client.GameObjects.Components
         public override void InitializeEntity(IEntity entity)
         {
             base.InitializeEntity(entity);
-            if (!entity.TryGetComponent<SpriteComponent>(out var sprite))
+            if (!entity.TryGetComponent<ISpriteComponent>(out var sprite))
             {
                 throw new EntityCreationException("No sprite component found in entity that has ParticleAcceleratorPartVisualizer");
             }
@@ -56,9 +56,7 @@ namespace Content.Client.GameObjects.Components
 
         public override void OnChangeData(AppearanceComponent component)
         {
-            if (component.Owner.Deleted)
+            base.OnChangeData(component);
-                return;
-
             if (!component.Owner.TryGetComponent<ISpriteComponent>(out var sprite)) return;
             if (!component.TryGetData(ParticleAcceleratorVisuals.VisualState, out ParticleAcceleratorVisualState state))
             {

Content.Client/GameObjects/Components/RadiationCollectorVisualizer.cs

@@ -57,8 +57,7 @@ namespace Content.Client.GameObjects.Components
 
         public override void OnChangeData(AppearanceComponent component)
         {
-            if (component.Owner.Deleted)
+            base.OnChangeData(component);
-                return;
 
             if (!component.Owner.TryGetComponent<ISpriteComponent>(out var sprite)) return;
             if (!component.Owner.TryGetComponent<AnimationPlayerComponent>(out var animPlayer)) return;

Content.Client/GameObjects/Components/VendingMachines/VendingMachineVisualizer.cs

@@ -128,6 +128,8 @@ namespace Content.Client.GameObjects.Components.VendingMachines
 
         public override void OnChangeData(AppearanceComponent component)
         {
+            base.OnChangeData(component);
+
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
             var animPlayer = component.Owner.GetComponent<AnimationPlayerComponent>();
             if (!component.TryGetData(VendingMachineVisuals.VisualState, out VendingMachineVisualState state))

Content.Client/GameObjects/Components/Weapons/Ranged/Barrels/Visualizers/BarrelBoltVisualizer.cs

@@ -18,6 +18,7 @@ namespace Content.Client.GameObjects.Components.Weapons.Ranged.Barrels.Visualize
 
         public override void OnChangeData(AppearanceComponent component)
         {
+            base.OnChangeData(component);
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
 
             if (!component.TryGetData(BarrelBoltVisuals.BoltOpen, out bool boltOpen))

Content.Client/GameObjects/Components/Weapons/Ranged/Barrels/Visualizers/MagVisualizer.cs

@@ -45,6 +45,8 @@ namespace Content.Client.GameObjects.Components.Weapons.Ranged.Barrels.Visualize
 
         public override void OnChangeData(AppearanceComponent component)
         {
+            base.OnChangeData(component);
+
             // tl;dr
             // 1.If no mag then hide it OR
             // 2. If step 0 isn't visible then hide it (mag or unshaded)

Content.Client/GameObjects/Components/Wires/WiresVisualizer.cs

@@ -9,15 +9,16 @@ namespace Content.Client.GameObjects.Components.Wires
         public override void OnChangeData(AppearanceComponent component)
         {
             base.OnChangeData(component);
-
-            if (component.Owner.Deleted)
-                return;
-
             var sprite = component.Owner.GetComponent<ISpriteComponent>();
             if (component.TryGetData<bool>(WiresVisuals.MaintenancePanelState, out var state))
             {
                 sprite.LayerSetVisible(WiresVisualLayers.MaintenancePanel, state);
             }
+            // Mainly for spawn window
+            else
+            {
+                sprite.LayerSetVisible(WiresVisualLayers.MaintenancePanel, false);
+            }
         }
 
         public enum WiresVisualLayers