Refactor ExtinguisherCabinet->ItemCabinet and actually maps them in, adds EntityWhitelist (#4154)

* i probably shouldnt have done this in one commit

* map nonsense

* fix example code

* unnecessary

* test

* reviews

* little fix for open datafield

* add soul

Resources/Prototypes/Entities/Constructible/Walls/extinguisher_cabinet.yml

@@ -1,7 +1,6 @@
 - type: entity
   id: ExtinguisherCabinet
   name: extinguisher cabinet
-  abstract: true
   description: A small wall mounted cabinet designed to hold a fire extinguisher.
   components:
     - type: Clickable
@@ -9,15 +8,40 @@
     - type: Sprite
       sprite: Constructible/Misc/extinguisher_cabinet.rsi
       state: extinguisher_closed
-    - type: ExtinguisherCabinet
+    - type: ItemCabinet
+      doorSound: /Audio/Machines/machine_switch.ogg
+      whitelist:
+        components:
+        - FireExtinguisher
     - type: Appearance
       visuals:
-        - type: ExtinguisherCabinetVisualizer
+        - type: ItemCabinetVisualizer
+          emptyState: extinguisher_empty
+          fullState: extinguisher_full
+          closedState: extinguisher_closed
   placement:
     mode: SnapgridCenter
 
+- type: entity
+  id: ExtinguisherCabinetOpen
+  parent: ExtinguisherCabinet
+  suffix: Open
+  components:
+  - type: ItemCabinet
+    opened: true
+
 - type: entity
   id: ExtinguisherCabinetFilled
   parent: ExtinguisherCabinet
+  suffix: Filled
   components:
-    - type: ExtinguisherCabinetFilled
+    - type: ItemCabinet
+      spawnPrototype: FireExtinguisher
+
+- type: entity
+  id: ExtinguisherCabinetFilledOpen
+  parent: ExtinguisherCabinetFilled
+  suffix: Filled, Open
+  components:
+  - type: ItemCabinet
+    opened: true

Resources/Prototypes/Entities/Objects/Misc/fire_extinguisher.yml

@@ -31,6 +31,10 @@
       transferAmount: 5
       impulse: 50.0
     - type: FireExtinguisher
+    - type: MeleeWeapon
+      damage: 10
+      damageType: Blunt
+      hitSound: /Audio/Weapons/smash.ogg
     - type: Appearance
       visuals:
         - type: SprayVisualizer