Research director should be able to buy science-related items in uplink (#18986)

Content.Server/Store/Conditions/BuyerDepartmentCondition.cs

@@ -0,0 +1,76 @@
+using Content.Server.Mind.Components;
+using Content.Server.Roles;
+using Content.Shared.Roles;
+using Content.Shared.Store;
+using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototype.Set;
+using Robust.Shared.Prototypes;
+
+namespace Content.Server.Store.Conditions;
+
+/// <summary>
+/// Allows a store entry to be filtered out based on the user's job.
+/// Supports both blacklists and whitelists
+/// </summary>
+public sealed class BuyerDepartmentCondition : ListingCondition
+{
+    /// <summary>
+    /// A whitelist of department prototypes that can purchase this listing. Only one needs to be found.
+    /// </summary>
+    [DataField("whitelist", customTypeSerializer: typeof(PrototypeIdHashSetSerializer<DepartmentPrototype>))]
+    public HashSet<string>? Whitelist;
+
+    /// <summary>
+    /// A blacklist of department prototypes that can purchase this listing. Only one needs to be found.
+    /// </summary>
+    [DataField("blacklist", customTypeSerializer: typeof(PrototypeIdHashSetSerializer<DepartmentPrototype>))]
+    public HashSet<string>? Blacklist;
+
+    public override bool Condition(ListingConditionArgs args)
+    {
+        var prototypeManager = IoCManager.Resolve<IPrototypeManager>();
+
+        var ent = args.EntityManager;
+
+        if (!ent.TryGetComponent<MindContainerComponent>(args.Buyer, out var mind) || mind.Mind == null)
+            return true; //this is for things like surplus crate
+
+        if (Blacklist != null)
+        {
+            foreach (var role in mind.Mind.AllRoles)
+            {
+                if (role is not Job job)
+                    continue;
+
+                foreach (var department in prototypeManager.EnumeratePrototypes<DepartmentPrototype>())
+                    if (department.Roles.Contains(job.Prototype.ID))
+                        if (Blacklist.Contains(department.ID))
+                            return false;
+            }
+        }
+
+        if (Whitelist != null)
+        {
+            var found = false;
+            foreach (var role in mind.Mind.AllRoles)
+            {
+                if (role is not Job job)
+                    continue;
+
+                foreach (var department in prototypeManager.EnumeratePrototypes<DepartmentPrototype>())
+                    if (department.Roles.Contains(job.Prototype.ID))
+                        if (Whitelist.Contains(department.ID))
+                        {
+                            found = true;
+                            break;
+                        }
+
+                if (found)
+                    break;
+            }
+            if (!found)
+                return false;
+        }
+
+        return true;
+    }
+}

Resources/Prototypes/Catalog/uplink_catalog.yml

@@ -965,10 +965,9 @@
   categories:
   - UplinkJob
   conditions:
-    - !type:BuyerJobCondition
+    - !type:BuyerDepartmentCondition
       whitelist:
-        - Scientist
+      - Science
-        - SeniorResearcher
 
 - type: listing
   id: uplinkProximityMine
@@ -999,11 +998,12 @@
   categories:
   - UplinkJob
   conditions:
-  - !type:BuyerJobCondition
+  - !type:BuyerJobCondition # We can't use BuyerDepartmentCondition here since Zookeeper and Chef can also get this
     whitelist:
     - Zookeeper
     - Scientist
     - SeniorResearcher
+    - ResearchDirector
     - Chef
 
 # Armor