From 2fefca5f70eb03ddc2760d622676c99933d2a3fe Mon Sep 17 00:00:00 2001 From: Aviu00 <93730715+Aviu00@users.noreply.github.com> Date: Tue, 25 Jun 2024 21:39:44 +0000 Subject: [PATCH] Cherrypicks 3 (#382) * Mobs burn to ashes on excessive heat damage (#26971) * mobs burn to ashes on excessive heat damage * remove comment, remove random lines I didn't mean to add * combine code into behavior * clean unused * fix namespace * drop next to * fix spawn entities behavior spawning entities outside container * fix burning to ash not working on all mobs (#27158) * add ghostnado button to warp menu (#27556) * add ghostnado button to warp menu * translator ops --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Make arguments and parameters wrap to one variable per line (#27766) * Fix ghosts getting spawned in nullspace (#27617) * Add tests for ghost spawn position * Make ghosts spawn immediately * Format mind system * Move ghost spawning to GhostSystem * Spawn ghost on grid or map This fixes the ghosts being attached the parent entity instead of the grid. * Move logging out of the ghost system * Make round start observer spawn using GhostSystem * Move GameTicker ghost spawning to GhostSystem Moved the more robust character name selection code over. Moved the TimeOfDeath code over. Added canReturn logic. * Add overrides and default for ghost spawn coordinates * Add warning log to ghost spawn fail * Clean up test * Dont spawn ghost on map delete * Minor changes to the role test * Fix role test failing to spawn ghost It was failing the map check due to using Nullspace * Fix ghost tests when running in parallel Not sure what happened, but it seems to be because they were running simultaneously and overwriting values. * Clean up ghost tests * Test that map deletion does not spawn ghosts * Spawn ghost on the next available map * Disallow spawning on deleted maps * Fix map deletion ghost test * Cleanup --------- Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: ShadowCommander --- .editorconfig | 4 + .../Ghost/Controls/GhostTargetWindow.xaml | 1 + .../Ghost/Controls/GhostTargetWindow.xaml.cs | 3 + .../Systems/Ghost/GhostUIController.cs | 8 +- .../Tests/Minds/GhostRoleTests.cs | 12 +- .../Tests/Minds/GhostTests.cs | 159 ++++++++++++++++++ .../Tests/Minds/MindTests.EntityDeletion.cs | 17 +- .../Thresholds/Behaviors/BurnBodyBehavior.cs | 32 ++++ .../Behaviors/SpawnEntitiesBehavior.cs | 13 +- .../GameTicking/GameTicker.GamePreset.cs | 30 +--- .../GameTicking/GameTicker.Spawning.cs | 117 ++++++++----- Content.Server/Ghost/GhostSystem.cs | 104 ++++++++++-- Content.Server/Mind/MindSystem.cs | 47 +----- Content.Shared/Follower/FollowerSystem.cs | 21 +++ Content.Shared/Ghost/SharedGhostSystem.cs | 6 + Resources/Locale/en-US/burning/bodyburn.ftl | 1 + Resources/Locale/en-US/ghost/ghost-gui.ftl | 1 + Resources/Prototypes/Entities/Mobs/base.yml | 15 ++ 18 files changed, 460 insertions(+), 131 deletions(-) create mode 100644 Content.IntegrationTests/Tests/Minds/GhostTests.cs create mode 100644 Content.Server/Destructible/Thresholds/Behaviors/BurnBodyBehavior.cs create mode 100644 Resources/Locale/en-US/burning/bodyburn.ftl diff --git a/.editorconfig b/.editorconfig index 872a068c7c..f01530bcb1 100644 --- a/.editorconfig +++ b/.editorconfig @@ -336,7 +336,11 @@ dotnet_naming_symbols.type_parameters_symbols.applicable_kinds = type_parameter # ReSharper properties resharper_braces_for_ifelse = required_for_multiline +resharper_csharp_wrap_arguments_style = chop_if_long +resharper_csharp_wrap_parameters_style = chop_if_long resharper_keep_existing_attribute_arrangement = true +resharper_wrap_chained_binary_patterns = chop_if_long +resharper_wrap_chained_method_calls = chop_if_long [*.{csproj,xml,yml,yaml,dll.config,msbuildproj,targets,props}] indent_size = 2 diff --git a/Content.Client/UserInterface/Systems/Ghost/Controls/GhostTargetWindow.xaml b/Content.Client/UserInterface/Systems/Ghost/Controls/GhostTargetWindow.xaml index 86fd09b2c8..32cab732d1 100644 --- a/Content.Client/UserInterface/Systems/Ghost/Controls/GhostTargetWindow.xaml +++ b/Content.Client/UserInterface/Systems/Ghost/Controls/GhostTargetWindow.xaml @@ -1,5 +1,6 @@ +