Minor UI refactor (#11212)

Content.Client/Ghost/UI/GhostGui.cs

@@ -1,85 +0,0 @@
-using Content.Client.Stylesheets;
-using Content.Shared.Ghost;
-using Robust.Client.Console;
-using Robust.Client.UserInterface;
-using Robust.Client.UserInterface.Controls;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Localization;
-using static Robust.Client.UserInterface.Controls.BoxContainer;
-
-namespace Content.Client.Ghost.UI
-{
-    public sealed class GhostGui : Control
-    {
-        private readonly Button _returnToBody = new() {Text = Loc.GetString("ghost-gui-return-to-body-button") };
-        private readonly Button _ghostWarp = new() {Text = Loc.GetString("ghost-gui-ghost-warp-button") };
-        private readonly Button _ghostRoles = new();
-        private readonly GhostComponent _owner;
-        private readonly GhostSystem _system;
-
-        public GhostTargetWindow? TargetWindow { get; }
-
-        public GhostGui(GhostComponent owner, GhostSystem system, IEntityNetworkManager eventBus)
-        {
-            IoCManager.InjectDependencies(this);
-
-            _owner = owner;
-            _system = system;
-
-            TargetWindow = new GhostTargetWindow(eventBus);
-
-            MouseFilter = MouseFilterMode.Ignore;
-
-            _ghostWarp.OnPressed += _ =>
-            {
-                eventBus.SendSystemNetworkMessage(new GhostWarpsRequestEvent());
-                TargetWindow.Populate();
-                TargetWindow.OpenCentered();
-            };
-            _returnToBody.OnPressed += _ =>
-            {
-                var msg = new GhostReturnToBodyRequest();
-                eventBus.SendSystemNetworkMessage(msg);
-            };
-            _ghostRoles.OnPressed += _ => IoCManager.Resolve<IClientConsoleHost>()
-                .RemoteExecuteCommand(null, "ghostroles");
-
-            AddChild(new BoxContainer
-            {
-                Orientation = LayoutOrientation.Horizontal,
-                Children =
-                {
-                    _returnToBody,
-                    _ghostWarp,
-                    _ghostRoles,
-                }
-            });
-        }
-
-        public void Update()
-        {
-            _returnToBody.Disabled = !_owner.CanReturnToBody;
-            _ghostRoles.Text = Loc.GetString("ghost-gui-ghost-roles-button", ("count", _system.AvailableGhostRoleCount));
-            if (_system.AvailableGhostRoleCount != 0)
-            {
-                _ghostRoles.StyleClasses.Add(StyleBase.ButtonCaution);
-            }
-            else
-            {
-                _ghostRoles.StyleClasses.Remove(StyleBase.ButtonCaution);
-            }
-            TargetWindow?.Populate();
-        }
-
-        protected override void Dispose(bool disposing)
-        {
-            base.Dispose(disposing);
-
-            if (disposing)
-            {
-                TargetWindow?.Dispose();
-            }
-        }
-    }
-}

Content.Client/Ghost/UI/GhostTargetWindow.xaml

@@ -1,15 +0,0 @@
-<DefaultWindow xmlns="https://spacestation14.io"
-            Title="{Loc 'ghost-target-window-title'}"
-            MinSize="450 450"
-            SetSize="450 450">
-    <ScrollContainer VerticalExpand="True"
-                     HorizontalExpand="True"
-					 HScrollEnabled="False">
-        <BoxContainer Name="ButtonContainer"
-                      Orientation="Vertical"
-                      VerticalExpand="True"
-                      SeparationOverride="5">
-            <!-- Target buttons get added here by code -->
-        </BoxContainer>
-    </ScrollContainer>
-</DefaultWindow>

Content.Client/Ghost/UI/GhostTargetWindow.xaml.cs

@@ -1,73 +0,0 @@
-using System.Linq;
-using Content.Shared.Ghost;
-using Robust.Client.AutoGenerated;
-using Robust.Client.UserInterface.Controls;
-using Robust.Client.UserInterface.CustomControls;
-using Robust.Client.UserInterface.XAML;
-
-namespace Content.Client.Ghost.UI
-{
-    [GenerateTypedNameReferences]
-    public sealed partial class GhostTargetWindow : DefaultWindow
-    {
-        private readonly IEntityNetworkManager _netManager;
-
-        private List<(string, EntityUid)> _warps = new();
-
-        public GhostTargetWindow(IEntityNetworkManager netManager)
-        {
-            RobustXamlLoader.Load(this);
-
-            _netManager = netManager;
-        }
-
-        public void UpdateWarps(IEnumerable<GhostWarp> warps)
-        {
-            // Server COULD send these sorted but how about we just use the client to do it instead
-            _warps = warps
-                .OrderBy(w => w.IsWarpPoint)
-                .ThenBy(w => w.DisplayName, Comparer<string>.Create(
-                    (x, y) => string.Compare(x, y, StringComparison.Ordinal)))
-                .Select(w =>
-                {
-                    var name = w.IsWarpPoint
-                        ? Loc.GetString("ghost-target-window-current-button", ("name", w.DisplayName))
-                        : w.DisplayName;
-
-                    return (name, w.Entity);
-                })
-                .ToList();
-        }
-
-        public void Populate()
-        {
-            ButtonContainer.DisposeAllChildren();
-            AddButtons();
-        }
-
-        private void AddButtons()
-        {
-            foreach (var (name, warp) in _warps)
-            {
-                var currentButtonRef = new Button
-                {
-                    Text = name,
-                    TextAlign = Label.AlignMode.Right,
-                    HorizontalAlignment = HAlignment.Center,
-                    VerticalAlignment = VAlignment.Center,
-                    SizeFlagsStretchRatio = 1,
-                    MinSize = (340, 20),
-                    ClipText = true,
-                };
-
-                currentButtonRef.OnPressed += _ =>
-                {
-                    var msg = new GhostWarpToTargetRequestEvent(warp);
-                    _netManager.SendSystemNetworkMessage(msg);
-                };
-
-                ButtonContainer.AddChild(currentButtonRef);
-            }
-        }
-    }
-}