Re-organize in-memory character profile storage.

Now uses a dictionary of int -> profile instead of an array filled with nulls.

Content.Shared/Network/NetMessages/MsgDeleteCharacter.cs

@@ -0,0 +1,33 @@
+using Lidgren.Network;
+using Robust.Shared.Interfaces.Network;
+using Robust.Shared.Network;
+
+namespace Content.Shared.Network.NetMessages
+{
+    /// <summary>
+    /// The client sends this to delete a character profile.
+    /// </summary>
+    public class MsgDeleteCharacter : NetMessage
+    {
+        #region REQUIRED
+
+        public const MsgGroups GROUP = MsgGroups.Command;
+        public const string NAME = nameof(MsgDeleteCharacter);
+
+        public MsgDeleteCharacter(INetChannel channel) : base(NAME, GROUP) { }
+
+        #endregion
+
+        public int Slot;
+
+        public override void ReadFromBuffer(NetIncomingMessage buffer)
+        {
+            Slot = buffer.ReadInt32();
+        }
+
+        public override void WriteToBuffer(NetOutgoingMessage buffer)
+        {
+            buffer.Write(Slot);
+        }
+    }
+}

Content.Shared/Network/NetMessages/MsgPreferencesAndSettings.cs

@@ -0,0 +1,64 @@
+using System.IO;
+using Content.Shared.Preferences;
+using Lidgren.Network;
+using Robust.Shared.Interfaces.Network;
+using Robust.Shared.Interfaces.Serialization;
+using Robust.Shared.IoC;
+using Robust.Shared.Network;
+
+namespace Content.Shared.Network.NetMessages
+{
+    /// <summary>
+    /// The server sends this before the client joins the lobby.
+    /// </summary>
+    public class MsgPreferencesAndSettings : NetMessage
+    {
+        #region REQUIRED
+
+        public const MsgGroups GROUP = MsgGroups.Command;
+        public const string NAME = nameof(MsgPreferencesAndSettings);
+
+        public MsgPreferencesAndSettings(INetChannel channel) : base(NAME, GROUP) { }
+
+        #endregion
+
+        public PlayerPreferences Preferences;
+        public GameSettings Settings;
+
+        public override void ReadFromBuffer(NetIncomingMessage buffer)
+        {
+            var serializer = IoCManager.Resolve<IRobustSerializer>();
+            var length = buffer.ReadVariableInt32();
+            using (var stream = buffer.ReadAsStream(length))
+            {
+                serializer.DeserializeDirect(stream, out Preferences);
+            }
+
+            length = buffer.ReadVariableInt32();
+            using (var stream = buffer.ReadAsStream(length))
+            {
+                serializer.DeserializeDirect(stream, out Settings);
+            }
+        }
+
+        public override void WriteToBuffer(NetOutgoingMessage buffer)
+        {
+            var serializer = IoCManager.Resolve<IRobustSerializer>();
+            using (var stream = new MemoryStream())
+            {
+                serializer.SerializeDirect(stream, Preferences);
+                buffer.WriteVariableInt32((int) stream.Length);
+                stream.TryGetBuffer(out var segment);
+                buffer.Write(segment);
+            }
+
+            using (var stream = new MemoryStream())
+            {
+                serializer.SerializeDirect(stream, Settings);
+                buffer.WriteVariableInt32((int) stream.Length);
+                stream.TryGetBuffer(out var segment);
+                buffer.Write(segment);
+            }
+        }
+    }
+}

Content.Shared/Network/NetMessages/MsgSelectCharacter.cs

@@ -0,0 +1,33 @@
+using Lidgren.Network;
+using Robust.Shared.Interfaces.Network;
+using Robust.Shared.Network;
+
+namespace Content.Shared.Network.NetMessages
+{
+    /// <summary>
+    /// The client sends this to select a character slot.
+    /// </summary>
+    public class MsgSelectCharacter : NetMessage
+    {
+        #region REQUIRED
+
+        public const MsgGroups GROUP = MsgGroups.Command;
+        public const string NAME = nameof(MsgSelectCharacter);
+
+        public MsgSelectCharacter(INetChannel channel) : base(NAME, GROUP) { }
+
+        #endregion
+
+        public int SelectedCharacterIndex;
+
+        public override void ReadFromBuffer(NetIncomingMessage buffer)
+        {
+            SelectedCharacterIndex = buffer.ReadVariableInt32();
+        }
+
+        public override void WriteToBuffer(NetOutgoingMessage buffer)
+        {
+            buffer.WriteVariableInt32(SelectedCharacterIndex);
+        }
+    }
+}

Content.Shared/Network/NetMessages/MsgUpdateCharacter.cs

@@ -0,0 +1,50 @@
+using System.IO;
+using Content.Shared.Preferences;
+using Lidgren.Network;
+using Robust.Shared.Interfaces.Network;
+using Robust.Shared.Interfaces.Serialization;
+using Robust.Shared.IoC;
+using Robust.Shared.Network;
+
+namespace Content.Shared.Network.NetMessages
+{
+    /// <summary>
+    /// The client sends this to update a character profile.
+    /// </summary>
+    public class MsgUpdateCharacter : NetMessage
+    {
+        #region REQUIRED
+
+        public const MsgGroups GROUP = MsgGroups.Command;
+        public const string NAME = nameof(MsgUpdateCharacter);
+
+        public MsgUpdateCharacter(INetChannel channel) : base(NAME, GROUP) { }
+
+        #endregion
+
+        public int Slot;
+        public ICharacterProfile Profile;
+
+        public override void ReadFromBuffer(NetIncomingMessage buffer)
+        {
+            Slot = buffer.ReadInt32();
+            var serializer = IoCManager.Resolve<IRobustSerializer>();
+            var length = buffer.ReadVariableInt32();
+            using var stream = buffer.ReadAsStream(length);
+            Profile = serializer.Deserialize<ICharacterProfile>(stream);
+        }
+
+        public override void WriteToBuffer(NetOutgoingMessage buffer)
+        {
+            buffer.Write(Slot);
+            var serializer = IoCManager.Resolve<IRobustSerializer>();
+            using (var stream = new MemoryStream())
+            {
+                serializer.Serialize(stream, Profile);
+                buffer.WriteVariableInt32((int) stream.Length);
+                stream.TryGetBuffer(out var segment);
+                buffer.Write(segment);
+            }
+        }
+    }
+}