Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Remove 1 protomanager TryIndex per drawn decal (#13395)

Browse Source
This commit is contained in:
metalgearsloth
2023-01-10 22:59:17 +11:00
committed by GitHub
parent 50ba8d968d
commit 399c3c7aec
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Content.Client/Decals/DecalOverlay.cs
View File

@@ -17,7 +17,7 @@ namespace Content.Client.Decals
public override OverlaySpace Space => OverlaySpace.WorldSpaceBelowEntities; public override OverlaySpace Space => OverlaySpace.WorldSpaceBelowEntities;
private readonly Dictionary<string, Texture> _cachedTextures = new(64); private readonly Dictionary<string, (Texture Texture, bool SnapCardinals)> _cachedTextures = new(64);
public DecalOverlay( public DecalOverlay(
DecalSystem decals, DecalSystem decals,
@@ -56,23 +56,20 @@ namespace Content.Client.Decals
handle.SetTransform(worldMatrix); handle.SetTransform(worldMatrix);
foreach (var (_, decals) in zIndexDictionary) foreach (var decals in zIndexDictionary.Values)
{ {
foreach (var (_, decal) in decals) foreach (var decal in decals.Values)
{ {
if (!_cachedTextures.TryGetValue(decal.Id, out var texture)) if (!_cachedTextures.TryGetValue(decal.Id, out var cache) && _prototypeManager.TryIndex<DecalPrototype>(decal.Id, out var decalProto))
{ {
var sprite = GetDecalSprite(decal.Id); var sprite = GetDecalSprite(decal.Id);
texture = _sprites.Frame0(sprite); cache = (_sprites.Frame0(sprite), decalProto.SnapCardinals);
_cachedTextures[decal.Id] = texture; _cachedTextures[decal.Id] = cache;
} }
if (!_prototypeManager.TryIndex<DecalPrototype>(decal.Id, out var decalProto))
continue;
var cardinal = Angle.Zero; var cardinal = Angle.Zero;
if (decalProto.SnapCardinals) if (cache.SnapCardinals)
{ {
var worldAngle = eyeAngle + worldRot; var worldAngle = eyeAngle + worldRot;
cardinal = worldAngle.GetCardinalDir().ToAngle(); cardinal = worldAngle.GetCardinalDir().ToAngle();
@@ -81,9 +78,9 @@ namespace Content.Client.Decals
var angle = decal.Angle - cardinal; var angle = decal.Angle - cardinal;
if (angle.Equals(Angle.Zero)) if (angle.Equals(Angle.Zero))
handle.DrawTexture(texture, decal.Coordinates, decal.Color); handle.DrawTexture(cache.Texture, decal.Coordinates, decal.Color);
else else
handle.DrawTexture(texture, decal.Coordinates, angle, decal.Color); handle.DrawTexture(cache.Texture, decal.Coordinates, angle, decal.Color);
} }
} }
} }