Add missing CleanReturnAsync() to some tests. (#18471)

This commit is contained in:
Leon Friedrich
2023-07-31 15:57:52 +12:00
committed by GitHub
parent a8e2be7539
commit 3e599e2306
8 changed files with 84 additions and 7 deletions

View File

@@ -10,6 +10,7 @@ public sealed class OrganComponent : Component
[DataField("body")]
public EntityUid? Body;
[DataField("parent")]
// TODO use containers. See comments in BodyPartComponent.
// Do not rely on this in client-side code.
public OrganSlot? ParentSlot;
}

View File

@@ -12,12 +12,17 @@ public sealed class BodyPartComponent : Component
[DataField("body")]
public EntityUid? Body;
[DataField("parent")]
// This inter-entity relationship makes be deeply uncomfortable because its probably going to re-encounter all of the
// networking issues that containers and joints have.
// TODO just use containers. Please.
// Do not use set or get data from this in client-side code.
public BodyPartSlot? ParentSlot;
// Do not use set or get data from this in client-side code.
[DataField("children")]
public Dictionary<string, BodyPartSlot> Children = new();
// See all the above ccomments.
[DataField("organs")]
public Dictionary<string, OrganSlot> Organs = new();

View File

@@ -48,7 +48,7 @@ public partial class SharedBodySystem
if (args.Current is not BodyComponentState state)
return;
body.Root = state.Root;
body.Root = state.Root; // TODO use containers. This is broken and does not work.
body.GibSound = state.GibSound;
}

View File

@@ -42,9 +42,9 @@ public partial class SharedBodySystem
return;
part.Body = state.Body;
part.ParentSlot = state.ParentSlot;
part.Children = state.Children;
part.Organs = state.Organs;
part.ParentSlot = state.ParentSlot; // TODO use containers. This is broken and does not work.
part.Children = state.Children; // TODO use containers. This is broken and does not work.
part.Organs = state.Organs; // TODO end my suffering.
part.PartType = state.PartType;
part.IsVital = state.IsVital;
part.Symmetry = state.Symmetry;