Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add SpawnAndDirtyAllEntities test (#13629)

Browse Source
This commit is contained in:
Leon Friedrich
2023-01-24 13:33:49 +13:00
committed by GitHub
parent fb3df96654
commit 554ec85069
6 changed files with 86 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Server/Decals/DecalSystem.cs
View File

@@ -86,7 +86,7 @@ namespace Content.Server.Decals
return;
// Should this be a full component state or a delta-state?
if (args.FromTick <= component.CreationTick && args.FromTick <= component.ForceTick)
if (args.FromTick <= component.CreationTick || args.FromTick <= component.ForceTick)
{
args.State = new DecalGridState(component.ChunkCollection.ChunkCollection);
return;

3
Content.Server/GameTicking/GameTicker.Spawning.cs
View File

@@ -361,7 +361,8 @@ namespace Content.Server.GameTicking
}
// AAAAAAAAAAAAA
_sawmill.Error("Found no observer spawn points!");
// This should be an error, if it didn't cause tests to start erroring when they delete a player.
_sawmill.Warning("Found no observer spawn points!");
return EntityCoordinates.Invalid;
}
#endregion

4
Content.Server/Mind/MindSystem.cs
View File

@@ -102,9 +102,11 @@ public sealed class MindSystem : EntitySystem
}
// TODO refactor observer spawning.
// please.
if (!spawnPosition.IsValid(EntityManager))
{
Logger.ErrorS("mind", $"Entity \"{ToPrettyString(uid)}\" for {mind.Mind?.CharacterName} was deleted, and no applicable spawn location is available.");
// This should be an error, if it didn't cause tests to start erroring when they delete a player.
Logger.WarningS("mind", $"Entity \"{ToPrettyString(uid)}\" for {mind.Mind?.CharacterName} was deleted, and no applicable spawn location is available.");
return;
}