Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Reduced Warning Count By 130 For Full Rebuilds (#26518)

Browse Source 
* remove deprecated entity coordinate extension functions. Reduces warning count by approximately 50

* final toCoords Removed

* Remove all unused variables and dead code paths

* remove always true variable, should be a cvar or something instead

* remove superfluous variables from tests
This commit is contained in:
Jake Huxell
2024-03-29 01:28:16 -04:00
committed by GitHub
parent cdfa7c3c70
commit 59e46aab93
69 changed files with 101 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Content.Shared/Construction/SharedFlatpackSystem.cs
View File

@@ -114,8 +114,7 @@ public abstract class SharedFlatpackSystem : EntitySystem
if (!Resolve(ent, ref ent.Comp))
return;
EntProtoId machinePrototypeId;
string? entityPrototype;
var machinePrototypeId = new EntProtoId();
if (TryComp<MachineBoardComponent>(board, out var machineBoard) && machineBoard.Prototype is not null)
machinePrototypeId = machineBoard.Prototype;
else if (TryComp<ComputerBoardComponent>(board, out var computerBoard) && computerBoard.Prototype is not null)