Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Server/Construction/Completions/AddContainer.cs

@@ -4,19 +4,15 @@ using Content.Server.GameObjects.Components.Construction;
 using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class AddContainer : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Container, "container", null);
-        }
-
-        public string? Container { get; private set; } = null;
+        [DataField("container")] public string? Container { get; private set; } = null;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/BuildComputer.cs

@@ -7,19 +7,15 @@ using JetBrains.Annotations;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Log;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class BuildComputer : IGraphAction
     {
-        public string Container { get; private set; } = string.Empty;
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Container, "container", string.Empty);
-        }
+        [DataField("container")] public string Container { get; private set; } = string.Empty;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/BuildMachine.cs

@@ -7,11 +7,12 @@ using JetBrains.Annotations;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Log;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class BuildMachine : IGraphAction
     {
         public async Task PerformAction(IEntity entity, IEntity? user)
@@ -104,9 +105,5 @@ namespace Content.Server.Construction.Completions
 
             entity.Delete();
         }
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-        }
     }
 }

Content.Server/Construction/Completions/DeleteEntity.cs

@@ -3,17 +3,14 @@ using System.Threading.Tasks;
 using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class DeleteEntity : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-        }
-
         public async Task PerformAction(IEntity entity, IEntity? user)
         {
             if (entity.Deleted) return;

Content.Server/Construction/Completions/EmptyAllContainers.cs

@@ -4,17 +4,14 @@ using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class EmptyAllContainers : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-        }
-
         public async Task PerformAction(IEntity entity, IEntity? user)
         {
             if (entity.Deleted || !entity.TryGetComponent<ContainerManagerComponent>(out var containerManager))

Content.Server/Construction/Completions/EmptyContainer.cs

@@ -5,19 +5,15 @@ using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class EmptyContainer : IGraphAction
     {
-        public string Container { get; private set; } = string.Empty;
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Container, "container", string.Empty);
-        }
+        [DataField("container")] public string Container { get; private set; } = string.Empty;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/MachineFrameRegenerateProgress.cs

@@ -4,16 +4,14 @@ using Content.Server.GameObjects.Components.Construction;
 using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class MachineFrameRegenerateProgress : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        { }
-
         public async Task PerformAction(IEntity entity, IEntity? user)
         {
             if (entity.Deleted)

Content.Server/Construction/Completions/PlaySound.cs

@@ -5,21 +5,16 @@ using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class PlaySound : IGraphAction
     {
-        public string SoundCollection { get; private set; } = string.Empty;
-        public string Sound { get; private set; } = string.Empty;
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Sound, "sound", string.Empty);
-            serializer.DataField(this, x => x.SoundCollection, "soundCollection", string.Empty);
-        }
+        [DataField("soundCollection")] public string SoundCollection { get; private set; } = string.Empty;
+        [DataField("sound")] public string Sound { get; private set; } = string.Empty;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/PopupUser.cs

@@ -4,21 +4,16 @@ using Content.Shared.Construction;
 using Content.Shared.Interfaces;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class PopupUser : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Text, "text", string.Empty);
-            serializer.DataField(this, x => x.Cursor, "cursor", false);
-        }
-
-        public bool Cursor { get; private set; } = false;
-        public string Text { get; private set; } = string.Empty;
+        [DataField("cursor")] public bool Cursor { get; private set; } = false;
+        [DataField("text")] public string Text { get; private set; } = string.Empty;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SetAnchor.cs

@@ -3,19 +3,15 @@ using System.Threading.Tasks;
 using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SetAnchor : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Value, "value", true);
-        }
-
-        public bool Value { get; private set; } = true;
+        [DataField("value")] public bool Value { get; private set; } = true;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SetStackCount.cs

@@ -1,24 +1,20 @@
 #nullable enable
+using System;
 using System.Threading.Tasks;
 using Content.Server.GameObjects.Components.Stack;
 using Content.Shared.Construction;
 using JetBrains.Annotations;
-using System;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Log;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SetStackCount : IGraphAction
     {
-        public int Amount { get; private set; }
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Amount, "amount", 1);
-        }
+        [DataField("amount")] public int Amount { get; private set; } = 1;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SnapToGrid.cs

@@ -6,20 +6,17 @@ using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Serialization;
 using Robust.Shared.Maths;
+using Robust.Shared.Serialization.Manager.Attributes;
+using YamlDotNet.Serialization;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SnapToGrid : IGraphAction
     {
-        public SnapGridOffset Offset { get; private set; } = SnapGridOffset.Center;
-        public bool SouthRotation { get; private set; } = false;
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Offset, "offset", SnapGridOffset.Center);
-            serializer.DataField(this, x => x.SouthRotation, "southRotation", false);
-        }
+        [DataField("offset")] public SnapGridOffset Offset { get; private set; } = SnapGridOffset.Center;
+        [DataField("southRotation")] public bool SouthRotation { get; private set; } = false;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SpawnPrototype.cs

@@ -7,22 +7,16 @@ using Content.Shared.Utility;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SpawnPrototype : IGraphAction
     {
-        public string Prototype { get; private set; } = string.Empty;
-        public int Amount { get; private set; } = 1;
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Prototype, "prototype", string.Empty);
-            serializer.DataField(this, x => x.Amount, "amount", 1);
-        }
-
+        [DataField("prototype")] public string Prototype { get; private set; } = string.Empty;
+        [DataField("amount")] public int Amount { get; private set; } = 1;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SpriteChange.cs

@@ -4,22 +4,17 @@ using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SpriteChange : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.SpriteSpecifier, "specifier", SpriteSpecifier.Invalid);
-            serializer.DataField(this, x => x.Layer, "layer", 0);
-        }
-
-        public int Layer { get; private set; } = 0;
-        public SpriteSpecifier? SpriteSpecifier { get; private set; } = SpriteSpecifier.Invalid;
+        [DataField("layer")] public int Layer { get; private set; } = 0;
+        [DataField("specifier")]  public SpriteSpecifier? SpriteSpecifier { get; private set; } = SpriteSpecifier.Invalid;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/SpriteStateChange.cs

@@ -4,21 +4,16 @@ using Content.Shared.Construction;
 using JetBrains.Annotations;
 using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class SpriteStateChange : IGraphAction
     {
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.State, "state", string.Empty);
-            serializer.DataField(this, x => x.Layer, "layer", 0);
-        }
-
-        public int Layer { get; private set; } = 0;
-        public string? State { get; private set; } = string.Empty;
+        [DataField("layer")] public int Layer { get; private set; } = 0;
+        [DataField("state")] public string? State { get; private set; } = string.Empty;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {

Content.Server/Construction/Completions/VisualizerDataInt.cs

@@ -6,11 +6,12 @@ using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Reflection;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.Construction.Completions
 {
     [UsedImplicitly]
+    [DataDefinition]
     public class VisualizerDataInt : IGraphAction
     {
         [Dependency] private readonly IReflectionManager _reflectionManager = default!;
@@ -20,14 +21,8 @@ namespace Content.Server.Construction.Completions
             IoCManager.InjectDependencies(this);
         }
 
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(this, x => x.Key, "key", string.Empty);
-            serializer.DataField(this, x => x.Data, "data", 0);
-        }
-
-        public string? Key { get; private set; } = string.Empty;
-        public int Data { get; private set; } = 0;
+        [DataField("key")] public string Key { get; private set; } = string.Empty;
+        [DataField("data")] public int Data { get; private set; } = 0;
 
         public async Task PerformAction(IEntity entity, IEntity? user)
         {