Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Server/GameObjects/Components/Body/Behavior/LiverBehavior.cs

@@ -3,9 +3,10 @@ using System.Linq;
 using Content.Server.GameObjects.Components.Body.Circulatory;
 using Content.Shared.Chemistry;
 using Content.Shared.GameObjects.Components.Body.Networks;
+using Content.Shared.Interfaces.Chemistry;
 using Robust.Shared.IoC;
 using Robust.Shared.Prototypes;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Body.Behavior
@@ -27,21 +28,25 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
         /// <summary>
         ///     Modifier for alcohol damage.
         /// </summary>
+        [DataField("alcoholLethality")]
         [ViewVariables] private float _alcoholLethality = 0.005f;
 
         /// <summary>
         ///     Modifier for alcohol damage.
         /// </summary>
+        [DataField("alcoholExponent")]
         [ViewVariables] private float _alcoholExponent = 1.6f;
 
         /// <summary>
         ///     Toxin volume that can be purged without damage.
         /// </summary>
+        [DataField("toxinTolerance")]
         [ViewVariables] private float _toxinTolerance = 3f;
 
         /// <summary>
         ///     Toxin damage modifier.
         /// </summary>
+        [DataField("toxinLethality")]
         [ViewVariables] private float _toxinLethality = 0.01f;
 
         /// <summary>
@@ -102,15 +107,5 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
                 }
             }
         }
-
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            //Uses typical human values for defaults.
-            base.ExposeData(serializer);
-            serializer.DataField(ref _alcoholLethality, "alcoholLethality", 0.005f);
-            serializer.DataField(ref _alcoholExponent, "alcoholExponent", 1.6f);
-            serializer.DataField(ref _toxinTolerance, "toxinTolerance", 3f);
-            serializer.DataField(ref _toxinLethality, "toxinLethality", 0.01f);
-        }
     }
 }

Content.Server/GameObjects/Components/Body/Behavior/LungBehavior.cs

@@ -10,12 +10,13 @@ using Content.Shared.GameObjects.Components.Body;
 using Content.Shared.GameObjects.Components.Mobs.State;
 using Robust.Shared.IoC;
 using Robust.Shared.Localization;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Timing;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Body.Behavior
 {
+    [DataDefinition]
     public class LungBehavior : MechanismBehavior
     {
         [Dependency] private readonly IGameTiming _gameTiming = default!;
@@ -24,43 +25,27 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
 
         [ViewVariables] private TimeSpan _lastGaspPopupTime;
 
-        [ViewVariables] public GasMixture Air { get; set; } = default!;
+        [DataField("air")]
+        [ViewVariables]
+        public GasMixture Air { get; set; } = new()
+        {
+            Volume = 6,
+            Temperature = Atmospherics.NormalBodyTemperature
+        };
 
-        [ViewVariables] public float Temperature => Air.Temperature;
-
-        [ViewVariables] public float Volume => Air.Volume;
-
-        [ViewVariables] public TimeSpan GaspPopupCooldown { get; private set; }
+        [DataField("gaspPopupCooldown")]
+        [ViewVariables]
+        public TimeSpan GaspPopupCooldown { get; private set; } = TimeSpan.FromSeconds(8);
 
         [ViewVariables] public LungStatus Status { get; set; }
 
-        [ViewVariables] public float CycleDelay { get; set; }
+        [DataField("cycleDelay")]
+        [ViewVariables]
+        public float CycleDelay { get; set; } = 2;
 
-        public override void ExposeData(ObjectSerializer serializer)
+        public LungBehavior()
         {
-            base.ExposeData(serializer);
-
-            Air = new GasMixture {Temperature = Atmospherics.NormalBodyTemperature};
-
-            serializer.DataField(this, l => l.CycleDelay, "cycleDelay", 2);
-
-            serializer.DataReadWriteFunction(
-                "volume",
-                6,
-                vol => Air.Volume = vol,
-                () => Air.Volume);
-
-            serializer.DataReadWriteFunction(
-                "temperature",
-                Atmospherics.NormalBodyTemperature,
-                temp => Air.Temperature = temp,
-                () => Air.Temperature);
-
-            serializer.DataReadWriteFunction(
-                "gaspPopupCooldown",
-                8f,
-                delay => GaspPopupCooldown = TimeSpan.FromSeconds(delay),
-                () => GaspPopupCooldown.TotalSeconds);
+            IoCManager.InjectDependencies(this);
         }
 
         protected override void OnAddedToBody(IBody body)

Content.Server/GameObjects/Components/Body/Behavior/MechanismBehavior.cs

@@ -4,7 +4,6 @@ using Content.Shared.GameObjects.Components.Body.Behavior;
 using Content.Shared.GameObjects.Components.Body.Mechanism;
 using Content.Shared.GameObjects.Components.Body.Part;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
 using Robust.Shared.Utility;
 
 namespace Content.Server.GameObjects.Components.Body.Behavior
@@ -19,8 +18,6 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
 
         public IEntity Owner => Parent.Owner;
 
-        public virtual void ExposeData(ObjectSerializer serializer) { }
-
         public virtual void Initialize(IMechanism parent)
         {
             Parent = parent;

Content.Server/GameObjects/Components/Body/Behavior/StomachBehavior.cs

@@ -7,7 +7,7 @@ using Content.Shared.Chemistry;
 using Content.Shared.GameObjects.Components.Body.Networks;
 using Content.Shared.GameObjects.Components.Chemistry;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Body.Behavior
@@ -89,15 +89,16 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
         /// <summary>
         ///     Initial internal solution storage volume
         /// </summary>
+        [DataField("maxVolume")]
         [ViewVariables]
-        protected ReagentUnit InitialMaxVolume { get; private set; }
+        protected ReagentUnit InitialMaxVolume { get; private set; } = ReagentUnit.New(100);
 
         /// <summary>
         ///     Time in seconds between reagents being ingested and them being
         ///     transferred to <see cref="SharedBloodstreamComponent"/>
         /// </summary>
-        [ViewVariables]
-        private float _digestionDelay;
+        [DataField("digestionDelay")] [ViewVariables]
+        private float _digestionDelay = 20;
 
         /// <summary>
         ///     Used to track how long each reagent has been in the stomach
@@ -105,13 +106,6 @@ namespace Content.Server.GameObjects.Components.Body.Behavior
         [ViewVariables]
         private readonly List<ReagentDelta> _reagentDeltas = new();
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-            serializer.DataField(this, s => s.InitialMaxVolume, "maxVolume", ReagentUnit.New(100));
-            serializer.DataField(ref _digestionDelay, "digestionDelay", 20);
-        }
-
         public override void Startup()
         {
             base.Startup();