Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Server/GameObjects/Components/Fluids/BucketComponent.cs

@@ -1,5 +1,4 @@
 #nullable enable
-using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
 using Content.Server.GameObjects.Components.Chemistry;
@@ -11,8 +10,7 @@ using Content.Shared.Utility;
 using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Localization;
-using Robust.Shared.Log;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.GameObjects.Components.Fluids
 {
@@ -42,13 +40,8 @@ namespace Content.Server.GameObjects.Components.Fluids
             ? solution.CurrentVolume
             : ReagentUnit.Zero;
 
-        private string? _sound;
-
-        /// <inheritdoc />
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataFieldCached(ref _sound, "sound", "/Audio/Effects/Fluids/watersplash.ogg");
-        }
+        [DataField("sound")]
+        private string? _sound = "/Audio/Effects/Fluids/watersplash.ogg";
 
         /// <inheritdoc />
         public override void Initialize()

Content.Server/GameObjects/Components/Fluids/MopComponent.cs

@@ -11,6 +11,8 @@ using System.Threading.Tasks;
 using Content.Server.GameObjects.EntitySystems.DoAfter;
 using Robust.Server.GameObjects;
 using Robust.Shared.ViewVariables;
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.Manager.Attributes;
 
 namespace Content.Server.GameObjects.Components.Fluids
 {
@@ -22,12 +24,10 @@ namespace Content.Server.GameObjects.Components.Fluids
     {
         public override string Name => "Mop";
 
-        public bool Mopping => _mopping;
-
         /// <summary>
         ///     Used to prevent do_after spam if we're currently mopping.
         /// </summary>
-        private bool _mopping;
+        public bool Mopping { get; private set; }
 
         public SolutionContainerComponent? Contents => Owner.GetComponentOrNull<SolutionContainerComponent>();
 
@@ -50,25 +50,18 @@ namespace Content.Server.GameObjects.Components.Fluids
         // Picking up a puddle requires multiple clicks
         // Dumping in a bucket requires 1 click
         // Long-term you'd probably use a cooldown and start the pickup once we have some form of global cooldown
-        public ReagentUnit PickupAmount => _pickupAmount;
-        private ReagentUnit _pickupAmount;
+        [field: DataField("pickup_amount")]
+        public ReagentUnit PickupAmount { get; } = ReagentUnit.New(5);
 
-        private string? _pickupSound;
+        [DataField("pickup_sound")]
+        private string? _pickupSound = "/Audio/Effects/Fluids/slosh.ogg";
 
         /// <summary>
         ///     Multiplier for the do_after delay for how fast the mop works.
         /// </summary>
         [ViewVariables]
-        private float _mopSpeed;
-
-        /// <inheritdoc />
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataFieldCached(ref _pickupSound, "pickup_sound", "/Audio/Effects/Fluids/slosh.ogg");
-            // The turbo mop will pickup more
-            serializer.DataFieldCached(ref _pickupAmount, "pickup_amount", ReagentUnit.New(5));
-            serializer.DataField(ref _mopSpeed, "speed", 1.0f);
-        }
+        [DataField("speed")]
+        private float _mopSpeed = 1;
 
         public override void Initialize()
         {
@@ -88,7 +81,7 @@ namespace Content.Server.GameObjects.Components.Fluids
              */
 
             if (!Owner.TryGetComponent(out SolutionContainerComponent? contents) ||
-                _mopping ||
+                Mopping ||
                 !eventArgs.InRangeUnobstructed(ignoreInsideBlocker: true, popup: true))
             {
                 return false;
@@ -121,7 +114,7 @@ namespace Content.Server.GameObjects.Components.Fluids
                 return false;
             }
 
-            _mopping = true;
+            Mopping = true;
 
             // So if the puddle has 20 units we mop in 2 seconds. Don't just store CurrentVolume given it can change so need to re-calc it anyway.
             var doAfterArgs = new DoAfterEventArgs(eventArgs.User, _mopSpeed * puddleVolume.Float() / 10.0f, target: eventArgs.Target)
@@ -132,7 +125,7 @@ namespace Content.Server.GameObjects.Components.Fluids
             };
             var result = await EntitySystem.Get<DoAfterSystem>().DoAfter(doAfterArgs);
 
-            _mopping = false;
+            Mopping = false;
 
             if (result == DoAfterStatus.Cancelled ||
                 Owner.Deleted ||

Content.Server/GameObjects/Components/Fluids/PuddleComponent.cs

@@ -16,7 +16,9 @@ using Robust.Shared.Localization;
 using Robust.Shared.Map;
 using Robust.Shared.Maths;
 using Robust.Shared.Random;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
 
@@ -45,7 +47,8 @@ namespace Content.Server.GameObjects.Components.Fluids
         public override string Name => "Puddle";
 
         private CancellationTokenSource _evaporationToken;
-        private ReagentUnit _evaporateThreshold; // How few <Solution Quantity> we can hold prior to self-destructing
+        [DataField("evaporate_threshold")]
+        private ReagentUnit _evaporateThreshold = ReagentUnit.New(20); // How few <Solution Quantity> we can hold prior to self-destructing
         public ReagentUnit EvaporateThreshold
         {
             get => _evaporateThreshold;
@@ -61,9 +64,11 @@ namespace Content.Server.GameObjects.Components.Fluids
         /// <summary>
         ///     The time that it will take this puddle to evaporate, in seconds.
         /// </summary>
-        public float EvaporateTime { get; private set; }
+        [DataField("evaporate_time")]
+        public float EvaporateTime { get; private set; } = 5f;
 
-        private string _spillSound;
+        [DataField("spill_sound")]
+        private string _spillSound = "/Audio/Effects/Fluids/splat.ogg";
 
         /// <summary>
         /// Whether or not this puddle is currently overflowing onto its neighbors
@@ -86,29 +91,20 @@ namespace Content.Server.GameObjects.Components.Fluids
         // Currently a random number, potentially change
         public ReagentUnit OverflowVolume => _overflowVolume;
         [ViewVariables]
-        private ReagentUnit _overflowVolume;
+        [DataField("overflow_volume")]
+        private ReagentUnit _overflowVolume = ReagentUnit.New(20);
         private ReagentUnit OverflowLeft => CurrentVolume - OverflowVolume;
 
         private SolutionContainerComponent _contents;
         public bool EmptyHolder => _contents.ReagentList.Count == 0;
-        private int _spriteVariants;
+        [DataField("variants")]
+        private int _spriteVariants = 1;
         // Whether the underlying solution color should be used
-        private bool _recolor;
+        [DataField("recolor")]
+        private bool _recolor = default;
 
         private bool Slippery => Owner.TryGetComponent(out SlipperyComponent slippery) && slippery.Slippery;
 
-        /// <inheritdoc />
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataFieldCached(ref _spillSound, "spill_sound", "/Audio/Effects/Fluids/splat.ogg");
-            serializer.DataField(ref _overflowVolume, "overflow_volume", ReagentUnit.New(20));
-            serializer.DataField(this, x => x.EvaporateTime, "evaporate_time", 5.0f);
-            // Long-term probably have this based on the underlying reagents
-            serializer.DataField(ref _evaporateThreshold, "evaporate_threshold", ReagentUnit.New(20));
-            serializer.DataField(ref _spriteVariants, "variants", 1);
-            serializer.DataField(ref _recolor, "recolor", false);
-        }
-
         public override void Initialize()
         {
             base.Initialize();

Content.Server/GameObjects/Components/Fluids/SprayComponent.cs

@@ -14,8 +14,10 @@ using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Localization;
 using Robust.Shared.Maths;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
 using Robust.Shared.Timing;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Fluids
@@ -28,18 +30,28 @@ namespace Content.Server.GameObjects.Components.Fluids
         [Dependency] private readonly IGameTiming _gameTiming = default!;
         [Dependency] private readonly IServerEntityManager _serverEntityManager = default!;
 
-        private ReagentUnit _transferAmount;
+        [DataField("transferAmount")]
+        private ReagentUnit _transferAmount = ReagentUnit.New(10);
+        [DataField("spraySound")]
         private string _spraySound;
-        private float _sprayVelocity;
-        private float _sprayAliveTime;
+        [DataField("sprayVelocity")]
+        private float _sprayVelocity = 1.5f;
+        [DataField("sprayAliveTime")]
+        private float _sprayAliveTime = 0.75f;
         private TimeSpan _lastUseTime;
         private TimeSpan _cooldownEnd;
-        private float _cooldownTime;
-        private string _vaporPrototype;
-        private int _vaporAmount;
-        private float _vaporSpread;
+        [DataField("cooldownTime")]
+        private float _cooldownTime = 0.5f;
+        [DataField("sprayedPrototype")]
+        private string _vaporPrototype = "Vapor";
+        [DataField("vaporAmount")]
+        private int _vaporAmount = 1;
+        [DataField("vaporSpread")]
+        private float _vaporSpread = 90f;
+        [DataField("hasSafety")]
         private bool _hasSafety;
-        private bool _safety;
+        [DataField("safety")]
+        private bool _safety = true;
 
         /// <summary>
         ///     The amount of solution to be sprayer from this solution when using it
@@ -77,21 +89,6 @@ namespace Content.Server.GameObjects.Components.Fluids
             }
         }
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-            serializer.DataField(ref _vaporPrototype, "sprayedPrototype", "Vapor");
-            serializer.DataField(ref _vaporAmount, "vaporAmount", 1);
-            serializer.DataField(ref _vaporSpread, "vaporSpread", 90f);
-            serializer.DataField(ref _cooldownTime, "cooldownTime", 0.5f);
-            serializer.DataField(ref _transferAmount, "transferAmount", ReagentUnit.New(10));
-            serializer.DataField(ref _sprayVelocity, "sprayVelocity", 1.5f);
-            serializer.DataField(ref _spraySound, "spraySound", string.Empty);
-            serializer.DataField(ref _sprayAliveTime, "sprayAliveTime", 0.75f);
-            serializer.DataField(ref _hasSafety, "hasSafety", false);
-            serializer.DataField(ref _safety, "safety", true);
-        }
-
         async Task<bool> IAfterInteract.AfterInteract(AfterInteractEventArgs eventArgs)
         {
             if (!ActionBlockerSystem.CanInteract(eventArgs.User))