Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Server/GameObjects/Components/Research/LatheComponent.cs

@@ -160,7 +160,7 @@ namespace Content.Server.GameObjects.Components.Research
             var totalAmount = 0;
 
             // Check if it can insert all materials.
-            foreach (var mat in material.MaterialTypes.Values)
+            foreach (var (_, mat) in material.MaterialTypes)
             {
                 // TODO: Change how MaterialComponent works so this is not hard-coded.
                 if (!storage.CanInsertMaterial(mat.ID, VolumePerSheet * multiplier)) return false;
@@ -170,13 +170,13 @@ namespace Content.Server.GameObjects.Components.Research
             // Check if it can take ALL of the material's volume.
             if (storage.CanTakeAmount(totalAmount)) return false;
 
-            foreach (var mat in material.MaterialTypes.Values)
+            foreach (var (_, mat) in material.MaterialTypes)
             {
                 storage.InsertMaterial(mat.ID, VolumePerSheet * multiplier);
             }
 
             State = LatheState.Inserting;
-            switch (material.MaterialTypes.Values.First().Name)
+            switch (material.MaterialTypes.First().Value.Name)
             {
                 case "steel":
                     SetAppearance(LatheVisualState.InsertingMetal);

Content.Server/GameObjects/Components/Research/LatheDatabaseComponent.cs

@@ -2,7 +2,7 @@
 using Content.Shared.Research;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Players;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Research
@@ -15,21 +15,14 @@ namespace Content.Server.GameObjects.Components.Research
         ///     Whether new recipes can be added to this database or not.
         /// </summary>
         [ViewVariables]
-        public bool Static => _static;
-        private bool _static = false;
+        [field: DataField("static")]
+        public bool Static { get; private set; } = false;
 
         public override ComponentState GetComponentState(ICommonSession player)
         {
             return new LatheDatabaseState(GetRecipeIdList());
         }
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-
-            serializer.DataField(ref _static, "static", false);
-        }
-
         public override void Clear()
         {
             if (Static) return;

Content.Server/GameObjects/Components/Research/MaterialStorageComponent.cs

@@ -2,7 +2,9 @@
 using Content.Shared.GameObjects.Components.Research;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Players;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Research
@@ -19,7 +21,8 @@ namespace Content.Server.GameObjects.Components.Research
         /// </summary>
         [ViewVariables]
         public int StorageLimit => _storageLimit;
-        private int _storageLimit;
+        [DataField("StorageLimit")]
+        private int _storageLimit = -1;
 
         public override ComponentState GetComponentState(ICommonSession player)
         {
@@ -77,12 +80,5 @@ namespace Content.Server.GameObjects.Components.Research
         {
             return InsertMaterial(ID, -amount);
         }
-
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-
-            serializer.DataField(ref _storageLimit, "StorageLimit", -1);
-        }
     }
 }

Content.Server/GameObjects/Components/Research/ProtolatheDatabaseComponent.cs

@@ -1,3 +1,4 @@
+using System.Linq;
 using Content.Shared.GameObjects.Components.Research;
 using Content.Shared.Research;
 using Robust.Shared.GameObjects;

Content.Server/GameObjects/Components/Research/ResearchPointSourceComponent.cs

@@ -1,7 +1,9 @@
 using Content.Server.GameObjects.Components.Power.ApcNetComponents;
 using Content.Shared.Interfaces.GameObjects.Components;
 using Robust.Shared.GameObjects;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Research
@@ -12,7 +14,9 @@ namespace Content.Server.GameObjects.Components.Research
     {
         public override string Name => "ResearchPointSource";
 
+        [DataField("pointspersecond")]
         private int _pointsPerSecond;
+        [DataField("active")]
         private bool _active;
         private PowerReceiverComponent _powerReceiver;
 
@@ -42,13 +46,5 @@ namespace Content.Server.GameObjects.Components.Research
             base.Initialize();
             Owner.TryGetComponent(out _powerReceiver);
         }
-
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-
-            serializer.DataField(ref _pointsPerSecond, "pointspersecond", 0);
-            serializer.DataField(ref _active, "active", false);
-        }
     }
 }

Content.Server/GameObjects/Components/Research/ResearchServerComponent.cs

@@ -3,7 +3,7 @@ using Content.Server.GameObjects.Components.Power.ApcNetComponents;
 using Content.Server.GameObjects.EntitySystems;
 using Content.Shared.Research;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Research
@@ -17,11 +17,12 @@ namespace Content.Server.GameObjects.Components.Research
 
         [ViewVariables(VVAccess.ReadWrite)] public string ServerName => _serverName;
 
+        [DataField("servername")]
         private string _serverName = "RDSERVER";
         private float _timer = 0f;
         public TechnologyDatabaseComponent Database { get; private set; }
 
-        [ViewVariables(VVAccess.ReadWrite)] private int _points = 0;
+        [ViewVariables(VVAccess.ReadWrite)] [DataField("points")] private int _points = 0;
 
         [ViewVariables(VVAccess.ReadOnly)] public int Id { get; private set; }
 
@@ -83,13 +84,6 @@ namespace Content.Server.GameObjects.Components.Research
             EntitySystem.Get<ResearchSystem>()?.UnregisterServer(this);
         }
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-            serializer.DataField(ref _serverName, "servername", "RDSERVER");
-            serializer.DataField(ref _points, "points", 0);
-        }
-
         public bool CanUnlockTechnology(TechnologyPrototype technology)
         {
             if (!Database.CanUnlockTechnology(technology) || _points < technology.RequiredPoints ||