Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Shared/Materials/Material.cs

@@ -1,10 +1,9 @@
 #nullable enable
-using Robust.Shared.IoC;
 using Robust.Shared.Maths;
 using Robust.Shared.Prototypes;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
-using YamlDotNet.RepresentationModel;
+using Robust.Shared.ViewVariables;
 
 namespace Content.Shared.Materials
 {
@@ -12,120 +11,79 @@ namespace Content.Shared.Materials
     ///     Materials are read-only storage for the properties of specific materials.
     ///     Properties should be intrinsic (or at least as much is necessary for game purposes).
     /// </summary>
-    public class Material : IExposeData
+    [Prototype("material")]
+    [DataDefinition]
+    public class MaterialPrototype : IPrototype
     {
-        public string Name => _name;
-        private string _name = "unobtanium";
+        [ViewVariables]
+        [field: DataField("id", required: true)]
+        public string ID { get; } = default!;
 
-        public Color Color => _color;
-        private Color _color = Color.Gray;
+        [ViewVariables]
+        [field: DataField("parent")]
+        public string? Parent { get; }
+
+        [DataField("name")] public string Name { get; private set; } = "unobtanium";
+
+        [DataField("color")] public Color Color { get; private set; } = Color.Gray;
 
         /// <summary>
         ///     Volumetric mass density, in kg.m^-3.
         /// </summary>
-        public double Density => _density;
-        private double _density = 1;
+        [DataField("density")]
+        public double Density { get; private set; } = 1;
 
         /// <summary>
         ///     Electrical resistivity, NOT resistance.
         ///     Unit is ohm-meter (Ω⋅m).
         /// </summary>
-        public double ElectricResistivity => _electricResistivity;
-        private double _electricResistivity = 1;
+        [DataField("electricResistivity")]
+        public double ElectricResistivity { get; private set; } = 1;
 
         /// <summary>
         ///     Thermal conductivity, in W.m-1.K-1
         /// </summary>
-        public double ThermalConductivity => _thermalConductivity;
-        private double _thermalConductivity = 1;
+        [DataField("thermalConductivity")]
+        public double ThermalConductivity { get; private set; } = 1;
 
         /// <summary>
         ///     Specific heat, in J.kg-1.K-1
         /// </summary>
-        public double SpecificHeat => _specificHeat;
-        private double _specificHeat = 1;
+        [DataField("specificHeat")]
+        public double SpecificHeat { get; private set; } = 1;
 
         /// <summary>
         ///     Controls how durable the material is.
         ///     Basically how slowly it degrades.
         /// </summary>
-        public double Durability => _durability;
-        private double _durability = 1;
+        [DataField("durability")]
+        public double Durability { get; private set; } = 1;
 
         /// <summary>
         ///     Multiplier for how much this resists damage.
         ///     So higher means armor is more effective, for example.
         /// </summary>
-        public double Hardness => _hardness;
-        private double _hardness = 1;
+        [DataField("hardness")]
+        public double Hardness { get; private set; } = 1;
 
         /// <summary>
         ///     Multiplier that determines damage on sharpness-based weapons like knives.
         ///     Higher means more damage is done.
         /// </summary>
-        public double SharpDamage => _sharpDamage;
-        private double _sharpDamage = 1;
+        [DataField("sharpDamage")]
+        public double SharpDamage { get; private set; } = 1;
 
         /// <summary>
         ///     Multiplier that determines damage on blunt-based weapons like clubs.
         ///     Higher means more damage is done.
         /// </summary>
-        public double BluntDamage => _bluntDamage;
-        private double _bluntDamage = 1;
+        [DataField("bluntDamage")]
+        public double BluntDamage { get; private set; } = 1;
 
         /// <summary>
         ///     An icon used to represent the material in graphic interfaces.
         /// </summary>
-        public SpriteSpecifier Icon => _icon;
-        private SpriteSpecifier _icon = SpriteSpecifier.Invalid;
-
-        public string? ID
-        {
-            get
-            {
-                var prototypeManager = IoCManager.Resolve<IPrototypeManager>();
-                foreach (var prototype in prototypeManager.EnumeratePrototypes<MaterialPrototype>())
-                {
-                    if (prototype.Material == this) return prototype.ID;
-                }
-
-                return null;
-            }
-        }
-
-        void IExposeData.ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(ref _name, "name", "unobtanium", alwaysWrite: true);
-            serializer.DataField(ref _color, "color", Color.Gray, alwaysWrite: true);
-
-            // All default material params are initialized to 1 because
-            // I'm too lazy to figure out for which that's necessary to prevent divisions by zero in case left out.
-            serializer.DataField(ref _density, "density", 1, alwaysWrite: true);
-            serializer.DataField(ref _electricResistivity, "electricResistivity", 1, alwaysWrite: true);
-            serializer.DataField(ref _thermalConductivity, "thermalConductivity", 1, alwaysWrite: true);
-            serializer.DataField(ref _specificHeat, "specificHeat", 1, alwaysWrite: true);
-            serializer.DataField(ref _durability, "durability", 1, alwaysWrite: true);
-            serializer.DataField(ref _hardness, "hardness", 1, alwaysWrite: true);
-            serializer.DataField(ref _sharpDamage, "sharpDamage", 1, alwaysWrite: true);
-            serializer.DataField(ref _bluntDamage, "bluntDamage", 1, alwaysWrite: true);
-            serializer.DataField(ref _icon, "icon", SpriteSpecifier.Invalid, alwaysWrite: true);
-        }
-    }
-
-    [Prototype("material")]
-    public class MaterialPrototype : IPrototype
-    {
-        public string ID { get; private set; } = string.Empty;
-
-        public Material Material { get; private set; } = new();
-
-        public void LoadFrom(YamlMappingNode mapping)
-        {
-            ID = mapping["id"].AsString();
-
-            var ser = YamlObjectSerializer.NewReader(mapping);
-            Material = new Material();
-            ((IExposeData) Material).ExposeData(ser);
-        }
+        [DataField("icon")]
+        public SpriteSpecifier Icon { get; private set; } = SpriteSpecifier.Invalid;
     }
 }