Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
This commit is contained in:
Paul Ritter
2021-03-05 01:08:38 +01:00
committed by GitHub
parent 05d4d9692c
commit 5c50b1f6ed
545 changed files with 4547 additions and 6650 deletions

View File

@@ -3,26 +3,26 @@ using System;
using Robust.Shared.IoC;
using Robust.Shared.Prototypes;
using Robust.Shared.Serialization;
using Robust.Shared.Serialization.Manager.Attributes;
using Robust.Shared.Utility;
using Robust.Shared.ViewVariables;
using YamlDotNet.RepresentationModel;
namespace Content.Shared.Prototypes.Cargo
{
[NetSerializable, Serializable, Prototype("cargoProduct")]
public class CargoProductPrototype : IPrototype
{
private string _id = string.Empty;
private string _name = string.Empty;
private string _description = string.Empty;
private SpriteSpecifier _icon = SpriteSpecifier.Invalid;
private string _product = string.Empty;
private int _pointCost;
private string _category = string.Empty;
private string _group = string.Empty;
[DataField("name")] private string _name = string.Empty;
[DataField("description")] private string _description = string.Empty;
[ViewVariables]
public string ID => _id;
[field: DataField("id", required: true)]
public string ID { get; } = default!;
[ViewVariables]
[field: DataField("parent")]
public string? Parent { get; }
/// <summary>
/// Product name.
@@ -35,7 +35,7 @@ namespace Content.Shared.Prototypes.Cargo
if (_name.Trim().Length != 0)
return _name;
if (IoCManager.Resolve<IPrototypeManager>().TryIndex(_product, out EntityPrototype? prototype))
if (IoCManager.Resolve<IPrototypeManager>().TryIndex(Product, out EntityPrototype? prototype))
{
_name = prototype.Name;
}
@@ -55,7 +55,7 @@ namespace Content.Shared.Prototypes.Cargo
if (_description.Trim().Length != 0)
return _description;
if (IoCManager.Resolve<IPrototypeManager>().TryIndex(_product, out EntityPrototype? prototype))
if (IoCManager.Resolve<IPrototypeManager>().TryIndex(Product, out EntityPrototype? prototype))
{
_description = prototype.Description;
}
@@ -68,49 +68,40 @@ namespace Content.Shared.Prototypes.Cargo
/// Texture path used in the CargoConsole GUI.
/// </summary>
[ViewVariables]
public SpriteSpecifier Icon => _icon;
[field: DataField("icon")]
public SpriteSpecifier Icon { get; } = SpriteSpecifier.Invalid;
/// <summary>
/// The prototype name of the product.
/// </summary>
[ViewVariables]
public string Product => _product;
[field: DataField("product")]
public string Product { get; } = string.Empty;
/// <summary>
/// The point cost of the product.
/// </summary>
[ViewVariables]
public int PointCost => _pointCost;
[field: DataField("cost")]
public int PointCost { get; }
/// <summary>
/// The prototype category of the product. (e.g. Engineering, Medical)
/// </summary>
[ViewVariables]
public string Category => _category;
[field: DataField("category")]
public string Category { get; } = string.Empty;
/// <summary>
/// The prototype group of the product. (e.g. Contraband)
/// </summary>
[ViewVariables]
public string Group => _group;
[field: DataField("group")]
public string Group { get; } = string.Empty;
public CargoProductPrototype()
{
IoCManager.InjectDependencies(this);
}
public void LoadFrom(YamlMappingNode mapping)
{
var serializer = YamlObjectSerializer.NewReader(mapping);
serializer.DataField(ref _name, "name", string.Empty);
serializer.DataField(ref _id, "id", string.Empty);
serializer.DataField(ref _description, "description", string.Empty);
serializer.DataField(ref _icon, "icon", SpriteSpecifier.Invalid);
serializer.DataField(ref _product, "product", string.Empty);
serializer.DataField(ref _pointCost, "cost", 0);
serializer.DataField(ref _category, "category", string.Empty);
serializer.DataField(ref _group, "group", string.Empty);
}
}
}

View File

@@ -1,26 +1,22 @@
#nullable enable
using System.Collections.Generic;
using Robust.Shared.Prototypes;
using Robust.Shared.Serialization;
using YamlDotNet.RepresentationModel;
using Robust.Shared.Serialization.Manager.Attributes;
using Robust.Shared.ViewVariables;
namespace Content.Shared.Prototypes
{
[Prototype("dataset")]
public class DatasetPrototype : IPrototype
{
private string _id = string.Empty;
public string ID => _id;
[ViewVariables]
[field: DataField("id", required: true)]
public string ID { get; } = default!;
private List<string> _values = new();
public IReadOnlyList<string> Values => _values;
[ViewVariables]
[field: DataField("parent")]
public string? Parent { get; }
public void LoadFrom(YamlMappingNode mapping)
{
var ser = YamlObjectSerializer.NewReader(mapping);
ser.DataField(ref _id, "id", string.Empty);
ser.DataField(ref _values, "values", new List<string>());
}
[field: DataField("values")] public IReadOnlyList<string> Values { get; } = new List<string>();
}
}

View File

@@ -2,8 +2,8 @@
using System.Collections.Generic;
using Robust.Shared.Localization;
using Robust.Shared.Prototypes;
using Robust.Shared.Serialization;
using YamlDotNet.RepresentationModel;
using Robust.Shared.Serialization.Manager.Attributes;
using Robust.Shared.ViewVariables;
namespace Content.Shared.Prototypes.Kitchen
{
@@ -13,31 +13,32 @@ namespace Content.Shared.Prototypes.Kitchen
[Prototype("microwaveMealRecipe")]
public class FoodRecipePrototype : IPrototype
{
private string _id = string.Empty;
private string _name = string.Empty;
private string _result = string.Empty;
private int _cookTime;
[ViewVariables]
[field: DataField("id", required: true)]
public string ID { get; } = default!;
private Dictionary<string, int> _ingsReagents = new();
private Dictionary<string, int> _ingsSolids = new();
[ViewVariables]
[field: DataField("parent")]
public string? Parent { get; }
[DataField("name")]
private string _name = string.Empty;
[DataField("reagents")]
private readonly Dictionary<string, int> _ingsReagents = new();
[DataField("solids")]
private readonly Dictionary<string, int> _ingsSolids = new ();
[field: DataField("result")]
public string Result { get; } = string.Empty;
[field: DataField("time")]
public int CookTime { get; } = 5;
public string Name => Loc.GetString(_name);
public string ID => _id;
public string Result => _result;
public int CookTime => _cookTime;
public IReadOnlyDictionary<string, int> IngredientsReagents => _ingsReagents;
public IReadOnlyDictionary<string, int> IngredientsSolids => _ingsSolids;
public void LoadFrom(YamlMappingNode mapping)
{
var serializer = YamlObjectSerializer.NewReader(mapping);
serializer.DataField(ref _id, "id", string.Empty);
serializer.DataField(ref _name, "name", string.Empty);
serializer.DataField(ref _result, "result", string.Empty);
serializer.DataField(ref _ingsReagents, "reagents", new Dictionary<string, int>());
serializer.DataField(ref _ingsSolids, "solids", new Dictionary<string, int>());
serializer.DataField(ref _cookTime, "time", 5);
}
}
}

View File

@@ -1,38 +1,35 @@
#nullable enable
using Content.Shared.GameObjects.Components.PDA;
using Robust.Shared.Prototypes;
using Robust.Shared.Serialization;
using YamlDotNet.RepresentationModel;
using Robust.Shared.Serialization.Manager.Attributes;
using Robust.Shared.ViewVariables;
namespace Content.Shared.Prototypes.PDA
{
[Prototype("uplinkListing")]
public class UplinkStoreListingPrototype : IPrototype
{
private string _id = string.Empty;
private string _itemId = string.Empty;
private int _price;
private UplinkCategory _category;
private string _desc = string.Empty;
private string _name = string.Empty;
[ViewVariables]
[field: DataField("id", required: true)]
public string ID { get; } = default!;
public string ID => _id;
[ViewVariables]
[field: DataField("parent")]
public string? Parent { get; }
public string ItemId => _itemId;
public int Price => _price;
public UplinkCategory Category => _category;
public string Description => _desc;
public string ListingName => _name;
[field: DataField("itemId")]
public string ItemId { get; } = string.Empty;
public void LoadFrom(YamlMappingNode mapping)
{
var serializer = YamlObjectSerializer.NewReader(mapping);
serializer.DataField(ref _id, "id", string.Empty);
serializer.DataField(ref _itemId, "itemId", string.Empty);
serializer.DataField(ref _price, "price", 5);
serializer.DataField(ref _category, "category", UplinkCategory.Utility);
serializer.DataField(ref _desc, "description", string.Empty);
serializer.DataField(ref _name, "listingName", string.Empty);
}
[field: DataField("price")]
public int Price { get; } = 5;
[field: DataField("category")]
public UplinkCategory Category { get; } = UplinkCategory.Utility;
[field: DataField("description")]
public string Description { get; } = string.Empty;
[field: DataField("listingName")]
public string ListingName { get; } = string.Empty;
}
}

View File

@@ -1,8 +1,7 @@
#nullable enable
using JetBrains.Annotations;
using Robust.Shared.Prototypes;
using Robust.Shared.Serialization;
using YamlDotNet.RepresentationModel;
using Robust.Shared.Serialization.Manager.Attributes;
using Robust.Shared.ViewVariables;
namespace Content.Shared.Prototypes.Tag
{
@@ -14,17 +13,12 @@ namespace Content.Shared.Prototypes.Tag
[Prototype("Tag")]
public class TagPrototype : IPrototype
{
public string ID { get; [UsedImplicitly] private set; } = default!;
[ViewVariables]
[field: DataField("id", required: true)]
public string ID { get; } = default!;
private void ExposeData(ObjectSerializer serializer)
{
serializer.DataField(this, x => x.ID, "id", "");
}
public void LoadFrom(YamlMappingNode mapping)
{
var serializer = YamlObjectSerializer.NewReader(mapping);
ExposeData(serializer);
}
[ViewVariables]
[field: DataField("parent")]
public string? Parent { get; }
}
}