ECS verbs and update context menu (#4594)

* Functioning ECS verbs

Currently only ID card console works.

* Changed verb types and allow ID card insertions

* Verb GUI sorting and verb networking

* More networking, and shared components

* Clientside verbs work now.

* Verb enums changed to bitmask flags

* Verb Categories redo

* Fix range check

* GasTank Verb

* Remove unnecessary bodypart verb

* Buckle Verb

* buckle & unbuckle verbs

* Updated range checks

* Item cabinet verbs

* Add range user override

* construction verb

* Chemistry machine verbs

* Climb Verb

* Generalise pulled entity verbs

* ViewVariables Verb

* rejuvenate, delete, sentient, control verbs

* Outfit verb

* inrangeunoccluded and tubedirection verbs

* attach-to verbs

* remove unused verbs and move VV

* Rename DebugVerbSystem

* Ghost role and pointing verbs

* Remove global verbs

* Allow verbs to raise events

* Changing categories and simplifying debug verbs

* Add rotate and flip verbs

* fix rejuvenate test

* redo context menu

* new Add Gas debug verb

* Add Set Temperature debug verb

* Uncuff verb

* Disposal unit verbs

* Add pickup verb

* lock/unlock verb

* Remove verb type, add specific verb events

* rename verb messages -> events

* Context menu displays verbs by interaction type

* Updated context menu HandleMove

previously, checked if entities moved 1 tile from click location.

Now checks if entities moved out of view.

Now you can actually right-click interact with yourself while walking!

* Misc Verb menu GUI changes

* Fix non-human/ghost verbs

* Update types and categories

* Allow non-ghost/human to open context menu

* configuration verb

* tagger verb

* Morgue Verbs

* Medical Scanner Verbs

* Fix solution refactor merge issues

* Fix context menu in-view check

* Remove prepare GUI

* Redo verb restrictions

* Fix context menu UI

* Disposal Verbs

* Spill verb

* Light verb

* Hand Held light verb

* power cell verbs

* storage verbs

and adding names to insert/eject

* Pulling verb

* Close context menu on verb execution

* Strip verb

* AmmoBox verb

* fix pull verb

* gun barrel verbs

revolver verb
energy weapon verbs
Bolt action verb

* Magazine gun barrel  verbs

* Add charger verbs

* PDA verbs

* Transfer amount verb

* Add reagent verb

* make alt-click use ECS verbs

* Delete old verb files

* Magboot verb

* finalising tweaks

* context menu visibility changes

* code cleanup

* Update AdminAddReagentUI.cs

* Remove HasFlag

* Consistent verb keys

* Remove Linq, add comment

* Fix in-inventory check

* Update GUI text alignment and padding

* Added close-menu option

* Changed some "interaction" verbs to "activation"

* Remove verb keys, use sorted sets

* fix master merge

* update some verb text

* Undo Changes

Remove some new verbs that can be added later

undid some .ftl bugfixes, can and should be done separately

* fix merge

* Undo file rename

* fix merge

* Misc Cleanup

* remove contraction

* Fix keybinding issue

* fix comment

* merge fix

* fix merge

* fix merge

* fix merge

* fix merge

* fix open-close verbs

* adjust uncuff verb

* fix merge

and undo the renaming of SharedPullableComponent to PullableComponent. I'm tired of all of those merge conflicts

Content.Server/Cabinet/ItemCabinetSystem.cs

@@ -1,12 +1,16 @@
 using Content.Server.Hands.Components;
 using Content.Server.Items;
+using Content.Shared.ActionBlocker;
 using Content.Shared.Audio;
 using Content.Shared.Cabinet;
+using Content.Shared.Hands.Components;
 using Content.Shared.Interaction;
 using Content.Shared.Popups;
+using Content.Shared.Verbs;
 using Robust.Shared.Audio;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
 using Robust.Shared.Localization;
 using Robust.Shared.Player;
 
@@ -14,6 +18,8 @@ namespace Content.Server.Cabinet
 {
     public class ItemCabinetSystem : EntitySystem
     {
+        [Dependency] private readonly ActionBlockerSystem _actionBlockerSystem = default!;
+
         public override void Initialize()
         {
             base.Initialize();
@@ -27,6 +33,70 @@ namespace Content.Server.Cabinet
             SubscribeLocalEvent<ItemCabinetComponent, TryEjectItemCabinetEvent>(OnTryEjectItemCabinet);
             SubscribeLocalEvent<ItemCabinetComponent, TryInsertItemCabinetEvent>(OnTryInsertItemCabinet);
             SubscribeLocalEvent<ItemCabinetComponent, ToggleItemCabinetEvent>(OnToggleItemCabinet);
+
+            SubscribeLocalEvent<ItemCabinetComponent, GetInteractionVerbsEvent>(AddEjectInsertVerbs);
+            SubscribeLocalEvent<ItemCabinetComponent, GetActivationVerbsEvent>(AddToggleOpenVerb);
+        }
+
+        private void AddToggleOpenVerb(EntityUid uid, ItemCabinetComponent component, GetActivationVerbsEvent args)
+        {
+            if (args.Hands == null || !args.CanAccess || !args.CanInteract)
+                return;
+
+            // Toggle open verb
+            Verb toggleVerb = new();
+            toggleVerb.Act = () => OnToggleItemCabinet(uid, component);
+            if (component.Opened)
+            {
+                toggleVerb.Text = Loc.GetString("verb-categories-close");
+                toggleVerb.IconTexture = "/Textures/Interface/VerbIcons/close.svg.192dpi.png";
+            }
+            else
+            {
+                toggleVerb.Text = Loc.GetString("verb-categories-open");
+                toggleVerb.IconTexture = "/Textures/Interface/VerbIcons/open.svg.192dpi.png";
+            }
+            args.Verbs.Add(toggleVerb);
+        }
+
+        private void AddEjectInsertVerbs(EntityUid uid, ItemCabinetComponent component, GetInteractionVerbsEvent args)
+        {
+            if (args.Hands == null || !args.CanAccess || !args.CanInteract)
+                return;
+
+            // "Eject" item verb
+            if (component.Opened &&
+                component.ItemContainer.ContainedEntity != null &&
+                _actionBlockerSystem.CanPickup(args.User))
+            {
+                Verb verb = new();
+                verb.Act = () =>
+                {
+                    TakeItem(component, args.Hands, component.ItemContainer.ContainedEntity, args.User);
+                    UpdateVisuals(component);
+                };
+                verb.Text = Loc.GetString("pick-up-verb-get-data-text");
+                verb.IconTexture = "/Textures/Interface/VerbIcons/pickup.svg.192dpi.png";
+                args.Verbs.Add(verb);
+            }
+
+            // Insert item verb
+            if (component.Opened &&
+                args.Using != null &&
+                _actionBlockerSystem.CanDrop(args.User) &&
+                (component.Whitelist?.IsValid(args.Using) ?? true) &&
+                component.ItemContainer.CanInsert(args.Using))
+            {
+                Verb verb = new();
+                verb.Act = () =>
+                {
+                    args.Hands.TryPutEntityIntoContainer(args.Using, component.ItemContainer);
+                    UpdateVisuals(component);
+                };
+                verb.Category = VerbCategory.Insert;
+                verb.Text = args.Using.Name;
+                args.Verbs.Add(verb);
+            }
         }
 
         private void OnMapInitialize(EntityUid uid, ItemCabinetComponent comp, MapInitEvent args)
@@ -83,7 +153,7 @@ namespace Content.Server.Cabinet
         /// <summary>
         ///     Toggles the ItemCabinet's state.
         /// </summary>
-        private void OnToggleItemCabinet(EntityUid uid, ItemCabinetComponent comp, ToggleItemCabinetEvent args)
+        private void OnToggleItemCabinet(EntityUid uid, ItemCabinetComponent comp, ToggleItemCabinetEvent? args = null)
         {
             comp.Opened = !comp.Opened;
             ClickLatchSound(comp);
@@ -115,17 +185,10 @@ namespace Content.Server.Cabinet
         {
             if (comp.ItemContainer.ContainedEntity == null || args.Cancelled)
                 return;
-            if (args.User.TryGetComponent(out HandsComponent? hands))
+            if (args.User.TryGetComponent(out SharedHandsComponent? hands))
             {
-
-                if (comp.ItemContainer.ContainedEntity.TryGetComponent<ItemComponent>(out var item))
-                {
-                    comp.Owner.PopupMessage(args.User,
-                        Loc.GetString("comp-item-cabinet-successfully-taken",
-                            ("item", comp.ItemContainer.ContainedEntity),
-                            ("cabinet", comp.Owner)));
-                    hands.PutInHandOrDrop(item);
-                }
+                // Put into hands
+                TakeItem(comp, hands, comp.ItemContainer.ContainedEntity, args.User);
             }
             else if (comp.ItemContainer.Remove(comp.ItemContainer.ContainedEntity))
             {
@@ -134,6 +197,24 @@ namespace Content.Server.Cabinet
             UpdateVisuals(comp);
         }
 
+        /// <summary>
+        ///     Tries to eject the ItemCabinet's item, either into the user's hands. Used by both <see
+        ///     cref="OnTryEjectItemCabinet"/> and the eject verbs.
+        /// </summary>
+        private static void TakeItem(ItemCabinetComponent comp, SharedHandsComponent hands, IEntity containedEntity, IEntity user)
+        {
+            if (containedEntity.HasComponent<ItemComponent>())
+            {
+                if (!hands.TryPutInActiveHandOrAny(containedEntity))
+                    containedEntity.Transform.Coordinates = hands.Owner.Transform.Coordinates;
+
+                comp.Owner.PopupMessage(user,
+                    Loc.GetString("comp-item-cabinet-successfully-taken",
+                        ("item", containedEntity),
+                        ("cabinet", comp.Owner)));
+            }
+        }
+
         private static void UpdateVisuals(ItemCabinetComponent comp)
         {
             if (comp.Owner.TryGetComponent(out SharedAppearanceComponent? appearance))