Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Typo, redundant string interpolation, namespaces and imports cleanup (#2068)

Browse Source 
* Readonly, typos and redundant string interpolations

* Namespaces

* Optimize imports

* Address reviews

* but actually

* Localize missing strings

* Remove redundant vars
This commit is contained in:
DrSmugleaf
2020-09-13 14:23:52 +02:00
committed by GitHub
parent 2e5838bb62
commit 74943a2770
213 changed files with 465 additions and 669 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Content.Client/State/GameScreenBase.cs
View File

@@ -181,9 +181,9 @@ namespace Content.Client.State
}
*/
var transx = x.clicked.Transform;
var transy = y.clicked.Transform;
val = transx.Coordinates.Y.CompareTo(transy.Coordinates.Y);
var transX = x.clicked.Transform;
var transY = y.clicked.Transform;
val = transX.Coordinates.Y.CompareTo(transY.Coordinates.Y);
if (val != 0)
{
return val;

6
Content.Client/State/LobbyState.cs
View File

@@ -1,4 +1,6 @@
using Content.Client.Interfaces;
using System;
using System.Linq;
using Content.Client.Interfaces;
using Content.Client.Interfaces.Chat;
using Content.Client.UserInterface;
using Content.Shared.Input;
@@ -16,8 +18,6 @@ using Robust.Shared.Localization;
using Robust.Shared.Prototypes;
using Robust.Shared.Timing;
using Robust.Shared.ViewVariables;
using System;
using System.Linq;
using static Content.Shared.SharedGameTicker;
namespace Content.Client.State

10
Content.Client/State/MainMenu.cs
View File

@@ -36,7 +36,7 @@ namespace Content.Client.State
[Dependency] private readonly IUserInterfaceManager _userInterfaceManager = default!;
private MainMenuControl _mainMenuControl;
private OptionsMenu OptionsMenu;
private OptionsMenu _optionsMenu;
private bool _isConnecting;
// ReSharper disable once InconsistentNaming
@@ -56,7 +56,7 @@ namespace Content.Client.State
_client.RunLevelChanged += RunLevelChanged;
OptionsMenu = new OptionsMenu();
_optionsMenu = new OptionsMenu();
}
/// <inheritdoc />
@@ -66,7 +66,7 @@ namespace Content.Client.State
_netManager.ConnectFailed -= _onConnectFailed;
_mainMenuControl.Dispose();
OptionsMenu.Dispose();
_optionsMenu.Dispose();
}
private void QuitButtonPressed(BaseButton.ButtonEventArgs args)
@@ -76,7 +76,7 @@ namespace Content.Client.State
private void OptionsButtonPressed(BaseButton.ButtonEventArgs args)
{
OptionsMenu.OpenCentered();
_optionsMenu.OpenCentered();
}
private void DirectConnectButtonPressed(BaseButton.ButtonEventArgs args)
@@ -315,7 +315,7 @@ namespace Content.Client.State
VersionLabel = new Label
{
Text = $"v0.1"
Text = "v0.1"
};
LayoutContainer.SetAnchorPreset(VersionLabel, LayoutContainer.LayoutPreset.BottomRight);