Localize jobs (#8968)

* Localize job supervisors

* Rename supervisors file

* Localize job names

* Remove localization for fallback job name

* Use LocalizedName for Job

* Fix job names case

Resources/Locale/en-US/job/job-names.ftl

@@ -0,0 +1,39 @@
+job-name-warden = warden
+job-name-security = security officer
+job-name-cadet = security cadet
+job-name-hos = head of security
+job-name-scientist = scientist
+job-name-rd = research director
+job-name-psychologist = psychologist
+job-name-intern = medical intern
+job-name-doctor = medical doctor
+job-name-cmo = chief medical officer
+job-name-chemist = chemist
+job-name-assistant = technical assistant
+job-name-engineer = station engineer
+job-name-atmostech = atmospheric technician
+job-name-hop = head of personnel
+job-name-captain = captain
+job-name-serviceworker = service worker
+job-name-centcomoff = centcom official
+job-name-reporter = reporter
+job-name-musician = musician
+job-name-librarian = librarian
+job-name-lawyer = lawyer
+job-name-mime = mime
+job-name-ce = chief engineer
+job-name-janitor = janitor
+job-name-chaplain = chaplain
+job-name-botanist = botanist
+job-name-bartender = bartender
+job-name-passenger = passenger
+job-name-salvagespec = salvage specialist
+job-name-qm = quartermaster
+job-name-cargoteh = cargo technician
+job-name-chef = chef
+job-name-clown = clown
+job-name-ertleader = ERT leader
+job-name-ertengineer = ERT engineer
+job-name-ertsecurity = ERT security
+job-name-ertmedic = ERT medic
+job-name-ertjanitor = ERT janitor

Resources/Locale/en-US/job/job-supervisors.ftl

@@ -0,0 +1,14 @@
+job-supervisors-centcom = centcom official
+job-supervisors-captain = the captain
+job-supervisors-hop = the head of personnel
+job-supervisors-hop-qm = the quartermaster and head of personnel
+job-supervisors-hos = the head of security
+job-supervisors-ce = the chief engineer
+job-supervisors-cmo = the chief medical officer
+job-supervisors-rd = the research director
+job-supervisors-service = chefs, botanists, the bartender, and the head of personnel
+job-supervisors-engineering = station engineers, atmospheric technicians, and the chief engineer
+job-supervisors-medicine = medical doctors, chemists, and the chief medical officer
+job-supervisors-security = security officers, the warden, and the head of security
+job-supervisors-hire = whoever hires you
+job-supervisors-everyone = absolutely everyone

Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml

@@ -1,11 +1,11 @@
 - type: job
   id: CargoTechnician
-  name: "cargo technician"
+  name: job-name-cargoteh
   startingGear: CargoTechGear
   departments:
   - Cargo
   icon: "CargoTechnician"
-  supervisors: "the quartermaster and head of personnel"
+  supervisors: job-supervisors-hop-qm
   access:
   - Cargo
   - Maintenance

Resources/Prototypes/Roles/Jobs/Cargo/quartermaster.yml

@@ -1,12 +1,12 @@
 - type: job
   id: Quartermaster
-  name: "quartermaster"
+  name: job-name-qm
   weight: 10
   startingGear: QuartermasterGear
   departments:
   - Cargo
   icon: "QuarterMaster"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   canBeAntag: false
   access:
   - Cargo

Resources/Prototypes/Roles/Jobs/Cargo/salvage_specialist.yml

@@ -1,11 +1,11 @@
 - type: job
   id: SalvageSpecialist
-  name: "salvage specialist"
+  name: job-name-salvagespec
   icon: "ShaftMiner"
   startingGear: SalvageSpecialistGear
   departments:
   - Cargo
-  supervisors: "the quartermaster and head of personnel"
+  supervisors: job-supervisors-hop-qm
   access:
   - Cargo
   - Salvage

Resources/Prototypes/Roles/Jobs/Civilian/assistant.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Passenger
-  name: "passenger"
+  name: job-name-passenger
   startingGear: PassengerGear
   departments:
   - Civilian
   icon: "Passenger"
-  supervisors: "absolutely everyone"
+  supervisors: job-supervisors-everyone
   access:
   - Maintenance
 

Resources/Prototypes/Roles/Jobs/Civilian/bartender.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Bartender
-  name: "bartender"
+  name: job-name-bartender
   startingGear: BartenderGear
   departments:
   - Civilian
   icon: "Bartender"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/botanist.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Botanist
-  name: "botanist"
+  name: job-name-botanist
   startingGear: BotanistGear
   departments:
   - Civilian
   icon: "Botanist"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/chaplain.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Chaplain
-  name: "chaplain"
+  name: job-name-chaplain
   startingGear: ChaplainGear
   departments:
   - Civilian
   icon: "Chaplain"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Chapel
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/chef.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Chef
-  name: "chef"
+  name: job-name-chef
   startingGear: ChefGear
   departments:
   - Civilian
   icon: "Chef"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/clown.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Clown
-  name: "clown"
+  name: job-name-clown
   startingGear: ClownGear
   departments:
   - Civilian
   icon: "Clown"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Theatre
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/janitor.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Janitor
-  name: "janitor"
+  name: job-name-janitor
   startingGear: JanitorGear
   departments:
   - Civilian
   icon: "Janitor"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Janitor
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/lawyer.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Lawyer
-  name: "lawyer"
+  name: job-name-lawyer
   startingGear: LawyerGear
   departments:
   - Civilian
   icon: "Lawyer"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Brig

Resources/Prototypes/Roles/Jobs/Civilian/librarian.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Librarian
-  name: "librarian"
+  name: job-name-librarian
   startingGear: LibrarianGear
   departments:
   - Civilian
   icon: "Librarian"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/mime.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Mime
-  name: "mime"
+  name: job-name-mime
   startingGear: MimeGear
   departments:
   - Civilian
   icon: "Mime"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Theatre
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/musician.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Musician
-  name: "musician"
+  name: job-name-musician
   startingGear: MusicianGear
   departments:
   - Civilian
   icon: "Musician"
-  supervisors: "whoever hires you"
+  supervisors: job-supervisors-hire
   access:
   - Maintenance # TODO Remove maint access for all gimmick jobs once access work is completed
   - Theatre

Resources/Prototypes/Roles/Jobs/Civilian/reporter.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Reporter
-  name: "reporter"
+  name: job-name-reporter
   startingGear: ReporterGear
   departments:
   - Civilian
   icon: "Reporter"
-  supervisors: "the head of personnel"
+  supervisors: job-supervisors-hop
   access:
   - Service
   - Maintenance

Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml

@@ -1,11 +1,11 @@
 - type: job
   id: ServiceWorker
-  name: "service worker"
+  name: job-name-serviceworker
   startingGear: ServiceWorkerGear
   departments:
   - Civilian
   icon: "ServiceWorker"
-  supervisors: "chefs, botanists, the bartender, and the head of personnel"
+  supervisors: job-supervisors-service
   canBeAntag: false
   access:
   - Service

Resources/Prototypes/Roles/Jobs/Command/captain.yml

@@ -1,6 +1,6 @@
 - type: job
   id: Captain
-  name: "captain"
+  name: job-name-captain
   weight: 20
   startingGear: CaptainGear
   departments:
@@ -8,7 +8,7 @@
   icon: "Captain"
   requireAdminNotify: true
   joinNotifyCrew: true
-  supervisors: "Nanotrasen officials"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess

Resources/Prototypes/Roles/Jobs/Command/centcom_official.yml

@@ -1,12 +1,12 @@
 - type: job
   id: CentralCommandOfficial
-  name: "centcom official"
+  name: job-name-centcomoff
   setPreference: false
   startingGear: CentcomGear
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "the head of security"
+  supervisors: job-supervisors-hos
   canBeAntag: false
   accessGroups:
   - AllAccess

Resources/Prototypes/Roles/Jobs/Command/head_of_personnel.yml

@@ -1,6 +1,6 @@
 - type: job
   id: HeadOfPersonnel
-  name: "head of personnel"
+  name: job-name-hop
   weight: 20
   startingGear: HoPGear
   departments:
@@ -8,7 +8,7 @@
   - Civilian
   icon: "HeadOfPersonnel"
   requireAdminNotify: true
-  supervisors: "the captain"
+  supervisors: job-supervisors-captain
   canBeAntag: false
   access:
   - Command

Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml

@@ -1,12 +1,12 @@
 - type: job
   id: AtmosphericTechnician
-  name: "atmospheric technician"
+  name: job-name-atmostech
   startingGear: AtmosphericTechnicianGear
   departments:
   - Engineering
   icon: "AtmosphericTechnician"
-  supervisors: "the chief engineer"
-  canBeAntag: false 
+  supervisors: job-supervisors-ce
+  canBeAntag: false
   access:
   - Maintenance
   - Engineering
@@ -16,11 +16,11 @@
 - type: startingGear
   id: AtmosphericTechnicianGear
   equipment:
-    head: 
+    head:
     jumpsuit: ClothingUniformJumpsuitAtmos
     back: ClothingBackpackEngineeringFilled
     shoes: ClothingShoesColorWhite
-    outerClothing: 
+    outerClothing:
     id: AtmosPDA
     belt: ClothingBeltUtilityFilled
     ears: ClothingHeadsetEngineering

Resources/Prototypes/Roles/Jobs/Engineering/chief_engineer.yml

@@ -1,6 +1,6 @@
 - type: job
   id: ChiefEngineer
-  name: "chief engineer"
+  name: job-name-ce
   weight: 10
   startingGear: ChiefEngineerGear
   departments:
@@ -8,7 +8,7 @@
   - Engineering
   icon: "ChiefEngineer"
   requireAdminNotify: true
-  supervisors: "the captain"
+  supervisors: job-supervisors-captain
   canBeAntag: false
   access:
   - Maintenance

Resources/Prototypes/Roles/Jobs/Engineering/station_engineer.yml

@@ -1,11 +1,11 @@
 - type: job
   id: StationEngineer
-  name: "station engineer"
+  name: job-name-engineer
   startingGear: StationEngineerGear
   departments:
   - Engineering
   icon: "StationEngineer"
-  supervisors: "the chief engineer"
+  supervisors: job-supervisors-ce
   access:
   - Maintenance
   - Engineering

Resources/Prototypes/Roles/Jobs/Engineering/technical_assistant.yml

@@ -1,12 +1,12 @@
 - type: job
   id: TechnicalAssistant
-  name: "technical assistant"
+  name: job-name-assistant
   startingGear: TechnicalAssistantGear
   departments:
   - Civilian
   - Engineering
   icon: "TechnicalAssistant"
-  supervisors: "station engineers, atmospheric technicians, and the chief engineer"
+  supervisors: job-supervisors-engineering
   canBeAntag: false
   access:
   - Maintenance

Resources/Prototypes/Roles/Jobs/Fun/emergencyresponseteam.yml

@@ -1,13 +1,13 @@
 # Leader
 - type: job
   id: ERTLeader
-  name: "ERT leader"
+  name: job-name-ertleader
   setPreference: false
   startingGear: ERTLeaderGearEVA
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "centcom official"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess
@@ -48,17 +48,17 @@
 # Engineer
 - type: job
   id: ERTEngineer
-  name: "ERT engineer"
+  name: job-name-ertengineer
   setPreference: false
   startingGear: ERTEngineerGearEVA
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "centcom official"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess
-  
+
 - type: startingGear
   id: ERTEngineerGear
   equipment:
@@ -90,21 +90,21 @@
     ears: ClothingHeadsetAltCommand
     belt: ClothingBeltChiefEngineerFilled
     pocket1: Flare
-    
+
 # Security
 - type: job
   id: ERTSecurity
-  name: "ERT security"
+  name: job-name-ertsecurity
   setPreference: false
   startingGear: ERTEngineerGearEVA
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "centcom official"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess
-  
+
 - type: startingGear
   id: ERTSecurityGear
   equipment:
@@ -136,21 +136,21 @@
     ears: ClothingHeadsetAltCommand
     belt: ClothingBeltSecurityWebbing
     pocket1: Flare
-    
+
 # Medical
 - type: job
   id: ERTMedical
-  name: "ERT medic"
+  name: job-name-ertmedic
   setPreference: false
   startingGear: ERTMedicalGearEVA
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "centcom official"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess
-  
+
 - type: startingGear
   id: ERTMedicalGear
   equipment:
@@ -183,21 +183,21 @@
     belt: ClothingBeltMedicalFilled
     pocket1: HandheldHealthAnalyzer
     pocket2: Flare
-    
+
 # Janitor
 - type: job
   id: ERTJanitor
-  name: "ERT janitor"
+  name: job-name-ertjanitor
   setPreference: false
   startingGear: ERTJanitorGearEVA
   departments:
   - Command
   icon: "Nanotrasen"
-  supervisors: "centcom official"
+  supervisors: job-supervisors-centcom
   canBeAntag: false
   accessGroups:
   - AllAccess
-  
+
 - type: startingGear
   id: ERTJanitorGear
   equipment:

Resources/Prototypes/Roles/Jobs/Medical/chemist.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Chemist
-  name: "chemist"
+  name: job-name-chemist
   startingGear: ChemistGear
   departments:
   - Medical
   icon: "Chemist"
-  supervisors: "the chief medical officer"
+  supervisors: job-supervisors-cmo
   access:
   - Medical
   - Chemistry

Resources/Prototypes/Roles/Jobs/Medical/chief_medical_officer.yml

@@ -2,7 +2,7 @@
 
 - type: job
   id: ChiefMedicalOfficer
-  name: "chief medical officer"
+  name: job-name-cmo
   weight: 10
   startingGear: CMOGear
   departments:
@@ -10,7 +10,7 @@
   - Medical
   icon: "ChiefMedicalOfficer"
   requireAdminNotify: true
-  supervisors: "the captain"
+  supervisors: job-supervisors-captain
   canBeAntag: false
   access:
   - Medical

Resources/Prototypes/Roles/Jobs/Medical/medical_doctor.yml

@@ -1,11 +1,11 @@
 - type: job
   id: MedicalDoctor
-  name: "medical doctor"
+  name: job-name-doctor
   startingGear: DoctorGear
   departments:
   - Medical
   icon: "MedicalDoctor"
-  supervisors: "the chief medical officer"
+  supervisors: job-supervisors-cmo
   access:
   - Medical
   - Maintenance

Resources/Prototypes/Roles/Jobs/Medical/medical_intern.yml

@@ -1,12 +1,12 @@
 - type: job
   id: MedicalIntern
-  name: "medical intern"
+  name: job-name-intern
   startingGear: MedicalInternGear
   departments:
   - Civilian
   - Medical
   icon: "MedicalIntern"
-  supervisors: "medical doctors, chemists, and the chief medical officer"
+  supervisors: job-supervisors-medicine
   canBeAntag: false
   access:
   - Medical

Resources/Prototypes/Roles/Jobs/Medical/psychologist.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Psychologist
-  name: "psychologist"
+  name: job-name-psychologist
   startingGear: PsychologistGear
   departments:
   - Medical
   icon: "Psychologist"
-  supervisors: "the chief medical officer"
+  supervisors: job-supervisors-cmo
   access:
   - Medical
   - Maintenance
@@ -22,4 +22,4 @@
     ears: ClothingHeadsetMedical
   innerclothingskirt: ClothingUniformJumpsuitPsychologist
   satchel: ClothingBackpackSatchelMedicalFilled
-  duffelbag: ClothingBackpackDuffelMedicalFilled
+  duffelbag: ClothingBackpackDuffelMedicalFilled

Resources/Prototypes/Roles/Jobs/Science/research_director.yml

@@ -1,6 +1,6 @@
 - type: job
   id: ResearchDirector
-  name: "research director"
+  name: job-name-rd
   weight: 10
   startingGear: ResearchDirectorGear
   departments:
@@ -8,7 +8,7 @@
   - Science
   icon: "ResearchDirector"
   requireAdminNotify: true
-  supervisors: "the captain"
+  supervisors: job-supervisors-captain
   canBeAntag: false
   access:
   - Research

Resources/Prototypes/Roles/Jobs/Science/scientist.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Scientist
-  name: "scientist"
+  name: job-name-scientist
   startingGear: ScientistGear
   departments:
   - Science
   icon: "Scientist"
-  supervisors: "the research director"
+  supervisors: job-supervisors-rd
   access:
   - Research
   - Maintenance

Resources/Prototypes/Roles/Jobs/Security/head_of_security.yml

@@ -1,6 +1,6 @@
 - type: job
   id: HeadOfSecurity
-  name: "head of security"
+  name: job-name-hos
   weight: 10
   startingGear: HoSGear
   departments:
@@ -8,7 +8,7 @@
   - Security
   icon: "HeadOfSecurity"
   requireAdminNotify: true
-  supervisors: "the captain"
+  supervisors: job-supervisors-captain
   canBeAntag: false
   access:
   - HeadOfSecurity

Resources/Prototypes/Roles/Jobs/Security/security_cadet.yml

@@ -1,12 +1,12 @@
 - type: job
   id: SecurityCadet
-  name: "security cadet"
+  name: job-name-cadet
   startingGear: SecurityCadetGear
   departments:
   - Civilian
   - Security
   icon: "SecurityCadet"
-  supervisors: "security officers, the warden, and the head of security"
+  supervisors: job-supervisors-security
   canBeAntag: false
   access:
   - Security

Resources/Prototypes/Roles/Jobs/Security/security_officer.yml

@@ -1,11 +1,11 @@
 - type: job
   id: SecurityOfficer
-  name: "security officer"
+  name: job-name-security
   startingGear: SecurityOfficerGear
   departments:
   - Security
   icon: "SecurityOfficer"
-  supervisors: "the head of security"
+  supervisors: job-supervisors-hos
   canBeAntag: false
   access:
   - Security

Resources/Prototypes/Roles/Jobs/Security/warden.yml

@@ -1,11 +1,11 @@
 - type: job
   id: Warden
-  name: "warden"
+  name: job-name-warden
   startingGear: WardenGear
   departments:
   - Security
   icon: "Warden"
-  supervisors: "the head of security"
+  supervisors: job-supervisors-hos
   canBeAntag: false
   access:
   - Security