Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

SolutionContainer refactors (#2954)

Browse Source 
* removes unused method

* Code uncluttering (Also removed the netcode, color code, and visuals, need to rewrite)

* SolutionContainerVisualState

* Removes caching of SolutionContainer Color

* ChemicalsAdded() and ChemicalsRemoved() for updating appearance and handling reaction checks

* SolutionContainerComponentState

* Netcode

* ChemMasterComponent no longer creates a SolutionContainerComponent with new(), uses a Solution instead

* Enable nullable in SolutionContainer implementations

* Some review fixes

* uses IReadOnlyLists in ChemMaster

* Comments

* review fixes 3

* ReagentUnit documentation

* Review fixes

* spelling fix

* spelling 2

* typo

Co-authored-by: py01 <pyronetics01@gmail.com>
This commit is contained in:
py01
2021-01-10 02:41:55 -06:00
committed by GitHub
parent 0b7f286cf3
commit 7bf80fd4b8
14 changed files with 260 additions and 362 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Content.Shared/GameObjects/EntitySystems/ChemicalReactionSystem.cs
View File

@@ -8,6 +8,7 @@ using System.Collections.Generic;
namespace Content.Shared.GameObjects.EntitySystems
{
//TODO: Reimplement sounds for reactions
public class ChemicalReactionSystem : EntitySystem
{
private IEnumerable<ReactionPrototype> _reactions;