Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Remove redundant read-only VV from datafields (#12626)

Browse Source
This commit is contained in:
DrSmugleaf
2022-11-16 20:22:11 +01:00
committed by GitHub
parent fb892cb374
commit 7fbc2608e8
179 changed files with 171 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Content.Server/Holiday/HolidayPrototype.cs
View File

@@ -9,41 +9,37 @@ namespace Content.Server.Holiday
[Prototype("holiday")]
public sealed class HolidayPrototype : IPrototype
{
[ViewVariables] [DataField("name")] public string Name { get; private set; } = string.Empty;
[DataField("name")] public string Name { get; private set; } = string.Empty;
[ViewVariables]
[IdDataFieldAttribute]
public string ID { get; } = default!;
[ViewVariables]
[DataField("beginDay")]
public byte BeginDay { get; set; } = 1;
[ViewVariables]
[DataField("beginMonth")]
public Month BeginMonth { get; set; } = Month.Invalid;
/// <summary>
/// Day this holiday will end. Zero means it lasts a single day.
/// </summary>
[ViewVariables]
[DataField("endDay")]
public byte EndDay { get; set; }
/// <summary>
/// Month this holiday will end in. Invalid means it lasts a single month.
/// </summary>
[ViewVariables]
[DataField("endMonth")]
public Month EndMonth { get; set; } = Month.Invalid;
[ViewVariables] [DataField("shouldCelebrate")]
[DataField("shouldCelebrate")]
private readonly IHolidayShouldCelebrate _shouldCelebrate = new DefaultHolidayShouldCelebrate();
[ViewVariables] [DataField("greet")]
[DataField("greet")]
private readonly IHolidayGreet _greet = new DefaultHolidayGreet();
[ViewVariables] [DataField("celebrate")]
[DataField("celebrate")]
private readonly IHolidayCelebrate _celebrate = new DefaultHolidayCelebrate();
public bool ShouldCelebrate(DateTime date)