Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Remove redundant read-only VV from datafields (#12626)

Browse Source
This commit is contained in:
DrSmugleaf
2022-11-16 20:22:11 +01:00
committed by GitHub
parent fb892cb374
commit 7fbc2608e8
179 changed files with 171 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Server/Objectives/Conditions/StealCondition.cs
View File

@@ -1,4 +1,3 @@
using Content.Server.Containers;
using Content.Server.Objectives.Interfaces;
using JetBrains.Annotations;
using Robust.Shared.Containers;
@@ -20,7 +19,6 @@ namespace Content.Server.Objectives.Conditions
/// Help newer players by saying e.g. "steal the chief engineer's advanced magboots"
/// instead of "steal advanced magboots. Should be a loc string.
/// </summary>
[ViewVariables]
[DataField("owner")] private string? _owner = null;
public IObjectiveCondition GetAssigned(Mind.Mind mind)

5
Content.Server/Objectives/ObjectivePrototype.cs
View File

@@ -11,9 +11,9 @@ namespace Content.Server.Objectives
[IdDataFieldAttribute]
public string ID { get; } = default!;
[ViewVariables] [DataField("issuer")] public string Issuer { get; private set; } = "Unknown";
[DataField("issuer")] public string Issuer { get; private set; } = "Unknown";
[ViewVariables] [DataField("prob")] public float Probability { get; private set; } = 0.3f;
[DataField("prob")] public float Probability { get; private set; } = 0.3f;
[ViewVariables]
public float Difficulty => _difficultyOverride ?? _conditions.Sum(c => c.Difficulty);
@@ -26,7 +26,6 @@ namespace Content.Server.Objectives
[ViewVariables]
public IReadOnlyList<IObjectiveCondition> Conditions => _conditions;
[ViewVariables]
[DataField("canBeDuplicate")]
public bool CanBeDuplicateAssignment { get; private set; }