Detectives gain independency (#23114)

* add

* fix

* civilian-ise

* update headset name

* aspid det door

* add

Resources/Locale/en-US/job/job-description.ftl

@@ -16,7 +16,7 @@ job-description-chemist = Produce medicinal drugs for the doctors to use, resear
 job-description-clown = Entertain the crew through elaborate slapstick routines or terrible jokes.
 job-description-cmo = Manage the resources and personnel of the medical department to keep the crew alive.
 job-description-paramedic = Rescue critically injured patients all over the station, sometimes outside too. Stablize them, give them a ride to medbay, and get back out there!
-job-description-detective = Investigate crime scenes using forensic tools, ensure that the guilty party is found, and have a couple smokes.
+job-description-detective = Answer requests for help, investigate crime scenes using forensic tools, and have a couple smokes.
 job-description-doctor = Diagnose and heal crewmembers through medicinal chemicals, advanced medicine, and defibrillators. Make sure the dead don't rot, and that cadavers are in the morgue.
 job-description-engineer = Keep the station's main engine & solars active, optimize the power network, and make emergency repairs using your hardsuit in spaced areas.
 job-description-ertengineer = Ensure that the station has power and clean air.

Resources/Maps/aspid.yml

@@ -10715,6 +10715,13 @@ entities:
       rot: 1.5707963267948966 rad
       pos: -0.5,1.5
       parent: 8756
+- proto: AirlockDetectiveGlassLocked
+  entities:
+  - uid: 3192
+    components:
+    - type: Transform
+      pos: 39.5,48.5
+      parent: 1
 - proto: AirlockEngineeringGlassLocked
   entities:
   - uid: 9075
@@ -12484,11 +12491,6 @@ entities:
       parent: 1
 - proto: AirlockSecurityGlassLocked
   entities:
-  - uid: 3192
-    components:
-    - type: Transform
-      pos: 39.5,48.5
-      parent: 1
   - uid: 8211
     components:
     - type: Transform

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml

@@ -31,13 +31,12 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpackSecurity
+  parent: ClothingBackpack
-  id: ClothingBackpackSecurityFilledDetective
+  id: ClothingBackpackFilledDetective
   components:
   - type: StorageFill
     contents:
       - id: BoxSurvivalSecurity
-      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml

@@ -30,13 +30,12 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpackDuffelSecurity
+  parent: ClothingBackpackDuffel
-  id: ClothingBackpackDuffelSecurityFilledDetective
+  id: ClothingBackpackDuffelFilledDetective
   components:
   - type: StorageFill
     contents:
       - id: BoxSurvivalSecurity
-      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml

@@ -44,13 +44,12 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpackSatchelSecurity
+  parent: ClothingBackpackSatchel
-  id: ClothingBackpackSatchelSecurityFilledDetective
+  id: ClothingBackpackSatchelFilledDetective
   components:
   - type: StorageFill
     contents:
       - id: BoxSurvivalSecurity
-      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Roles/Jobs/Civilian/detective.yml

@@ -1,38 +1,39 @@
-- type: job
+- type: job
-  id: Detective
+  id: Detective
-  name: job-name-detective
+  name: job-name-detective
-  description: job-description-detective
+  description: job-description-detective
-  playTimeTracker: JobDetective
+  playTimeTracker: JobDetective
-  requirements:
+  requirements:
-  - !type:DepartmentTimeRequirement
+  - !type:DepartmentTimeRequirement
-    department: Security
+    department: Security
-    time: 54000 # 15 hours
+    time: 36000 # 10 hours
-  startingGear: DetectiveGear
+  - !type:DepartmentTimeRequirement
-  icon: "JobIconDetective"
+    department: Civilian
-  supervisors: job-supervisors-hos
+    time: 18000 # 5 hours
-  canBeAntag: false
+  startingGear: DetectiveGear
-  access:
+  icon: "JobIconDetective"
-  - Security
+  supervisors: job-supervisors-hop
-  - Brig
+  canBeAntag: true
-  - Maintenance
+  access:
-  - Service
+  - Brig
-  - Detective
+  - Maintenance
-  special:
+  - Service
-  - !type:AddImplantSpecial
+  - Detective
-    implants: [ MindShieldImplant ]
+  extendedAccess:
-
+  - Security
-- type: startingGear
+
-  id: DetectiveGear
+- type: startingGear
-  equipment:
+  id: DetectiveGear
-    jumpsuit: ClothingUniformJumpsuitDetective
+  equipment:
-    back: ClothingBackpackSecurityFilledDetective
+    jumpsuit: ClothingUniformJumpsuitDetective
-    shoes: ClothingShoesBootsCombatFilled
+    back: ClothingBackpackFilledDetective
-    eyes: ClothingEyesGlassesSunglasses
+    shoes: ClothingShoesBootsCombatFilled
-    head: ClothingHeadHatFedoraBrown
+    eyes: ClothingEyesGlassesSunglasses
-    outerClothing: ClothingOuterVestDetective
+    head: ClothingHeadHatFedoraBrown
-    id: DetectivePDA
+    outerClothing: ClothingOuterVestDetective
-    ears: ClothingHeadsetSecurity
+    id: DetectivePDA
-    belt: ClothingBeltHolsterFilled
+    ears: ClothingHeadsetSecurity
-  innerClothingSkirt: ClothingUniformJumpskirtDetective
+    belt: ClothingBeltHolsterFilled
-  satchel: ClothingBackpackSatchelSecurityFilledDetective
+  innerClothingSkirt: ClothingUniformJumpskirtDetective
-  duffelbag: ClothingBackpackDuffelSecurityFilledDetective
+  satchel: ClothingBackpackSatchelFilledDetective
+  duffelbag: ClothingBackpackDuffelFilledDetective

Resources/migration.yml

@@ -165,3 +165,8 @@ ClothingHeadHelmetVoidParamed: null
 
 # 2024-01-19
 DefaultStationBeaconTeslaEngine: null
+
+#2024-01-27
+ClothingBackpackSecurityFilledDetective: ClothingBackpackFilledDetective
+ClothingBackpackDuffelSecurityFilledDetective: ClothingBackpackDuffelFilledDetective
+ClothingBackpackSatchelSecurityFilledDetective: ClothingBackpackSatchelFilledDetective