Generic power switch component (#11999)

Content.Server/Disposal/Unit/EntitySystems/DisposalUnitSystem.cs

@@ -8,6 +8,7 @@ using Content.Server.DoAfter;
 using Content.Server.Hands.Components;
 using Content.Server.Popups;
 using Content.Server.Power.Components;
+using Content.Server.Power.EntitySystems;
 using Content.Shared.ActionBlocker;
 using Content.Shared.Atmos;
 using Content.Shared.Construction.Components;
@@ -25,13 +26,11 @@ using Content.Shared.Popups;
 using Content.Shared.Throwing;
 using Content.Shared.Verbs;
 using Robust.Server.GameObjects;
-using Robust.Shared.Audio;
 using Robust.Shared.Containers;
-using Robust.Shared.Map;
-using Robust.Shared.Map.Components;
 using Robust.Shared.Physics.Components;
 using Robust.Shared.Player;
 using Robust.Shared.Random;
+using Robust.Shared.Map.Components;
 
 namespace Content.Server.Disposal.Unit.EntitySystems
 {
@@ -50,6 +49,7 @@ namespace Content.Server.Disposal.Unit.EntitySystems
         [Dependency] private readonly SharedHandsSystem _handsSystem = default!;
         [Dependency] private readonly TransformSystem _transformSystem = default!;
         [Dependency] private readonly UserInterfaceSystem _ui = default!;
+        [Dependency] private readonly PowerReceiverSystem _power = default!;
 
         public override void Initialize()
         {
@@ -223,13 +223,7 @@ namespace Content.Server.Disposal.Unit.EntitySystems
                     _adminLogger.Add(LogType.Action, LogImpact.Low, $"{ToPrettyString(player):player} hit flush button on {ToPrettyString(uid)}, it's now {(component.Engaged ? "on" : "off")}");
                     break;
                 case SharedDisposalUnitComponent.UiButton.Power:
-                    TogglePower(component);
-                    _audio.PlayPvs(new SoundPathSpecifier("/Audio/Machines/machine_switch.ogg"), component.Owner,
-                        AudioParams.Default.WithVolume(-2f));
-                    if (EntityManager.TryGetComponent(component.Owner, out ApcPowerReceiverComponent? receiver))
-                    {
-                        _adminLogger.Add(LogType.Action, LogImpact.Low, $"{ToPrettyString(player):player} hit power button on {ToPrettyString(uid)}, it's now {(!receiver.PowerDisabled ? "on" : "off")}");
-                    }
+                    _power.TogglePower(uid, user: args.Session.AttachedEntity);
                     break;
                 default:
                     throw new ArgumentOutOfRangeException();
@@ -249,17 +243,6 @@ namespace Content.Server.Disposal.Unit.EntitySystems
                 Disengage(component);
             }
         }
-
-        public void TogglePower(DisposalUnitComponent component)
-        {
-            if (!EntityManager.TryGetComponent(component.Owner, out ApcPowerReceiverComponent? receiver))
-            {
-                return;
-            }
-
-            receiver.PowerDisabled = !receiver.PowerDisabled;
-            UpdateInterface(component, receiver.Powered);
-        }
         #endregion
 
         #region Eventbus Handlers

Content.Server/Power/Components/PowerSwitchComponent.cs

@@ -0,0 +1,9 @@
+namespace Content.Server.Power.Components
+{
+    /// <summary>
+    /// Provides an alt verb to toggle power.
+    /// </summary>
+    [RegisterComponent]
+    public sealed class PowerSwitchComponent : Component
+    {}
+}

Content.Server/Power/EntitySystems/PowerReceiverSystem.cs

@@ -1,14 +1,20 @@
 using Content.Server.Power.Components;
+using Content.Server.Hands.Components;
+using Content.Server.Administration.Logs;
 using Content.Shared.Examine;
 using Content.Shared.Power;
+using Content.Shared.Verbs;
+using Content.Shared.Database;
 using Robust.Server.GameObjects;
+using Robust.Shared.Audio;
 
 namespace Content.Server.Power.EntitySystems
 {
     public sealed class PowerReceiverSystem : EntitySystem
     {
+        [Dependency] private readonly IAdminLogManager _adminLogger = default!;
         [Dependency] private readonly AppearanceSystem _appearance = default!;
-
+        [Dependency] private readonly AudioSystem _audio = default!;
         public override void Initialize()
         {
             base.Initialize();
@@ -20,6 +26,8 @@ namespace Content.Server.Power.EntitySystems
             SubscribeLocalEvent<ApcPowerProviderComponent, ComponentShutdown>(OnProviderShutdown);
             SubscribeLocalEvent<ApcPowerProviderComponent, ExtensionCableSystem.ReceiverConnectedEvent>(OnReceiverConnected);
             SubscribeLocalEvent<ApcPowerProviderComponent, ExtensionCableSystem.ReceiverDisconnectedEvent>(OnReceiverDisconnected);
+
+            SubscribeLocalEvent<PowerSwitchComponent, GetVerbsEvent<AlternativeVerb>>(AddSwitchPowerVerb);
         }
 
         ///<summary>
@@ -78,6 +86,33 @@ namespace Content.Server.Power.EntitySystems
             }
         }
 
+        private void AddSwitchPowerVerb(EntityUid uid, PowerSwitchComponent component, GetVerbsEvent<AlternativeVerb> args)
+        {
+            if(!args.CanAccess || !args.CanInteract)
+                return;
+
+            if (!HasComp<HandsComponent>(args.User))
+                return;
+
+            if (!TryComp<ApcPowerReceiverComponent>(uid, out var receiver))
+                return;
+
+            if (!receiver.NeedsPower)
+                return;
+
+            AlternativeVerb verb = new()
+            {
+                Act = () =>
+                {
+                    TogglePower(uid, user: args.User);
+                },
+                IconTexture = "/Textures/Interface/VerbIcons/Spare/poweronoff.svg.192dpi.png",
+                Text = Loc.GetString("power-switch-component-toggle-verb"),
+                Priority = -3
+            };
+            args.Verbs.Add(verb);
+        }
+
         private void ProviderChanged(ApcPowerReceiverComponent receiver)
         {
             receiver.NetworkLoad.LinkedNetwork = default;
@@ -99,5 +134,35 @@ namespace Content.Server.Power.EntitySystems
 
             return receiver.Powered;
         }
+
+        /// <summary>
+        /// Turn this machine on or off.
+        /// Returns true if we turned it on, false if we turned it off.
+        /// </summary>
+        public bool TogglePower(EntityUid uid, bool playSwitchSound = true, ApcPowerReceiverComponent? receiver = null, EntityUid? user = null)
+        {
+            if (!Resolve(uid, ref receiver, false))
+                return true;
+
+            // it'll save a lot of confusion if 'always powered' means 'always powered'
+            if (!receiver.NeedsPower)
+            {
+                receiver.PowerDisabled = false;
+                return true;
+            }
+
+            receiver.PowerDisabled = !receiver.PowerDisabled;
+
+            if (user != null)
+                _adminLogger.Add(LogType.Action, LogImpact.Low, $"{ToPrettyString(user.Value):player} hit power button on {ToPrettyString(uid)}, it's now {(!receiver.PowerDisabled ? "on" : "off")}");
+
+            if (playSwitchSound)
+            {
+                _audio.PlayPvs(new SoundPathSpecifier("/Audio/Machines/machine_switch.ogg"), uid,
+                    AudioParams.Default.WithVolume(-2f));
+            }
+
+            return !receiver.PowerDisabled; // i.e. PowerEnabled
+        }
     }
 }