Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove some obsoleted transform methods/properties (#13457)

Browse Source
This commit is contained in:
Leon Friedrich
2023-01-14 13:48:48 +13:00
committed by GitHub
parent a98a80f938
commit 899549b770
5 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.IntegrationTests/Tests/Disposal/DisposalUnitTest.cs
View File

@@ -32,7 +32,7 @@ namespace Content.IntegrationTests.Tests.Disposal
var insertTransform = EntityManager.GetComponent<TransformComponent>(toInsert);
var unitTransform = EntityManager.GetComponent<TransformComponent>(unit);
// Not in a tube yet
Assert.That(insertTransform.Parent, Is.EqualTo(unitTransform));
Assert.That(insertTransform.ParentUid, Is.EqualTo(unit));
}, after: new[] {typeof(SharedDisposalUnitSystem)});
}
}

9
Content.IntegrationTests/Tests/HumanInventoryUniformSlotsTest.cs
View File

@@ -123,15 +123,16 @@ namespace Content.IntegrationTests.Tests
private static bool IsDescendant(EntityUid descendant, EntityUid parent)
{
var tmpParent = IoCManager.Resolve<IEntityManager>().GetComponent<TransformComponent>(descendant).Parent;
while (tmpParent != null)
var xforms = IoCManager.Resolve<IEntityManager>().GetEntityQuery<TransformComponent>();
var tmpParent = xforms.GetComponent(descendant).ParentUid;
while (tmpParent.IsValid())
{
if (tmpParent.Owner == parent)
if (tmpParent == parent)
{
return true;
}
tmpParent = tmpParent.Parent;
tmpParent = xforms.GetComponent(tmpParent).ParentUid;
}
return false;

2
Content.IntegrationTests/Tests/Interaction/Click/InteractionSystemTests.cs
View File

@@ -331,7 +331,7 @@ namespace Content.IntegrationTests.Tests.Interaction.Click
await server.WaitAssertion(() =>
{
Assert.That(container.Insert(user));
Assert.That(sEntities.GetComponent<TransformComponent>(user).Parent.Owner, Is.EqualTo(containerEntity));
Assert.That(sEntities.GetComponent<TransformComponent>(user).ParentUid, Is.EqualTo(containerEntity));
testInteractionSystem.InteractUsingEvent = (ev) => { Assert.That(ev.Target, Is.EqualTo(containerEntity)); interactUsing = true; };
testInteractionSystem.InteractHandEvent = (ev) => { Assert.That(ev.Target, Is.EqualTo(containerEntity)); interactHand = true; };