Misc state handling changes (#9265)

* misc state handling changes

* ambient dirtying

Content.Shared/Actions/SharedActionsSystem.cs

@@ -409,7 +409,8 @@ public abstract class SharedActionsSystem : EntitySystem
 
         var provided = comp.Actions.Where(act => act.Provider == provider).ToList();
 
-        RemoveActions(uid, provided, comp);
+        if (provided.Count > 0)
+            RemoveActions(uid, provided, comp);
     }
 
     public virtual void RemoveActions(EntityUid uid, IEnumerable<ActionType> actions, ActionsComponent? comp = null, bool dirty = true)

Content.Shared/Audio/SharedAmbientSoundSystem.cs

@@ -20,7 +20,7 @@ namespace Content.Shared.Audio
                 ambience.Enabled == value) return;
 
             ambience.Enabled = value;
-            ambience.Dirty();
+            Dirty(ambience);
         }
 
         private void HandleCompState(EntityUid uid, AmbientSoundComponent component, ref ComponentHandleState args)

Content.Shared/Movement/Components/MovementSpeedModifierComponent.cs

@@ -17,7 +17,7 @@ namespace Content.Shared.Movement.Components
         public float SprintSpeedModifier = 1.0f;
 
         [ViewVariables(VVAccess.ReadWrite)]
-        public float BaseWalkSpeedVV
+        private float _baseWalkSpeedVV
         {
             get => BaseWalkSpeed;
             set
@@ -28,7 +28,7 @@ namespace Content.Shared.Movement.Components
         }
 
         [ViewVariables(VVAccess.ReadWrite)]
-        public float BaseSprintSpeedVV
+        private float _baseSprintSpeedVV
         {
             get => BaseSprintSpeed;
             set

Content.Shared/Movement/Systems/MovementSpeedModifierSystem.cs

@@ -42,9 +42,12 @@ namespace Content.Shared.Movement.Systems
             var ev = new RefreshMovementSpeedModifiersEvent();
             RaiseLocalEvent(uid, ev);
 
+            if (MathHelper.CloseTo(ev.WalkSpeedModifier, move.WalkSpeedModifier) &&
+                MathHelper.CloseTo(ev.SprintSpeedModifier, move.SprintSpeedModifier))
+                return;
+
             move.WalkSpeedModifier = ev.WalkSpeedModifier;
             move.SprintSpeedModifier = ev.SprintSpeedModifier;
-
             Dirty(move);
         }