Enable nullability in Content.Client (#3257)

* Enable nullability in Content.Client

* Remove #nullable enable

* Merge fixes

* Remove Debug.Assert

* Merge fixes

* Fix build

* Fix build

Content.Client/GameObjects/Components/Chemistry/ChemMaster/ChemMasterBoundUserInterface.cs

@@ -1,4 +1,3 @@
-#nullable enable
 using Content.Shared.GameObjects.Components.Chemistry.ReagentDispenser;
 using JetBrains.Annotations;
 using Robust.Client.GameObjects;

Content.Client/GameObjects/Components/Chemistry/ChemMaster/ChemMasterWindow.cs

@@ -13,6 +13,7 @@ using Robust.Shared.Localization;
 using Robust.Shared.Maths;
 using Robust.Shared.Prototypes;
 using static Content.Shared.GameObjects.Components.Chemistry.ChemMaster.SharedChemMasterComponent;
+using static Robust.Client.UserInterface.Controls.BaseButton;
 
 namespace Content.Client.GameObjects.Components.Chemistry.ChemMaster
 {
@@ -38,7 +39,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ChemMaster
 
         public bool BufferModeTransfer = true;
 
-        public event Action<BaseButton.ButtonEventArgs, ChemButton> OnChemButtonPressed;
+        public event Action<ButtonEventArgs, ChemButton>? OnChemButtonPressed;
 
         public HBoxContainer PillInfo { get; set; }
         public HBoxContainer BottleInfo { get; set; }
@@ -331,7 +332,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ChemMaster
             {
                 var name = Loc.GetString("Unknown reagent");
                 //Try to the prototype for the given reagent. This gives us it's name.
-                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype proto))
+                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype? proto))
                 {
                     name = proto.Name;
                 }
@@ -386,7 +387,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ChemMaster
             {
                 var name = Loc.GetString("Unknown reagent");
                 //Try to the prototype for the given reagent. This gives us it's name.
-                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype proto))
+                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype? proto))
                 {
                     name = proto.Name;
                 }

Content.Client/GameObjects/Components/Chemistry/FoamVisualizer.cs

@@ -1,5 +1,4 @@
-#nullable enable
-using System;
+using System;
 using Content.Shared.GameObjects.Components.Chemistry;
 using JetBrains.Annotations;
 using Robust.Client.Animations;

Content.Client/GameObjects/Components/Chemistry/HyposprayComponent.cs

@@ -9,8 +9,6 @@ using Robust.Shared.Localization;
 using Robust.Shared.Timing;
 using Robust.Shared.ViewVariables;
 
-#nullable enable
-
 namespace Content.Client.GameObjects.Components.Chemistry
 {
     [RegisterComponent]

Content.Client/GameObjects/Components/Chemistry/InjectorComponent.cs

@@ -27,7 +27,7 @@ namespace Content.Client.GameObjects.Components.Chemistry
         void IItemStatus.DestroyControl(Control control) { }
 
         //Handle net updates
-        public override void HandleComponentState(ComponentState curState, ComponentState nextState)
+        public override void HandleComponentState(ComponentState? curState, ComponentState? nextState)
         {
             if (curState is not InjectorComponentState state)
             {

Content.Client/GameObjects/Components/Chemistry/ReagentDispenser/ReagentDispenserBoundUserInterface.cs

@@ -16,12 +16,11 @@ namespace Content.Client.GameObjects.Components.Chemistry.ReagentDispenser
     [UsedImplicitly]
     public class ReagentDispenserBoundUserInterface : BoundUserInterface
     {
-        private ReagentDispenserWindow _window;
-        private ReagentDispenserBoundUserInterfaceState _lastState;
+        private ReagentDispenserWindow? _window;
+        private ReagentDispenserBoundUserInterfaceState? _lastState;
 
         public ReagentDispenserBoundUserInterface(ClientUserInterfaceComponent owner, object uiKey) : base(owner, uiKey)
         {
-
         }
 
         /// <summary>
@@ -80,8 +79,14 @@ namespace Content.Client.GameObjects.Components.Chemistry.ReagentDispenser
         /// <param name="inventory">A list of the reagents which can be dispensed.</param>
         private void UpdateReagentsList(List<ReagentDispenserInventoryEntry> inventory)
         {
+            if (_window == null)
+            {
+                return;
+            }
+
             _window.UpdateReagentsList(inventory);
-            for (int i = 0; i < _window.ChemicalList.Children.Count(); i++)
+
+            for (var i = 0; i < _window.ChemicalList.Children.Count(); i++)
             {
                 var button = (Button)_window.ChemicalList.Children.ElementAt(i);
                 var i1 = i;

Content.Client/GameObjects/Components/Chemistry/ReagentDispenser/ReagentDispenserWindow.cs

@@ -157,7 +157,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ReagentDispenser
 
             foreach (var entry in inventory)
             {
-                if (_prototypeManager.TryIndex(entry.ID, out ReagentPrototype proto))
+                if (_prototypeManager.TryIndex(entry.ID, out ReagentPrototype? proto))
                 {
                     ChemicalList.AddChild(new Button {Text = proto.Name});
                 }
@@ -253,8 +253,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ReagentDispenser
         /// </summary>
         /// <param name="state">State data for the dispenser.</param>
         /// <param name="highlightedReagentId">Prototype id of the reagent whose dispense button is currently being mouse hovered.</param>
-        public void UpdateContainerInfo(ReagentDispenserBoundUserInterfaceState state,
-            string highlightedReagentId = null)
+        public void UpdateContainerInfo(ReagentDispenserBoundUserInterfaceState state, string highlightedReagentId = "")
         {
             ContainerInfo.Children.Clear();
 
@@ -286,7 +285,7 @@ namespace Content.Client.GameObjects.Components.Chemistry.ReagentDispenser
             {
                 var name = Loc.GetString("Unknown reagent");
                 //Try to the prototype for the given reagent. This gives us it's name.
-                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype proto))
+                if (_prototypeManager.TryIndex(reagent.ReagentId, out ReagentPrototype? proto))
                 {
                     name = proto.Name;
                 }

Content.Client/GameObjects/Components/Chemistry/SmokeVisualizer.cs

@@ -1,5 +1,4 @@
-#nullable enable
-using Content.Shared.GameObjects.Components.Chemistry;
+using Content.Shared.GameObjects.Components.Chemistry;
 using JetBrains.Annotations;
 using Robust.Client.GameObjects;
 using Robust.Shared.Maths;

Content.Client/GameObjects/Components/Chemistry/SolutionContainerComponent.cs

@@ -1,4 +1,3 @@
-#nullable enable
 using Content.Shared.GameObjects.Components.Chemistry;
 using Robust.Shared.GameObjects;