From 9897bf62e1dc4a5ac7aab209e71442799115003f Mon Sep 17 00:00:00 2001
From: Morbo <exstrominer@gmail.com>
Date: Mon, 17 Jan 2022 04:59:05 +0300
Subject: [PATCH] Move some strings to ftl files (#6203)

---
 Content.Client/Lobby/UI/LobbyGui.xaml              | 14 +++++++-------
 Content.Client/Lobby/UI/ObserveWarningWindow.xaml  |  2 +-
 Content.Client/Traitor/Uplink/UplinkMenu.xaml      |  2 +-
 Resources/Locale/en-US/lobby/lobby-gui.ftl         |  7 +++++++
 .../en-US/lobby/ui/observe-warning-window.ftl      |  1 +
 .../en-US/traitor/uplink/uplink-component.ftl      |  1 +
 6 files changed, 18 insertions(+), 9 deletions(-)
 create mode 100644 Resources/Locale/en-US/lobby/lobby-gui.ftl

diff --git a/Content.Client/Lobby/UI/LobbyGui.xaml b/Content.Client/Lobby/UI/LobbyGui.xaml
index b3d5a529a7..8bc9797a13 100644
--- a/Content.Client/Lobby/UI/LobbyGui.xaml
+++ b/Content.Client/Lobby/UI/LobbyGui.xaml
@@ -19,11 +19,11 @@
             <BoxContainer Orientation="Vertical">
                 <!-- Top row -->
                 <BoxContainer Orientation="Horizontal" MinSize="0 40">
-                    <Label Margin="8 0 0 0" StyleClasses="LabelHeadingBigger" VAlign="Center" Text="{Loc 'Lobby'}" />
+                    <Label Margin="8 0 0 0" StyleClasses="LabelHeadingBigger" VAlign="Center" Text="{Loc 'ui-lobby-title'}" />
                     <Label Name="ServerName" Access="Public" StyleClasses="LabelHeadingBigger" VAlign="Center" />
                     <ui:VoteCallMenuButton Name="CallVoteButton" StyleClasses="ButtonBig" />
-                    <Button Name="OptionsButton" Access="Public" StyleClasses="ButtonBig" Text="{Loc 'Options'}" />
-                    <Button Name="LeaveButton" Access="Public" StyleClasses="ButtonBig" Text="{Loc 'Leave'}" />
+                    <Button Name="OptionsButton" Access="Public" StyleClasses="ButtonBig" Text="{Loc 'ui-lobby-options-button'}" />
+                    <Button Name="LeaveButton" Access="Public" StyleClasses="ButtonBig" Text="{Loc 'ui-lobby-leave-button'}" />
                 </BoxContainer>
                 <!-- Gold line -->
                 <PanelContainer>
@@ -38,13 +38,13 @@
                     <BoxContainer Orientation="Vertical" Name="LeftPanelContainer" HorizontalExpand="True">
                         <hudUi:StripeBack>
                             <BoxContainer Orientation="Horizontal" SeparationOverride="6" Margin="3 3 3 3">
-                                <cc:UICommandButton Command="observe" Name="ObserveButton" Access="Public" Text="{Loc 'Observe'}" StyleClasses="ButtonBig"  WindowType="{x:Type lobbyUi:ObserveWarningWindow}"/>
+                                <cc:UICommandButton Command="observe" Name="ObserveButton" Access="Public" Text="{Loc 'ui-lobby-observe-button'}" StyleClasses="ButtonBig"  WindowType="{x:Type lobbyUi:ObserveWarningWindow}"/>
                                 <Label Name="StartTime"
                                        Access="Public"
                                        Align="Right"
                                        FontColorOverride="{x:Static maths:Color.DarkGray}"
                                        StyleClasses="LabelBig" HorizontalExpand="True" />
-                                <Button Name="ReadyButton" Access="Public" ToggleMode="True" Text="{Loc 'Ready Up'}"
+                                <Button Name="ReadyButton" Access="Public" ToggleMode="True" Text="{Loc 'ui-lobby-ready-up-button'}"
                                         StyleClasses="ButtonBig" />
                             </BoxContainer>
                         </hudUi:StripeBack>
@@ -60,14 +60,14 @@
                     <Control HorizontalExpand="True">
                         <BoxContainer Orientation="Vertical">
                             <!-- Player list -->
-                            <hudUi:NanoHeading Text="{Loc 'Online Players'}" />
+                            <hudUi:NanoHeading Text="{Loc 'ui-lobby-online-players-block'}" />
                             <lobbyUi:LobbyPlayerList Name="OnlinePlayerList"
                                                      Access="Public"
                                                      HorizontalExpand="True"
                                                      VerticalExpand="True"
                                                      Margin="3 3 3 3" />
                             <!-- Server info -->
-                            <hudUi:NanoHeading Text="{Loc 'Server Info'}" />
+                            <hudUi:NanoHeading Text="{Loc 'ui-lobby-server-info-block'}" />
                             <info:ServerInfo Name="ServerInfo"
                                              Access="Public"
                                              VerticalExpand="True"
diff --git a/Content.Client/Lobby/UI/ObserveWarningWindow.xaml b/Content.Client/Lobby/UI/ObserveWarningWindow.xaml
index 1b4d5ba7b3..4abdc245be 100644
--- a/Content.Client/Lobby/UI/ObserveWarningWindow.xaml
+++ b/Content.Client/Lobby/UI/ObserveWarningWindow.xaml
@@ -7,7 +7,7 @@
         <BoxContainer Orientation="Horizontal" >
             <Button Name="NevermindButton" Text="{Loc 'observe-nevermind'}" SizeFlagsStretchRatio="1"/>
             <Control HorizontalExpand="True" SizeFlagsStretchRatio="2" />
-            <cc:CommandButton  Command="observe" Name="ObserveButton" StyleClasses="Caution" Text="{Loc 'Observe'}" SizeFlagsStretchRatio="1"/>
+            <cc:CommandButton  Command="observe" Name="ObserveButton" StyleClasses="Caution" Text="{Loc 'observe-confirm'}" SizeFlagsStretchRatio="1"/>
         </BoxContainer>
     </BoxContainer>
 </SS14Window>
diff --git a/Content.Client/Traitor/Uplink/UplinkMenu.xaml b/Content.Client/Traitor/Uplink/UplinkMenu.xaml
index 0f67b73fbb..7e206881b9 100644
--- a/Content.Client/Traitor/Uplink/UplinkMenu.xaml
+++ b/Content.Client/Traitor/Uplink/UplinkMenu.xaml
@@ -13,7 +13,7 @@
                                HorizontalExpand="True"
                                HorizontalAlignment="Left" />
                 <Button Name="WithdrawButton"
-                        Text="Withdraw"
+                        Text="{Loc 'uplink-user-interface-withdraw-button'}"
                         HorizontalAlignment="Right"
                         MinWidth="64"/>
             </BoxContainer>
diff --git a/Resources/Locale/en-US/lobby/lobby-gui.ftl b/Resources/Locale/en-US/lobby/lobby-gui.ftl
new file mode 100644
index 0000000000..17c7039d7b
--- /dev/null
+++ b/Resources/Locale/en-US/lobby/lobby-gui.ftl
@@ -0,0 +1,7 @@
+ui-lobby-title = Lobby
+ui-lobby-options-button = Options
+ui-lobby-leave-button = Leave
+ui-lobby-observe-button = Observe
+ui-lobby-ready-up-button = Ready Up
+ui-lobby-online-players-block = Online Players
+ui-lobby-server-info-block = Server Info
diff --git a/Resources/Locale/en-US/lobby/ui/observe-warning-window.ftl b/Resources/Locale/en-US/lobby/ui/observe-warning-window.ftl
index b9b001d06b..4f1c87f16a 100644
--- a/Resources/Locale/en-US/lobby/ui/observe-warning-window.ftl
+++ b/Resources/Locale/en-US/lobby/ui/observe-warning-window.ftl
@@ -1,4 +1,5 @@
 observe-nevermind = Nevermind
+observe-confirm = Observe
 observe-warning-1 = Are you sure you want to observe?
 observe-warning-2 = You cannot play in the round if you do so.
 observe-warning-window-title = Warning
diff --git a/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl b/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
index 7e51046bc5..ae6a438e2e 100644
--- a/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
+++ b/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
@@ -8,6 +8,7 @@ uplink-user-interface-search-label = Search
 
 # Withdraw UI
 
+uplink-user-interface-withdraw-button = Withdraw TC
 uplink-user-interface-withdraw-title = Withdraw TC
 uplink-user-interface-withdraw-withdraw-button = Withdraw
 uplink-user-interface-withdraw-cancel-button = Cancel