Move Access to ECS (#4826)

* Moved access to ecs

* Fixed tests

* Moved test to integration

* Better IoC

* Moved preset ID card

* Moved id card to ECS

* Moved access component to ECS

* Fixed pda access

* Final touches

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

Content.Server/Access/Systems/AccessReaderSystem.cs

@@ -0,0 +1,119 @@
+using Content.Server.Access.Components;
+using Content.Server.Inventory.Components;
+using Content.Server.Items;
+using Content.Server.PDA;
+using Content.Shared.Access;
+using Content.Shared.Hands.Components;
+using Content.Shared.Inventory;
+using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
+using Robust.Shared.Log;
+using Robust.Shared.Prototypes;
+using System;
+using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Linq;
+
+namespace Content.Server.Access.Systems
+{
+    public class AccessReaderSystem : EntitySystem
+    {
+        [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
+
+        public override void Initialize()
+        {
+            base.Initialize();
+            SubscribeLocalEvent<AccessReader, ComponentInit>(OnInit);
+        }
+
+        private void OnInit(EntityUid uid, AccessReader reader, ComponentInit args)
+        {
+            var allTags = reader.AccessLists.SelectMany(c => c).Union(reader.DenyTags);
+            foreach (var level in allTags)
+            {
+                if (!_prototypeManager.HasIndex<AccessLevelPrototype>(level))
+                {
+                    Logger.ErrorS("access", $"Invalid access level: {level}");
+                }
+            }
+        }
+
+        /// <summary>
+        /// Searches an <see cref="AccessComponent"/> in the entity itself, in its active hand or in its ID slot.
+        /// Then compares the found access with the configured access lists to see if it is allowed.
+        /// </summary>
+        /// <remarks>
+        ///     If no access is found, an empty set is used instead.
+        /// </remarks>
+        /// <param name="entity">The entity to be searched for access.</param>
+        public bool IsAllowed(AccessReader reader, EntityUid entity)
+        {
+            var tags = FindAccessTags(entity);
+            return IsAllowed(reader, tags);
+        }
+
+        public bool IsAllowed(AccessReader reader, ICollection<string> accessTags)
+        {
+            if (reader.DenyTags.Overlaps(accessTags))
+            {
+                // Sec owned by cargo.
+                return false;
+            }
+
+            return reader.AccessLists.Count == 0 || reader.AccessLists.Any(a => a.IsSubsetOf(accessTags));
+        }
+
+        public ICollection<string> FindAccessTags(EntityUid uid)
+        {
+            // check entity itself
+            if (FindAccessTagsItem(uid, out var tags))
+                return tags;
+
+            // maybe access component inside its hands?
+            if (EntityManager.TryGetComponent(uid, out SharedHandsComponent? hands))
+            {
+                if (hands.TryGetActiveHeldEntity(out var heldItem) &&
+                    FindAccessTagsItem(heldItem.Uid, out tags))
+                {
+                    return tags;
+                }
+            }
+
+            // maybe its inside an inventory slot?
+            if (EntityManager.TryGetComponent(uid, out InventoryComponent? inventoryComponent))
+            {
+                if (inventoryComponent.HasSlot(EquipmentSlotDefines.Slots.IDCARD) &&
+                    inventoryComponent.TryGetSlotItem(EquipmentSlotDefines.Slots.IDCARD, out ItemComponent? item) &&
+                    FindAccessTagsItem(item.Owner.Uid, out tags)
+                )
+                {
+                    return tags;
+                }
+            }
+
+            return Array.Empty<string>();
+        }
+
+        /// <summary>
+        ///     Try to find <see cref="AccessComponent"/> on this item
+        ///     or inside this item (if it's pda)
+        /// </summary>
+        private bool FindAccessTagsItem(EntityUid uid, [NotNullWhen(true)] out HashSet<string>? tags)
+        {
+            if (EntityManager.TryGetComponent(uid, out AccessComponent? access))
+            {
+                tags = access.Tags;
+                return true;
+            }
+
+            if (EntityManager.TryGetComponent(uid, out PDAComponent? pda))
+            {
+                tags = pda?.ContainedID?.Owner?.GetComponent<AccessComponent>()?.Tags;
+                return tags != null;
+            }
+
+            tags = null;
+            return false;
+        }
+    }
+}

Content.Server/Access/Systems/AccessSystem.cs

@@ -0,0 +1,24 @@
+using Content.Server.Access.Components;
+using Robust.Shared.GameObjects;
+using System.Collections.Generic;
+
+namespace Content.Server.Access.Systems
+{
+    public class AccessSystem : EntitySystem
+    {
+        /// <summary>
+        ///     Replaces the set of access tags we have with the provided set.
+        /// </summary>
+        /// <param name="newTags">The new access tags</param>
+        public bool TrySetTags(EntityUid uid, IEnumerable<string> newTags, AccessComponent? access = null)
+        {
+            if (!Resolve(uid, ref access))
+                return false;
+
+            access.Tags.Clear();
+            access.Tags.UnionWith(newTags);
+
+            return true;
+        }
+    }
+}

Content.Server/Access/Systems/IdCardSystem.cs

@@ -0,0 +1,70 @@
+using Content.Server.Access.Components;
+using Robust.Shared.GameObjects;
+using Robust.Shared.Localization;
+
+namespace Content.Server.Access.Systems
+{
+    public class IdCardSystem : EntitySystem
+    {
+        public override void Initialize()
+        {
+            base.Initialize();
+            SubscribeLocalEvent<IdCardComponent, ComponentInit>(OnInit);
+        }
+
+        private void OnInit(EntityUid uid, IdCardComponent id, ComponentInit args)
+        {
+            id.OriginalOwnerName ??= id.Owner.Name;
+            UpdateEntityName(uid, id);
+        }
+
+        public bool TryChangeJobTitle(EntityUid uid, string jobTitle, IdCardComponent? id = null)
+        {
+            if (!Resolve(uid, ref id))
+                return false;
+
+            id.JobTitle = jobTitle;
+            UpdateEntityName(uid, id);
+            return true;
+        }
+
+        public bool TryChangeFullName(EntityUid uid, string fullName, IdCardComponent? id = null)
+        {
+            if (!Resolve(uid, ref id))
+                return false;
+
+            id.FullName = fullName;
+            UpdateEntityName(uid, id);
+            return true;
+        }
+
+        /// <summary>
+        /// Changes the <see cref="Entity.Name"/> of <see cref="Component.Owner"/>.
+        /// </summary>
+        /// <remarks>
+        /// If either <see cref="FullName"/> or <see cref="JobTitle"/> is empty, it's replaced by placeholders.
+        /// If both are empty, the original entity's name is restored.
+        /// </remarks>
+        private void UpdateEntityName(EntityUid uid, IdCardComponent? id = null)
+        {
+            if (!Resolve(uid, ref id))
+                return;
+
+            if (string.IsNullOrWhiteSpace(id.FullName) && string.IsNullOrWhiteSpace(id.JobTitle))
+            {
+                id.Owner.Name = id.OriginalOwnerName;
+                return;
+            }
+
+            var jobSuffix = string.IsNullOrWhiteSpace(id.JobTitle) ? string.Empty : $" ({id.JobTitle})";
+
+            id.Owner.Name = string.IsNullOrWhiteSpace(id.FullName)
+                ? Loc.GetString("access-id-card-component-owner-name-job-title-text",
+                                ("originalOwnerName", id.OriginalOwnerName),
+                                ("jobSuffix", jobSuffix))
+                : Loc.GetString("access-id-card-component-owner-full-name-job-title-text",
+                                ("fullName", id.FullName),
+                                ("jobSuffix", jobSuffix));
+        }
+    }
+}

Content.Server/Access/Systems/PresetIdCardSystem.cs

@@ -0,0 +1,40 @@
+using Content.Server.Access.Components;
+using Content.Shared.Roles;
+using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
+using Robust.Shared.Log;
+using Robust.Shared.Prototypes;
+using System;
+
+namespace Content.Server.Access.Systems
+{
+    public class PresetIdCardSystem : EntitySystem
+    {
+        [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
+        [Dependency] private readonly IdCardSystem _cardSystem = default!;
+        [Dependency] private readonly AccessSystem _accessSystem = default!;
+
+        public override void Initialize()
+        {
+            base.Initialize();
+            SubscribeLocalEvent<PresetIdCardComponent, MapInitEvent>(OnMapInit);
+        }
+
+        private void OnMapInit(EntityUid uid, PresetIdCardComponent id, MapInitEvent args)
+        {
+            if (id.JobName == null) return;
+
+            if (!_prototypeManager.TryIndex(id.JobName, out JobPrototype? job))
+            {
+                Logger.ErrorS("access", $"Invalid job id ({id.JobName}) for preset card");
+                return;
+            }
+
+            // set access for access component
+            _accessSystem.TrySetTags(uid, job.Access);
+
+            // and also change job title on a card id
+            _cardSystem.TryChangeJobTitle(uid, job.Name);
+        }
+    }
+}