Resolves GenericEnumVisualizer is Obsolete (#13914)

Content.Client/Visualizer/GenericEnumVisualizer.cs

@@ -1,66 +0,0 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using JetBrains.Annotations;
-using Robust.Client.GameObjects;
-using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Log;
-using Robust.Shared.Reflection;
-using Robust.Shared.Serialization;
-using Robust.Shared.Serialization.Manager.Attributes;
-
-namespace Content.Client.Visualizer
-{
-    [UsedImplicitly]
-    public sealed class GenericEnumVisualizer : AppearanceVisualizer, ISerializationHooks
-    {
-        public Enum Key { get; set; } = default!;
-
-        public Dictionary<object, string> States { get; set; } = default!;
-
-        [DataField("layer")]
-        public int Layer { get; set; } = 0;
-
-        [DataField("key", readOnly: true, required: true)]
-        private string _keyRaw = default!;
-
-        [DataField("states", readOnly: true, required: true)]
-        private Dictionary<string, string> _statesRaw { get; set; } = default!;
-
-        void ISerializationHooks.AfterDeserialization()
-        {
-            var reflectionManager = IoCManager.Resolve<IReflectionManager>();
-
-            object ResolveRef(string raw)
-            {
-                if (reflectionManager.TryParseEnumReference(raw, out var @enum))
-                {
-                    return @enum;
-                }
-                else
-                {
-                    Logger.WarningS("c.c.v.genum", $"Unable to convert enum reference: {raw}");
-                }
-
-                return raw;
-            }
-
-            // It's important that this conversion be done here so that it may "fail-fast".
-            Key = (Enum) ResolveRef(_keyRaw);
-            States = _statesRaw.ToDictionary(kvp => ResolveRef(kvp.Key), kvp => kvp.Value);
-        }
-
-        [Obsolete("Subscribe to AppearanceChangeEvent instead.")]
-        public override void OnChangeData(AppearanceComponent component)
-        {
-            base.OnChangeData(component);
-
-            var entities = IoCManager.Resolve<IEntityManager>();
-            if (!entities.TryGetComponent(component.Owner, out SpriteComponent? sprite)) return;
-            if (!component.TryGetData(Key, out object status)) return;
-            if (!States.TryGetValue(status, out var val)) return;
-            sprite.LayerSetState(Layer, val);
-        }
-    }
-}

Resources/Prototypes/Entities/Mobs/Player/silicon.yml

@@ -130,6 +130,7 @@
     layers:
     - state: shell
       sprite: Mobs/Silicon/drone.rsi
+      map: ["base"]
   - type: MovementIgnoreGravity
   - type: Fixtures
     fixtures:
@@ -143,13 +144,12 @@
         layer:
         - SmallMobLayer
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-      - type: GenericEnumVisualizer
+      enum.DroneVisuals.Status:
-        key: enum.DroneVisuals.Status
+        base:
-        layer: 0
+          Off: { state: shell }
-        states:
+          On: { state: drone }
-          enum.DroneStatus.Off: shell
-          enum.DroneStatus.On: drone
   - type: ReplacementAccent
     accent: silicon
   - type: Repairable

Resources/Prototypes/Entities/Objects/Devices/mousetrap.yml

@@ -10,6 +10,7 @@
       drawdepth: SmallMobs # if mice can hide under tables, so can mousetraps
       layers:
         - state: mousetrap
+          map: ["base"]
     - type: StepTrigger
       intersectRatio: 0.2
       requiredTriggeredSpeed: 0
@@ -27,13 +28,12 @@
     - type: Item
       sprite: Objects/Devices/mousetrap.rsi
     - type: Appearance
+    - type: GenericVisualizer
       visuals:
-        - type: GenericEnumVisualizer
+        enum.MousetrapVisuals.Visual:
-          key: enum.MousetrapVisuals.Visual
+          base:
-          layer: 0
+            Armed: { state: mousetraparmed }
-          states:
+            Unarmed: { state: mousetrap }
-            enum.MousetrapVisuals.Armed: mousetraparmed
-            enum.MousetrapVisuals.Unarmed: mousetrap
     - type: Physics
       bodyType: Dynamic
     - type: CollisionWake

Resources/Prototypes/Entities/Objects/Devices/payload.yml

@@ -60,6 +60,9 @@
   - type: Sprite
     sprite: Objects/Devices/payload.rsi
     state: payload-empty
+    layers:
+    - state: payload-empty
+      map: ["base"]
   - type: ChemicalPayload
     beakerSlotA: &slotDef
       whitelist:
@@ -68,14 +71,14 @@
       swap: false
     beakerSlotB: *slotDef
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-    - type: GenericEnumVisualizer
+      enum.ChemicalPayloadVisuals.Slots:
-      key: enum.ChemicalPayloadVisuals.Slots
+        base:
-      states:
+          None: { state: payload-empty }
-        enum.ChemicalPayloadFilledSlots.None: payload-empty
+          Left: { state: payload-chemical-left }
-        enum.ChemicalPayloadFilledSlots.Left: payload-chemical-left
+          Right: { state: payload-chemical-right }
-        enum.ChemicalPayloadFilledSlots.Right: payload-chemical-right
+          Both: { state: payload-chemical-armed }
-        enum.ChemicalPayloadFilledSlots.Both: payload-chemical-armed
   - type: ItemSlots
   - type: ContainerContainer
     containers:

Resources/Prototypes/Entities/Objects/Fun/pai.yml

@@ -22,6 +22,7 @@
     - state: pai-base
     - state: pai-off-overlay
       shader: unshaded
+      map: ["screen"]
   - type: Input
     context: "human"
   - type: PAI
@@ -50,12 +51,10 @@
     allowedStates:
       - Alive
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-      - type: GenericEnumVisualizer
+      enum.PAIVisuals.Status:
-        key: enum.PAIVisuals.Status
+        screen:
-        layer: 1
+          Off: { state: pai-off-overlay }
-        states:
+          Searching: { state: pai-searching-overlay }
-          enum.PAIStatus.Off: pai-off-overlay
+          On: { state: pai-on-overlay }
-          enum.PAIStatus.Searching: pai-searching-overlay
-          enum.PAIStatus.On: pai-on-overlay
-

Resources/Prototypes/Entities/Objects/Tools/t-ray.yml

@@ -8,17 +8,17 @@
     netsync: false
     layers:
     - state: tray-off
+      map: ["base"]
   - type: TrayScanner
   - type: Item
     sprite: Objects/Tools/t-ray.rsi
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-    - type: GenericEnumVisualizer
+      enum.TrayScannerVisual.Visual:
-      key: enum.TrayScannerVisual.Visual
+        base:
-      layer: 0
+          On: { state: tray-on }
-      states:
+          Off: { state: tray-off }
-        enum.TrayScannerVisual.On: tray-on
-        enum.TrayScannerVisual.Off: tray-off
   - type: Tag
     tags:
       - DroneUsable

Resources/Prototypes/Entities/Objects/Weapons/Bombs/funny.yml

@@ -8,6 +8,9 @@
       sprite: Objects/Weapons/Bombs/hot_potato.rsi
       state: icon
       netsync: false
+      layers:
+      - state: icon
+        map: ["base"]
     - type: Item
       sprite: Objects/Weapons/Bombs/hot_potato.rsi
       size: 5
@@ -40,12 +43,12 @@
         types:
           Heat: 1
     - type: Appearance
+    - type: GenericVisualizer
       visuals:
-        - type: GenericEnumVisualizer
+        enum.Trigger.TriggerVisuals.VisualState:
-          key: enum.Trigger.TriggerVisuals.VisualState
+          base:
-          states:
+            Primed: { state: activated }
-            enum.Trigger.TriggerVisualState.Primed: activated
+            Unprimed: { state: complete }
-            enum.Trigger.TriggerVisualState.Unprimed: complete
 
 - type: entity
   id: HotPotatoEffect

Resources/Prototypes/Entities/Objects/Weapons/Bombs/plastic.yml

@@ -4,56 +4,59 @@
   parent: BaseItem
   id: C4
   components:
-    - type: Sprite
+  - type: Sprite
-      sprite: Objects/Weapons/Bombs/c4.rsi
+    sprite: Objects/Weapons/Bombs/c4.rsi
-      state: icon
+    state: icon
-    - type: Item
+    layers:
-      sprite: Objects/Weapons/Bombs/c4.rsi
+    - state: icon
-      size: 10
+      map: ["base"]
-    - type: OnUseTimerTrigger
+  - type: Item
-      delay: 10
+    sprite: Objects/Weapons/Bombs/c4.rsi
-      delayOptions: [10, 30, 60, 120, 300]
+    size: 10
-      initialBeepDelay: 0
+  - type: OnUseTimerTrigger
-      beepSound: /Audio/Machines/Nuke/general_beep.ogg
+    delay: 10
-      startOnStick: true
+    delayOptions: [10, 30, 60, 120, 300]
-      canToggleStartOnStick: true
+    initialBeepDelay: 0
-    - type: TriggerOnSignal
+    beepSound: /Audio/Machines/Nuke/general_beep.ogg
-    - type: DeviceLinkSink
+    startOnStick: true
-      ports:
+    canToggleStartOnStick: true
-        - Trigger
+  - type: TriggerOnSignal
-    - type: Sticky
+  - type: DeviceLinkSink
-      stickDelay: 5
+    ports:
-      unstickDelay: 5
+      - Trigger
-      stickPopupStart: comp-sticky-start-stick-bomb
+  - type: Sticky
-      stickPopupSuccess: comp-sticky-success-stick-bomb
+    stickDelay: 5
-      unstickPopupStart: comp-sticky-start-unstick-bomb
+    unstickDelay: 5
-      unstickPopupSuccess: comp-sticky-success-unstick-bomb
+    stickPopupStart: comp-sticky-start-stick-bomb
-      blacklist: # can't stick it to other items
+    stickPopupSuccess: comp-sticky-success-stick-bomb
-        components:
+    unstickPopupStart: comp-sticky-start-unstick-bomb
-          - Item
+    unstickPopupSuccess: comp-sticky-success-unstick-bomb
-    - type: Explosive # Powerful explosion in a very small radius. Doesn't break underplating.
+    blacklist: # can't stick it to other items
-      explosionType: DemolitionCharge
+      components:
-      totalIntensity: 60
+        - Item
-      intensitySlope: 5
+  - type: Explosive # Powerful explosion in a very small radius. Doesn't break underplating.
-      maxIntensity: 30
+    explosionType: DemolitionCharge
-      canCreateVacuum: false
+    totalIntensity: 60
-    - type: ExplodeOnTrigger
+    intensitySlope: 5
-    - type: Damageable
+    maxIntensity: 30
-      damageContainer: Inorganic
+    canCreateVacuum: false
-    - type: Destructible
+  - type: ExplodeOnTrigger
-      thresholds:
+  - type: Damageable
-        - trigger:
+    damageContainer: Inorganic
-            !type:DamageTrigger
+  - type: Destructible
-            damage: 50
+    thresholds:
-          behaviors:
+      - trigger:
-            - !type:DoActsBehavior
+          !type:DamageTrigger
-              acts: ["Destruction"]
+          damage: 50
-            - !type:ExplodeBehavior
+        behaviors:
-    - type: StickyVisualizer
+          - !type:DoActsBehavior
-    - type: Appearance
+            acts: ["Destruction"]
-      visuals:
+          - !type:ExplodeBehavior
-        - type: GenericEnumVisualizer
+  - type: StickyVisualizer
-          key: enum.Trigger.TriggerVisuals.VisualState
+  - type: Appearance
-          states:
+  - type: GenericVisualizer
-            enum.Trigger.TriggerVisualState.Primed: primed
+    visuals:
-            enum.Trigger.TriggerVisualState.Unprimed: complete
+      enum.Trigger.TriggerVisuals.VisualState:
+        base:
+          Primed: { state: primed }
+          Unprimed: { state: complete }

Resources/Prototypes/Entities/Objects/Weapons/Throwable/grenades.yml

@@ -168,12 +168,6 @@
       - !type:DoActsBehavior
         acts: [ "Destruction" ]
   - type: Appearance
-    visuals:
-    - type: GenericEnumVisualizer
-      key: enum.Trigger.TriggerVisuals.VisualState
-      states:
-        enum.Trigger.TriggerVisualState.Primed: primed
-        enum.Trigger.TriggerVisualState.Unprimed: complete
   - type: GenericVisualizer
     visuals:
       enum.ConstructionVisuals.Key:
@@ -182,6 +176,10 @@
           wiredCase: { state: wired }
           caseWithTrigger: { state: no-payload }
           grenade: { state: complete }
+      enum.Trigger.TriggerVisuals.VisualState:
+        enum.ConstructionVisuals.Layer:
+          Primed: { state: primed }
+          Unprimed: { state: complete }
   - type: StaticPrice
     price: 25
 

Resources/Prototypes/Entities/Structures/Machines/cloning_machine.yml

@@ -18,6 +18,7 @@
     snapCardinals: true
     layers:
       - state: pod_0
+        map: ["base"]
   - type: Physics
     bodyType: Static
   - type: Fixtures
@@ -65,15 +66,14 @@
   - type: ApcPowerReceiver
     powerLoad: 200 #Receives most of its power from the console
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-      - type: GenericEnumVisualizer
+      enum.CloningPodVisuals.Status:
-        key: enum.CloningPodVisuals.Status
+        base:
-        layer: 0
+          Cloning: { state: pod_1 }
-        states:
+          NoMind: { state: pod_e }
-          enum.CloningPodStatus.Cloning: pod_1
+          Gore: { state: pod_g }
-          enum.CloningPodStatus.NoMind: pod_e
+          Idle: { state: pod_0 }
-          enum.CloningPodStatus.Gore: pod_g
-          enum.CloningPodStatus.Idle: pod_0
   - type: Climbable
   - type: StaticPrice
     price: 1000

Resources/Prototypes/Entities/Structures/meat_spike.yml

@@ -10,6 +10,9 @@
     # temp to make clickmask work
     sprite: Structures/meat_spike.rsi
     state: spike
+    layers:
+    - state: spike
+      map: ["base"]
   - type: Damageable
     damageContainer: Inorganic
     damageModifierSet: Metallic
@@ -41,13 +44,12 @@
   - type: Anchorable
   - type: Pullable
   - type: Appearance
+  - type: GenericVisualizer
     visuals:
-      - type: GenericEnumVisualizer
+      enum.KitchenSpikeVisuals.Status:
-        key: enum.KitchenSpikeVisuals.Status
+        base:
-        layer: 0
+          Empty: { state: spike }
-        states:
+          Bloody: { state: spikebloody }
-          enum.KitchenSpikeStatus.Empty: spike
-          enum.KitchenSpikeStatus.Bloody: spikebloody
   - type: Construction
     graph: MeatSpike
     node: MeatSpike