Misc replay related changes (#17102)

Content.Server/Chat/Managers/ChatManager.cs

@@ -247,8 +247,14 @@ namespace Content.Server.Chat.Managers
             var msg = new ChatMessage(channel, message, wrappedMessage, source, hideChat, colorOverride, audioPath, audioVolume);
             _netManager.ServerSendMessage(new MsgChatMessage() { Message = msg }, client);
 
-            if (recordReplay)
+            if (!recordReplay)
+                return;
+
+            if ((channel & ChatChannel.AdminRelated) == 0 ||
+                _configurationManager.GetCVar(CCVars.ReplayRecordAdminChat))
+            {
                 _replay.QueueReplayMessage(msg);
+            }
         }
 
         public void ChatMessageToMany(ChatChannel channel, string message, string wrappedMessage, EntityUid source, bool hideChat, bool recordReplay, IEnumerable<INetChannel> clients, Color? colorOverride = null, string? audioPath = null, float audioVolume = 0)
@@ -259,8 +265,14 @@ namespace Content.Server.Chat.Managers
             var msg = new ChatMessage(channel, message, wrappedMessage, source, hideChat, colorOverride, audioPath, audioVolume);
             _netManager.ServerSendToMany(new MsgChatMessage() { Message = msg }, clients);
 
-            if (recordReplay)
+            if (!recordReplay)
+                return;
+
+            if ((channel & ChatChannel.AdminRelated) == 0 ||
+                _configurationManager.GetCVar(CCVars.ReplayRecordAdminChat))
+            {
                 _replay.QueueReplayMessage(msg);
+            }
         }
 
         public void ChatMessageToManyFiltered(Filter filter, ChatChannel channel, string message, string wrappedMessage, EntityUid source,
@@ -283,8 +295,14 @@ namespace Content.Server.Chat.Managers
             var msg = new ChatMessage(channel, message, wrappedMessage, source, hideChat, colorOverride, audioPath, audioVolume);
             _netManager.ServerSendToAll(new MsgChatMessage() { Message = msg });
 
-            if (recordReplay)
+            if (!recordReplay)
+                return;
+
+            if ((channel & ChatChannel.AdminRelated) == 0 ||
+                _configurationManager.GetCVar(CCVars.ReplayRecordAdminChat))
+            {
                 _replay.QueueReplayMessage(msg);
+            }
         }
 
         public bool MessageCharacterLimit(IPlayerSession? player, string message)

Content.Server/GameTicking/GameTicker.cs

@@ -28,6 +28,9 @@ using Robust.Shared.Map;
 using Robust.Shared.Network;
 using Robust.Shared.Prototypes;
 using Robust.Shared.Random;
+using Robust.Shared.Replays;
+using Robust.Shared.Serialization.Markdown.Mapping;
+using Robust.Shared.Serialization.Markdown.Value;
 using Robust.Shared.Timing;
 using Robust.Shared.Utility;
 
@@ -65,7 +68,7 @@ namespace Content.Server.GameTicking
             DebugTools.Assert(_prototypeManager.Index<JobPrototype>(FallbackOverflowJob).Name == FallbackOverflowJobName,
                 "Overflow role does not have the correct name!");
             InitializeGameRules();
-
+            _replay.OnRecordingStarted += OnRecordingStart;
             _initialized = true;
         }
 
@@ -85,6 +88,12 @@ namespace Content.Server.GameTicking
             base.Shutdown();
 
             ShutdownGameRules();
+            _replay.OnRecordingStarted -= OnRecordingStart;
+        }
+
+        private void OnRecordingStart((MappingDataNode, List<object>) data)
+        {
+            data.Item1["roundId"] = new ValueDataNode(RoundId.ToString());
         }
 
         private void SendServerMessage(string message)
@@ -124,5 +133,6 @@ namespace Content.Server.GameTicking
         [Dependency] private readonly ServerUpdateManager _serverUpdates = default!;
         [Dependency] private readonly PlayTimeTrackingSystem _playTimeTrackings = default!;
         [Dependency] private readonly UserDbDataManager _userDb = default!;
+        [Dependency] private readonly IReplayRecordingManager _replay = default!;
     }
 }

Content.Server/Stunnable/Systems/StunOnCollideSystem.cs

@@ -25,12 +25,6 @@ namespace Content.Server.Stunnable
 
             if (EntityManager.TryGetComponent<StatusEffectsComponent>(target, out var status))
             {
-                StandingStateComponent? standingState = null;
-                AppearanceComponent? appearance = null;
-
-                // Let the actual methods log errors for these.
-                Resolve(target, ref standingState, ref appearance, false);
-
                 _stunSystem.TryStun(target, TimeSpan.FromSeconds(component.StunAmount), true, status);
 
                 _stunSystem.TryKnockdown(target, TimeSpan.FromSeconds(component.KnockdownAmount), true,