Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Rider static analysis (#433)

Browse Source 
* Non-accessed local variable

* Merge cast and type checks.

* StringComparison.Ordinal added for better culture support

* Supposed code improvement in launcher. Remove unused code.

* Update ExplosionHelper.cs

Unintentional change.

* Optimized Import

* Add Robust.Shared.Utility import where it was deleted

* Other random suggestion

* Improve my comment
This commit is contained in:
ZelteHonor
2019-11-13 17:37:46 -05:00
committed by Pieter-Jan Briers
parent 62b31eee00
commit b2e2aef78d
138 changed files with 190 additions and 400 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Content.Server/GameObjects/Components/Damage/BreakableComponent.cs
View File

@@ -1,5 +1,4 @@
using System;
using System.Collections.Generic;
using System.Collections.Generic;
using Content.Server.GameObjects.EntitySystems;
using Content.Server.Interfaces;
using Content.Shared.GameObjects;
@@ -7,7 +6,6 @@ using Robust.Shared.GameObjects;
using Robust.Shared.Interfaces.GameObjects;
using Robust.Shared.Interfaces.Random;
using Robust.Shared.IoC;
using Robust.Shared.Maths;
using Robust.Shared.Random;
using Robust.Shared.Serialization;

6
Content.Server/GameObjects/Components/Damage/DamageThreshold.cs
View File

@@ -1,5 +1,5 @@
using Content.Shared.GameObjects;
using System;
using System;
using Content.Shared.GameObjects;
namespace Content.Server.GameObjects
{
@@ -21,7 +21,7 @@ namespace Content.Server.GameObjects
public override bool Equals(Object obj)
{
return obj is DamageThreshold && this == (DamageThreshold)obj;
return obj is DamageThreshold threshold && this == threshold;
}
public override int GetHashCode()
{

3
Content.Server/GameObjects/Components/Damage/DamageableComponent.cs
View File

@@ -4,14 +4,13 @@ using System.Linq;
using Content.Server.Interfaces;
using Content.Server.Interfaces.GameObjects;
using Content.Shared.GameObjects;
using Robust.Server.Console;
using Robust.Server.Interfaces.GameObjects;
using Robust.Shared.GameObjects;
using Robust.Shared.Interfaces.GameObjects;
using Robust.Shared.IoC;
using Robust.Shared.Localization;
using Robust.Shared.Serialization;
using Robust.Shared.ViewVariables;
using Robust.Server.Console;
namespace Content.Server.GameObjects
{

4
Content.Server/GameObjects/Components/Damage/DestructibleComponent.cs
View File

@@ -1,5 +1,4 @@
using System;
using System.Collections.Generic;
using System.Collections.Generic;
using Content.Server.GameObjects.EntitySystems;
using Content.Server.Interfaces;
using Content.Shared.GameObjects;
@@ -7,7 +6,6 @@ using Robust.Shared.GameObjects;
using Robust.Shared.Interfaces.GameObjects;
using Robust.Shared.Interfaces.Random;
using Robust.Shared.IoC;
using Robust.Shared.Maths;
using Robust.Shared.Random;
using Robust.Shared.Serialization;
using Robust.Shared.ViewVariables;

4
Content.Server/GameObjects/Components/Damage/ResistanceSet.cs
View File

@@ -1,6 +1,6 @@
using Content.Shared.GameObjects;
using System;
using System;
using System.Collections.Generic;
using Content.Shared.GameObjects;
namespace Content.Server.GameObjects
{