From baf49040600398c545dbdd6340e349a1d0be7c50 Mon Sep 17 00:00:00 2001
From: 20kdc <asdd2808@gmail.com>
Date: Fri, 12 Nov 2021 04:23:06 +0000
Subject: [PATCH] Ghost roles: rule stuff (#5252)

* Ghost roles: Make the rules harder to miss

* Fix markup handling in ghost rule rules

* Apply suggestions
---
 .../Ghost/Roles/UI/GhostRoleRulesWindow.xaml  |  1 +
 .../Roles/UI/GhostRoleRulesWindow.xaml.cs     | 20 ++++++++++++++++++-
 Resources/Locale/en-US/ghost/ghost-gui.ftl    |  2 ++
 .../ghost/roles/ghost-role-component.ftl      |  2 ++
 4 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml b/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml
index 432f1e1bda..786dd982a1 100644
--- a/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml
+++ b/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml
@@ -5,6 +5,7 @@
         <RichTextLabel Name="Title" VerticalExpand="True"/>
         <Button Name="RequestButton"
                 Text="{Loc 'ghost-roles-window-request-role-button'}"
+                Disabled="True"
                 TextAlign="Center"
                 HorizontalAlignment="Center"
                 VerticalAlignment="Center" />
diff --git a/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml.cs b/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml.cs
index decc06fda8..307c47dded 100644
--- a/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml.cs
+++ b/Content.Client/Ghost/Roles/UI/GhostRoleRulesWindow.xaml.cs
@@ -4,17 +4,35 @@ using Robust.Client.AutoGenerated;
 using Robust.Client.UserInterface.Controls;
 using Robust.Client.UserInterface.CustomControls;
 using Robust.Client.UserInterface.XAML;
+using Robust.Shared.Localization;
+using Robust.Shared.Timing;
+using Robust.Shared.Utility;
 
 namespace Content.Client.Ghost.Roles.UI
 {
     [GenerateTypedNameReferences]
     public partial class GhostRoleRulesWindow : SS14Window
     {
+        private float _timer = 5.0f;
         public GhostRoleRulesWindow(string rules, Action<BaseButton.ButtonEventArgs> requestAction)
         {
             RobustXamlLoader.Load(this);
-            Title.SetMessage(rules);
+            Title.SetMessage(FormattedMessage.FromMarkupPermissive(rules + "\n" + Loc.GetString("ghost-roles-window-rules-footer")));
             RequestButton.OnPressed += requestAction;
         }
+
+        protected override void FrameUpdate(FrameEventArgs args)
+        {
+            base.FrameUpdate(args);
+            if (!RequestButton.Disabled) return;
+            if (_timer > 0.0)
+            {
+                _timer -= args.DeltaSeconds;
+            }
+            else
+            {
+                RequestButton.Disabled = false;
+            }
+        }
     }
 }
diff --git a/Resources/Locale/en-US/ghost/ghost-gui.ftl b/Resources/Locale/en-US/ghost/ghost-gui.ftl
index 468867c284..246ff6538a 100644
--- a/Resources/Locale/en-US/ghost/ghost-gui.ftl
+++ b/Resources/Locale/en-US/ghost/ghost-gui.ftl
@@ -8,3 +8,5 @@ ghost-target-window-current-button = Warp: {$name}
 ghost-roles-window-title = Ghost Roles
 ghost-roles-window-request-role-button = Request
 ghost-roles-window-no-roles-available-label = There are currently no available ghost roles.
+ghost-roles-window-rules-footer = The button will enable after 5 seconds (this delay is to make sure you read the rules).
+
diff --git a/Resources/Locale/en-US/ghost/roles/ghost-role-component.ftl b/Resources/Locale/en-US/ghost/roles/ghost-role-component.ftl
index 609d5eacd7..48c63d85d8 100644
--- a/Resources/Locale/en-US/ghost/roles/ghost-role-component.ftl
+++ b/Resources/Locale/en-US/ghost/roles/ghost-role-component.ftl
@@ -1,3 +1,5 @@
 # also used in MakeGhostRuleWindow and MakeGhostRoleCommand
 ghost-role-component-default-rules = You don't remember any of your previous life unless an administrator tells you otherwise.
+                                     You are allowed to remember knowledge about the game in general, such as how to cook, how to use objects, etc.
+                                     You are absolutely [color=red]NOT[/color] allowed to remember, say, the name, appearance, etc. of your previous character.