Cinka/OldThink
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Disable warnings that would be refactored anyway (#5047)

Browse Source
This commit is contained in:
Visne
2021-10-27 18:10:40 +02:00
committed by GitHub
parent bd4ab219e3
commit c67160ae19
93 changed files with 302 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Content.Shared/Actions/Components/SharedActionsComponent.cs
View File

@@ -465,7 +465,9 @@ namespace Content.Shared.Actions.Components
}
[Serializable, NetSerializable]
#pragma warning disable 618
public abstract class BasePerformActionMessage : ComponentMessage
#pragma warning restore 618
{
public abstract BehaviorType BehaviorType { get; }
}

18
Content.Shared/Actions/IActionAttempt.cs
View File

@@ -19,10 +19,12 @@ namespace Content.Shared.Actions
/// Action Prototype attempting to be performed
/// </summary>
BaseActionPrototype Action { get; }
#pragma warning disable 618
ComponentMessage PerformInstantActionMessage();
ComponentMessage PerformToggleActionMessage(bool on);
ComponentMessage PerformTargetPointActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args);
ComponentMessage PerformTargetEntityActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args);
#pragma warning restore 618
/// <summary>
/// Tries to get the action state for this action from the actionsComponent, returning
/// true if found.
@@ -99,12 +101,16 @@ namespace Content.Shared.Actions
target));
}
#pragma warning disable 618
public ComponentMessage PerformInstantActionMessage()
#pragma warning restore 618
{
return new PerformInstantActionMessage(_action.ActionType);
}
#pragma warning disable 618
public ComponentMessage PerformToggleActionMessage(bool toggleOn)
#pragma warning restore 618
{
if (toggleOn)
{
@@ -113,12 +119,16 @@ namespace Content.Shared.Actions
return new PerformToggleOffActionMessage(_action.ActionType);
}
#pragma warning disable 618
public ComponentMessage PerformTargetPointActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args)
#pragma warning restore 618
{
return new PerformTargetPointActionMessage(_action.ActionType, args.Coordinates);
}
#pragma warning disable 618
public ComponentMessage PerformTargetEntityActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args)
#pragma warning restore 618
{
return new PerformTargetEntityActionMessage(_action.ActionType, args.EntityUid);
}
@@ -176,12 +186,16 @@ namespace Content.Shared.Actions
_itemActions.Toggle(_action.ActionType, toggleOn);
}
#pragma warning disable 618
public ComponentMessage PerformInstantActionMessage()
#pragma warning restore 618
{
return new PerformInstantItemActionMessage(_action.ActionType, _item.Uid);
}
#pragma warning disable 618
public ComponentMessage PerformToggleActionMessage(bool toggleOn)
#pragma warning restore 618
{
if (toggleOn)
{
@@ -190,12 +204,16 @@ namespace Content.Shared.Actions
return new PerformToggleOffItemActionMessage(_action.ActionType, _item.Uid);
}
#pragma warning disable 618
public ComponentMessage PerformTargetPointActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args)
#pragma warning restore 618
{
return new PerformTargetPointItemActionMessage(_action.ActionType, _item.Uid, args.Coordinates);
}
#pragma warning disable 618
public ComponentMessage PerformTargetEntityActionMessage(PointerInputCmdHandler.PointerInputCmdArgs args)
#pragma warning restore 618
{
return new PerformTargetEntityItemActionMessage(_action.ActionType, _item.Uid, args.EntityUid);
}

2
Content.Shared/Alert/SharedAlertsComponent.cs
View File

@@ -181,7 +181,9 @@ namespace Content.Shared.Alert
/// A message that calls the click interaction on a alert
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class ClickAlertMessage : ComponentMessage
#pragma warning restore 618
{
public readonly AlertType Type;

2
Content.Shared/Buckle/Components/SharedBuckleComponent.cs
View File

@@ -69,7 +69,9 @@ namespace Content.Shared.Buckle.Components
}
[Serializable, NetSerializable]
#pragma warning disable 618
public abstract class BuckleChangeMessage : ComponentMessage
#pragma warning restore 618
{
/// <summary>
/// Constructs a new instance of <see cref="BuckleChangeMessage"/>

2
Content.Shared/Buckle/Components/SharedStrapComponent.cs
View File

@@ -62,7 +62,9 @@ namespace Content.Shared.Buckle.Components
}
[Serializable, NetSerializable]
#pragma warning disable 618
public abstract class StrapChangeMessage : ComponentMessage
#pragma warning restore 618
{
/// <summary>
/// Constructs a new instance of <see cref="StrapChangeMessage"/>

2
Content.Shared/Camera/SharedCameraRecoilComponent.cs
View File

@@ -14,7 +14,9 @@ namespace Content.Shared.Camera
public abstract void Kick(Vector2 recoil);
[Serializable, NetSerializable]
#pragma warning disable 618
protected class RecoilKickMessage : ComponentMessage
#pragma warning restore 618
{
public readonly Vector2 Recoil;

4
Content.Shared/CharacterInfo/SharedCharacterInfoComponent.cs
View File

@@ -13,7 +13,9 @@ namespace Content.Shared.CharacterInfo
public override string Name => "CharacterInfo";
[Serializable, NetSerializable]
#pragma warning disable 618
protected class RequestCharacterInfoMessage : ComponentMessage
#pragma warning restore 618
{
public RequestCharacterInfoMessage()
{
@@ -22,7 +24,9 @@ namespace Content.Shared.CharacterInfo
}
[Serializable, NetSerializable]
#pragma warning disable 618
protected class CharacterInfoMessage : ComponentMessage
#pragma warning restore 618
{
public readonly Dictionary<string, List<ConditionInfo>> Objectives;
public readonly string JobTitle;

2
Content.Shared/Configurable/SharedConfigurationComponent.cs
View File

@@ -23,7 +23,9 @@ namespace Content.Shared.Configurable
/// <summary>
/// Message sent to other components on this entity when DeviceNetwork configuration updated.
/// </summary>
#pragma warning disable 618
public class ConfigUpdatedComponentMessage : ComponentMessage
#pragma warning restore 618
{
public Dictionary<string, string> Config { get; }

2
Content.Shared/DoAfter/SharedDoAfterComponent.cs
View File

@@ -25,7 +25,9 @@ namespace Content.Shared.DoAfter
}
[Serializable, NetSerializable]
#pragma warning disable 618
public sealed class CancelledDoAfterMessage : ComponentMessage
#pragma warning restore 618
{
public byte ID { get; }

6
Content.Shared/Instruments/SharedInstrumentComponent.cs
View File

@@ -37,7 +37,9 @@ namespace Content.Shared.Instruments
/// This message is sent to the client to completely stop midi input and midi playback.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class InstrumentStopMidiMessage : ComponentMessage
#pragma warning restore 618
{
}
@@ -45,7 +47,9 @@ namespace Content.Shared.Instruments
/// This message is sent to the client to start the synth.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class InstrumentStartMidiMessage : ComponentMessage
#pragma warning restore 618
{
}
@@ -54,7 +58,9 @@ namespace Content.Shared.Instruments
/// This message carries a MidiEvent to be played on clients.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class InstrumentMidiEventMessage : ComponentMessage
#pragma warning restore 618
{
public MidiEvent[] MidiEvent;

2
Content.Shared/Interaction/SharedInteractionSystem.cs
View File

@@ -20,6 +20,8 @@ using Robust.Shared.Physics;
using Robust.Shared.Random;
using Robust.Shared.Serialization;
#pragma warning disable 618
namespace Content.Shared.Interaction
{
/// <summary>

4
Content.Shared/Inventory/SharedInventoryComponent.cs
View File

@@ -60,7 +60,9 @@ namespace Content.Shared.Inventory
}
[Serializable, NetSerializable]
#pragma warning disable 618
public class ClientInventoryMessage : ComponentMessage
#pragma warning restore 618
{
public Slots Inventoryslot;
public ClientInventoryUpdate Updatetype;
@@ -84,7 +86,9 @@ namespace Content.Shared.Inventory
/// Component message for opening the Storage UI of item in Slot
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class OpenSlotStorageUIMessage : ComponentMessage
#pragma warning restore 618
{
public Slots Slot;

2
Content.Shared/MobState/Components/MobStateComponent.cs
View File

@@ -312,7 +312,9 @@ namespace Content.Shared.MobState.Components
state.UpdateState(Owner, threshold);
var message = new MobStateChangedMessage(this, old, state);
#pragma warning disable 618
SendMessage(message);
#pragma warning restore 618
Owner.EntityManager.EventBus.RaiseEvent(EventSource.Local, message);
Dirty();

2
Content.Shared/MobState/MobStateChangedMessage.cs
View File

@@ -3,7 +3,9 @@ using Robust.Shared.GameObjects;
namespace Content.Shared.MobState
{
#pragma warning disable 618
public class MobStateChangedMessage : ComponentMessage
#pragma warning restore 618
{
public MobStateChangedMessage(
IMobStateComponent component,

1
Content.Shared/Preferences/HumanoidCharacterProfile.cs
View File

@@ -349,7 +349,6 @@ namespace Content.Shared.Preferences
string RandomName()
{
if (Sex == null) return "Urist McHands"; // This shouldn't happen
var random = IoCManager.Resolve<IRobustRandom>();
var protoMan = IoCManager.Resolve<IPrototypeManager>();
var firstName = random.Pick(Sex.FirstNames(protoMan).Values);

2
Content.Shared/Singularity/SingularitySoundMessage.cs
View File

@@ -5,7 +5,9 @@ using Robust.Shared.Serialization;
namespace Content.Shared.Singularity
{
[Serializable, NetSerializable]
#pragma warning disable 618
public class SingularitySoundMessage : ComponentMessage
#pragma warning restore 618
{
public bool Start { get; }

12
Content.Shared/Storage/SharedStorageComponent.cs
View File

@@ -74,7 +74,9 @@ namespace Content.Shared.Storage
/// Updates the client component about what entities this storage is holding
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class StorageHeldItemsMessage : ComponentMessage
#pragma warning restore 618
{
public readonly int StorageSizeMax;
public readonly int StorageSizeUsed;
@@ -93,7 +95,9 @@ namespace Content.Shared.Storage
/// Component message for adding an entity to the storage entity.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class InsertEntityMessage : ComponentMessage
#pragma warning restore 618
{
public InsertEntityMessage()
{
@@ -105,7 +109,9 @@ namespace Content.Shared.Storage
/// Component message for displaying an animation of entities flying into a storage entity
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class AnimateInsertingEntitiesMessage : ComponentMessage
#pragma warning restore 618
{
public readonly List<EntityUid> StoredEntities;
public readonly List<EntityCoordinates> EntityPositions;
@@ -121,7 +127,9 @@ namespace Content.Shared.Storage
/// Component message for removing a contained entity from the storage entity
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class RemoveEntityMessage : ComponentMessage
#pragma warning restore 618
{
public EntityUid EntityUid;
@@ -136,7 +144,9 @@ namespace Content.Shared.Storage
/// Component message for opening the storage UI
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class OpenStorageUIMessage : ComponentMessage
#pragma warning restore 618
{
public OpenStorageUIMessage()
{
@@ -149,7 +159,9 @@ namespace Content.Shared.Storage
/// E.g when the player moves too far away from the container.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public class CloseStorageUIMessage : ComponentMessage
#pragma warning restore 618
{
public CloseStorageUIMessage()
{

2
Content.Shared/Weapons/Ranged/Components/SharedRangedWeaponComponent.cs
View File

@@ -32,7 +32,9 @@ namespace Content.Shared.Weapons.Ranged.Components
/// A component message raised when the weapon is fired at a position on the map.
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public sealed class FirePosComponentMessage : ComponentMessage
#pragma warning restore 618
{
/// <summary>
/// If this is not invalid, the target position is relative to the grid.

2
Content.Shared/Weapons/Ranged/MagazineAutoEjectMessage.cs
View File

@@ -8,5 +8,7 @@ namespace Content.Shared.Weapons.Ranged
/// This is sent if the MagazineBarrel AutoEjects the magazine
/// </summary>
[Serializable, NetSerializable]
#pragma warning disable 618
public sealed class MagazineAutoEjectMessage : ComponentMessage {}
#pragma warning restore 618
}