Fix warnings and code cleanup/fixes (#13570)

2023-01-19 03:56:45 +01:00
parent 3ca5a0224b
commit c6d3e4f3bd
265 changed files with 499 additions and 666 deletions
--- a/Content.Server/GameTicking/Rules/SuspicionRuleSystem.cs
+++ b/Content.Server/GameTicking/Rules/SuspicionRuleSystem.cs
@@ -114,7 +114,6 @@ public sealed class SuspicionRuleSystem : GameRuleSystem
        {
            _chatManager.DispatchServerAnnouncement("No players readied up! Can't start Suspicion.");
            ev.Cancel();
-            return;
        }
    }

@@ -176,8 +175,7 @@ public sealed class SuspicionRuleSystem : GameRuleSystem
            traitors.Add(traitorRole);

            // try to place uplink
-            if (!_uplink.AddUplink(mind.OwnedEntity!.Value, traitorStartingBalance))
-                continue;
+            _uplink.AddUplink(mind.OwnedEntity!.Value, traitorStartingBalance);
        }

        foreach (var player in list)