Fix warnings and code cleanup/fixes (#13570)

Content.Shared/Roles/AntagPrototype.cs

@@ -13,7 +13,7 @@ namespace Content.Shared.Roles
         private string? _description = string.Empty;
 
         [ViewVariables]
-        [IdDataFieldAttribute]
+        [IdDataField]
         public string ID { get; } = default!;
 
         /// <summary>

Content.Shared/Roles/DepartmentPrototype.cs

@@ -7,7 +7,7 @@ namespace Content.Shared.Roles;
 [Prototype("department")]
 public sealed class DepartmentPrototype : IPrototype
 {
-    [IdDataFieldAttribute] public string ID { get; } = default!;
+    [IdDataField] public string ID { get; } = default!;
 
     /// <summary>
     ///     A description string to display in the character menu as an explanation of the department's function.

Content.Shared/Roles/JobPrototype.cs

@@ -13,7 +13,7 @@ namespace Content.Shared.Roles
     public sealed class JobPrototype : IPrototype
     {
         [ViewVariables]
-        [IdDataFieldAttribute]
+        [IdDataField]
         public string ID { get; } = default!;
 
         [DataField("playTimeTracker", required: true, customTypeSerializer: typeof(PrototypeIdSerializer<PlayTimeTrackerPrototype>))]

Content.Shared/Roles/StartingGearPrototype.cs

@@ -30,7 +30,7 @@ namespace Content.Shared.Roles
         private Dictionary<string, string> _inHand = new(0);
 
         [ViewVariables]
-        [IdDataFieldAttribute]
+        [IdDataField]
         public string ID { get; } = string.Empty;
 
         public string GetGear(string slot, HumanoidCharacterProfile? profile)