From ce0b73ef6299536d2c8831bd067754feb4df7701 Mon Sep 17 00:00:00 2001
From: Alex Evgrashin <aevgrashin@yandex.ru>
Date: Fri, 15 Oct 2021 13:49:59 +0300
Subject: [PATCH] Description for Uplink UI (and preset uplinks) (#4870)

* testing decription textlabel

* Move uplink listing to a new menu

* Add search bar

* Added description

* Added radio uplink

* Added preset uplinks

* Minor fix

* Fixed comma
---
 .../Traitor/Uplink/UplinkListingControl.xaml  |  14 +++
 .../Uplink/UplinkListingControl.xaml.cs       |  25 ++++++
 Content.Client/Traitor/Uplink/UplinkMenu.xaml |  21 +++--
 .../Traitor/Uplink/UplinkMenu.xaml.cs         |  82 ++----------------
 .../Traitor/Uplink/UplinkComponent.cs         |  15 ++++
 Content.Server/Traitor/Uplink/UplinkSystem.cs |  30 +++++++
 .../en-US/traitor/uplink/uplink-component.ftl |   6 +-
 .../Entities/Objects/Specific/syndicate.yml   |  49 ++++++++++-
 .../Devices/communication.rsi/meta.json       |  11 +++
 .../old-radio-inhand-left.png                 | Bin 0 -> 215 bytes
 .../old-radio-inhand-right.png                | Bin 0 -> 243 bytes
 .../Devices/communication.rsi/old-radio.png   | Bin 0 -> 401 bytes
 12 files changed, 167 insertions(+), 86 deletions(-)
 create mode 100644 Content.Client/Traitor/Uplink/UplinkListingControl.xaml
 create mode 100644 Content.Client/Traitor/Uplink/UplinkListingControl.xaml.cs
 create mode 100644 Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-left.png
 create mode 100644 Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-right.png
 create mode 100644 Resources/Textures/Objects/Devices/communication.rsi/old-radio.png

diff --git a/Content.Client/Traitor/Uplink/UplinkListingControl.xaml b/Content.Client/Traitor/Uplink/UplinkListingControl.xaml
new file mode 100644
index 0000000000..46fa1062d7
--- /dev/null
+++ b/Content.Client/Traitor/Uplink/UplinkListingControl.xaml
@@ -0,0 +1,14 @@
+<Control xmlns="https://spacestation14.io">
+    <BoxContainer Orientation="Vertical"
+                  Margin="8 8 8 8">
+        <BoxContainer Orientation="Horizontal">
+            <Label Name="UplinkItemName"
+                   HorizontalExpand="True"/>
+            <Button Name="UplinkItemBuyButtonProtected"
+                    HorizontalAlignment="Right"
+                    MinWidth="64"/>
+        </BoxContainer>
+        <PanelContainer StyleClasses="HighDivider" />
+        <RichTextLabel Name="UplinkItemDescription" />
+    </BoxContainer>
+</Control>
diff --git a/Content.Client/Traitor/Uplink/UplinkListingControl.xaml.cs b/Content.Client/Traitor/Uplink/UplinkListingControl.xaml.cs
new file mode 100644
index 0000000000..32d5468bc3
--- /dev/null
+++ b/Content.Client/Traitor/Uplink/UplinkListingControl.xaml.cs
@@ -0,0 +1,25 @@
+using Robust.Client.AutoGenerated;
+using Robust.Client.UserInterface;
+using Robust.Client.UserInterface.Controls;
+using Robust.Client.UserInterface.XAML;
+using Robust.Shared.Maths;
+
+namespace Content.Client.Traitor.Uplink
+{
+    [GenerateTypedNameReferences]
+    public partial class UplinkListingControl : Control
+    {
+        public Button UplinkItemBuyButton => UplinkItemBuyButtonProtected;
+
+        public UplinkListingControl(string itemName, string itemDescription, int itemPrice, bool canBuy)
+        {
+            RobustXamlLoader.Load(this);
+
+            UplinkItemName.Text = itemName;
+            UplinkItemDescription.SetMessage(itemDescription);
+
+            UplinkItemBuyButtonProtected.Text = $"{itemPrice} TC";
+            UplinkItemBuyButtonProtected.Disabled = !canBuy;
+        }
+    }
+}
diff --git a/Content.Client/Traitor/Uplink/UplinkMenu.xaml b/Content.Client/Traitor/Uplink/UplinkMenu.xaml
index 1694bc568c..43c6610f83 100644
--- a/Content.Client/Traitor/Uplink/UplinkMenu.xaml
+++ b/Content.Client/Traitor/Uplink/UplinkMenu.xaml
@@ -1,18 +1,22 @@
-<SS14Window xmlns="https://spacestation14.io"
+<SS14Window xmlns="https://spacestation14.io"
             xmlns:gfx="clr-namespace:Robust.Client.Graphics;assembly=Robust.Client"
-            Title="{Loc 'pda-bound-user-interface-uplink-tab-title'}"
+            Title="{Loc 'uplink-user-interface-title'}"
             MinSize="512 512"
             SetSize="512 512">
     <BoxContainer Orientation="Vertical">
         <BoxContainer Orientation="Vertical"
                       VerticalExpand="True">
-            <RichTextLabel Name="BalanceInfoProtected"
-                           HorizontalAlignment="Center" />
+            <BoxContainer Orientation="Horizontal"
+                          Margin="4 4 4 4">
+                <RichTextLabel Name="BalanceInfoProtected"
+                               HorizontalExpand="True"
+                               HorizontalAlignment="Left" />
+            </BoxContainer>
             <PanelContainer VerticalExpand="True">
                 <PanelContainer.PanelOverride>
                     <gfx:StyleBoxFlat BackgroundColor="#000000FF" />
                 </PanelContainer.PanelOverride>
-                <SplitContainer Orientation="Horizontal"
+                <BoxContainer Orientation="Horizontal"
                                 VerticalExpand="True">
                     <PanelContainer VerticalExpand="True">
                         <PanelContainer.PanelOverride>
@@ -23,20 +27,21 @@
                             <!-- Category buttons are added here by code -->
                         </BoxContainer>
                     </PanelContainer>
-                    <ScrollContainer HorizontalExpand="True"
+                    <ScrollContainer Name="UplinkListingsScroll"
+                                     HorizontalExpand="True"
                                      VerticalExpand="True"
                                      SizeFlagsStretchRatio="2"
+                                     HScrollEnabled="False"
                                      MinSize="100 256">
                         <BoxContainer Name="UplinkListingsContainer"
                                       Orientation="Vertical"
-                                      HorizontalExpand="True"
                                       VerticalExpand="True"
                                       SizeFlagsStretchRatio="2"
                                       MinSize="100 256">
                             <!-- Listings are added here by code -->
                         </BoxContainer>
                     </ScrollContainer>
-                </SplitContainer>
+                </BoxContainer>
             </PanelContainer>
         </BoxContainer>
     </BoxContainer>
diff --git a/Content.Client/Traitor/Uplink/UplinkMenu.xaml.cs b/Content.Client/Traitor/Uplink/UplinkMenu.xaml.cs
index 5908c3efa1..f39644feff 100644
--- a/Content.Client/Traitor/Uplink/UplinkMenu.xaml.cs
+++ b/Content.Client/Traitor/Uplink/UplinkMenu.xaml.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using Content.Shared.PDA;
 using Content.Shared.Traitor.Uplink;
 using Robust.Client.AutoGenerated;
@@ -58,71 +58,17 @@ namespace Content.Client.Traitor.Uplink
             {
                 return;
             }
-            var weightedColor = listing.Price switch
-            {
-                <= 0 => Color.Gray,
-                <= 5 => Color.Green,
-                <= 10 => Color.Yellow,
-                <= 20 => Color.Orange,
-                <= 50 => Color.Purple,
-                _ => Color.Gray
-            };
-            var itemLabel = new Label
-            {
-                Text = listing.ListingName == string.Empty ? prototype.Name : listing.ListingName,
-                ToolTip = listing.Description == string.Empty ? prototype.Description : listing.Description,
-                HorizontalExpand = true,
-                Modulate = _loggedInUplinkAccount?.DataBalance >= listing.Price
-                    ? Color.White
-                    : Color.Gray.WithAlpha(0.30f)
-            };
 
-            var priceLabel = new Label
-            {
-                Text = $"{listing.Price} TC",
-                HorizontalAlignment = HAlignment.Right,
-                Modulate = _loggedInUplinkAccount?.DataBalance >= listing.Price
-                    ? weightedColor
-                    : Color.Gray.WithAlpha(0.30f)
-            };
+            var listingName = listing.ListingName == string.Empty ? prototype.Name : listing.ListingName;
+            var listingDesc = listing.Description == string.Empty ? prototype.Description : listing.Description;
+            var listingPrice = listing.Price;
+            var canBuy = _loggedInUplinkAccount?.DataBalance >= listing.Price;
 
-            //Padding for the price lable.
-            var pricePadding = new BoxContainer
-            {
-                Orientation = BoxContainer.LayoutOrientation.Horizontal,
-                MinSize = (32, 1),
-            };
+            var newListing = new UplinkListingControl(listingName, listingDesc, listingPrice, canBuy);
+            newListing.UplinkItemBuyButton.OnButtonDown += args
+                => OnListingButtonPressed?.Invoke(args, listing);
 
-            //Contains the name of the item and its price. Used for spacing item name and price.
-            var listingButtonHbox = new BoxContainer
-            {
-                Orientation = BoxContainer.LayoutOrientation.Horizontal,
-                Children =
-                {
-                    itemLabel,
-                    priceLabel,
-                    pricePadding
-                }
-            };
-
-            var listingButtonPanelContainer = new PanelContainer
-            {
-                Children =
-                {
-                    listingButtonHbox
-                }
-            };
-
-            var pdaUplinkListingButton = new PDAUplinkItemButton(listing)
-            {
-                Children =
-                {
-                    listingButtonPanelContainer
-                }
-            };
-            pdaUplinkListingButton.OnPressed += args
-                => OnListingButtonPressed?.Invoke(args, pdaUplinkListingButton.ButtonListing);
-            UplinkListingsContainer.AddChild(pdaUplinkListingButton);
+            UplinkListingsContainer.AddChild(newListing);
         }
 
         public void ClearListings()
@@ -148,16 +94,6 @@ namespace Content.Client.Traitor.Uplink
             }
         }
 
-        private sealed class PDAUplinkItemButton : ContainerButton
-        {
-            public PDAUplinkItemButton(UplinkListingData data)
-            {
-                ButtonListing = data;
-            }
-
-            public UplinkListingData ButtonListing { get; }
-        }
-
         private sealed class PDAUplinkCategoryButton : Button
         {
             public UplinkCategory ButtonCategory;
diff --git a/Content.Server/Traitor/Uplink/UplinkComponent.cs b/Content.Server/Traitor/Uplink/UplinkComponent.cs
index b686abb158..c189e415ea 100644
--- a/Content.Server/Traitor/Uplink/UplinkComponent.cs
+++ b/Content.Server/Traitor/Uplink/UplinkComponent.cs
@@ -3,6 +3,7 @@ using Content.Shared.Traitor.Uplink;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
+using System;
 
 namespace Content.Server.Traitor.Uplink.Components
 {
@@ -19,6 +20,20 @@ namespace Content.Server.Traitor.Uplink.Components
         [DataField("insufficientFundsSound")]
         public SoundSpecifier InsufficientFundsSound  = new SoundPathSpecifier("/Audio/Effects/error.ogg");
 
+        [DataField("activatesInHands")]
+        public bool ActivatesInHands = false;
+
+        [DataField("presetInfo")]
+        public PresetUplinkInfo? PresetInfo = null;
+
         [ViewVariables] public UplinkAccount? UplinkAccount;
+
+        [Serializable]
+        [DataDefinition]
+        public class PresetUplinkInfo
+        {
+            [DataField("balance")]
+            public int StartingBalance;
+        }
     }
 }
diff --git a/Content.Server/Traitor/Uplink/UplinkSystem.cs b/Content.Server/Traitor/Uplink/UplinkSystem.cs
index c0e028cc2a..9f6e9517f6 100644
--- a/Content.Server/Traitor/Uplink/UplinkSystem.cs
+++ b/Content.Server/Traitor/Uplink/UplinkSystem.cs
@@ -1,10 +1,12 @@
 using Content.Server.Hands.Components;
 using Content.Server.Inventory.Components;
 using Content.Server.Items;
+using Content.Server.Mind.Components;
 using Content.Server.PDA;
 using Content.Server.Traitor.Uplink.Account;
 using Content.Server.Traitor.Uplink.Components;
 using Content.Server.UserInterface;
+using Content.Shared.Interaction;
 using Content.Shared.Traitor.Uplink;
 using Robust.Server.GameObjects;
 using Robust.Server.Player;
@@ -31,6 +33,7 @@ namespace Content.Server.Traitor.Uplink
 
             SubscribeLocalEvent<UplinkComponent, ComponentInit>(OnInit);
             SubscribeLocalEvent<UplinkComponent, ComponentRemove>(OnRemove);
+            SubscribeLocalEvent<UplinkComponent, UseInHandEvent>(OnUseHand);
             SubscribeLocalEvent<UplinkComponent, UplinkBuyListingMessage>(OnBuy);
             SubscribeLocalEvent<UplinkComponent, UplinkRequestUpdateInterfaceMessage>(OnRequestUpdateUI);
 
@@ -51,6 +54,15 @@ namespace Content.Server.Traitor.Uplink
         private void OnInit(EntityUid uid, UplinkComponent component, ComponentInit args)
         {
             RaiseLocalEvent(uid, new UplinkInitEvent(component));
+
+            // if component has a preset info (probably spawn by admin)
+            // create a new account and register it for this uplink
+            if (component.PresetInfo != null)
+            {
+                var account = new UplinkAccount(component.PresetInfo.StartingBalance);
+                _accounts.AddNewAccount(account);
+                SetAccount(component, account);
+            }
         }
 
         private void OnRemove(EntityUid uid, UplinkComponent component, ComponentRemove args)
@@ -58,6 +70,24 @@ namespace Content.Server.Traitor.Uplink
             RaiseLocalEvent(uid, new UplinkRemovedEvent());
         }
 
+        private void OnUseHand(EntityUid uid, UplinkComponent component, UseInHandEvent args)
+        {
+            if (args.Handled)
+                return;
+
+            // check if uplinks activates directly or use some proxy, like a PDA
+            if (!component.ActivatesInHands)
+                return;
+            if (component.UplinkAccount == null)
+                return;
+
+            if (!EntityManager.TryGetComponent(args.User.Uid, out ActorComponent? actor))
+                return;
+
+            ToggleUplinkUI(component, actor.PlayerSession);
+            args.Handled = true;
+        }
+
         private void OnBalanceChangedBroadcast(UplinkAccountBalanceChanged ev)
         {
             foreach (var uplink in EntityManager.EntityQuery<UplinkComponent>())
diff --git a/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl b/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
index 61be32ed66..b02847b903 100644
--- a/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
+++ b/Resources/Locale/en-US/traitor/uplink/uplink-component.ftl
@@ -1,3 +1,7 @@
 uplink-bound-user-interface-insufficient-funds-popup = Insufficient funds!
 
-uplink-bound-user-interface-tc-balance-popup = TC Balance: [color={$weightedColor}]{$balance}[/color]
\ No newline at end of file
+uplink-bound-user-interface-tc-balance-popup = TC Balance: [color={$weightedColor}]{$balance}[/color]
+
+uplink-user-interface-title = Uplink
+
+uplink-user-interface-search-label = Search
\ No newline at end of file
diff --git a/Resources/Prototypes/Entities/Objects/Specific/syndicate.yml b/Resources/Prototypes/Entities/Objects/Specific/syndicate.yml
index 1738695b6f..485e213e88 100644
--- a/Resources/Prototypes/Entities/Objects/Specific/syndicate.yml
+++ b/Resources/Prototypes/Entities/Objects/Specific/syndicate.yml
@@ -2,7 +2,7 @@
   name: telecrystal
   parent: BaseItem
   id: Telecrystal
-  suffix: Twenty
+  suffix: 20 TC
   description: It seems to be pulsing with suspiciously enticing energies.
   components:
   - type: Sprite
@@ -20,7 +20,7 @@
 - type: entity
   parent: Telecrystal
   id: Telecrystal1
-  suffix: Single
+  suffix: 1 TC
   components:
   - type: Stack
     count: 1
@@ -28,7 +28,7 @@
 - type: entity
   parent: Telecrystal
   id: Telecrystal5
-  suffix: Five
+  suffix: 5 TC
   components:
   - type: Stack
     count: 5
@@ -36,7 +36,48 @@
 - type: entity
   parent: Telecrystal
   id: Telecrystal10
-  suffix: Ten
+  suffix: 10 TC
   components:
   - type: Stack
     count: 10
+
+# Uplinks
+- type: entity
+  parent: BaseItem
+  id: BaseUplinkRadio
+  name: syndicate uplink
+  description: Suspiciously looking old radio...
+  suffix: Empty
+  components:
+  - type: Sprite
+    sprite: Objects/Devices/communication.rsi
+    layers:
+    - state: old-radio
+    netsync: false
+  - type: Item
+    sprite: Objects/Devices/communication.rsi
+    HeldPrefix: old-radio
+  - type: UserInterface
+    interfaces:
+    - key: enum.UplinkUiKey.Key
+      type: UplinkBoundUserInterface
+  - type: Uplink
+    activatesInHands: true
+
+- type: entity
+  parent: BaseUplinkRadio
+  id: BaseUplinkRadio20TC
+  suffix: 20 TC
+  components:
+  - type: Uplink
+    presetInfo:
+      balance: 20
+
+- type: entity
+  parent: BaseUplinkRadio
+  id: BaseUplinkRadioDebug
+  suffix: Debug
+  components:
+  - type: Uplink
+    presetInfo:
+      balance: 9999
diff --git a/Resources/Textures/Objects/Devices/communication.rsi/meta.json b/Resources/Textures/Objects/Devices/communication.rsi/meta.json
index bf44d0c05b..6b1a633585 100644
--- a/Resources/Textures/Objects/Devices/communication.rsi/meta.json
+++ b/Resources/Textures/Objects/Devices/communication.rsi/meta.json
@@ -65,6 +65,17 @@
     {
       "name": "off-walkietalkie-inhand-left",
       "directions": 4
+    },
+	{
+      "name": "old-radio"
+    },
+    {
+      "name": "old-radio-inhand-left",
+      "directions": 4
+    },
+    {
+      "name": "old-radio-inhand-right",
+      "directions": 4
     }
   ]
 }
diff --git a/Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-left.png b/Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-left.png
new file mode 100644
index 0000000000000000000000000000000000000000..e1cb184a79c41bc605c32bdce52bfbcf245ce02a
GIT binary patch
literal 215
zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=^E_P~Ln`LHy|t0|kbwYeKyyS3
zZ-jz#OJUFk3D(x*iq;OUlZEcPTE5)NxKHPI`M<S{Kuv+~KL4>yx^~S{`^VmO?PqT7
za$)zoJmpi={yX=6YZ{p^W!(OJt4mtf8n%?w<t7g{>O5pWdm=~oB~#qq=_go#`WYA&
z%$oSu;g(&3zw+<K548v8Db;nKHeYZiPobG@%g4J8Ke;zZGcY``k8cgs;Xn2&HVvf5
M)78&qol`;+05O49IRF3v

literal 0
HcmV?d00001

diff --git a/Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-right.png b/Resources/Textures/Objects/Devices/communication.rsi/old-radio-inhand-right.png
new file mode 100644
index 0000000000000000000000000000000000000000..ac3ef8ab79fb3fb4c6b95711cfdc62173f490985
GIT binary patch
literal 243
zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=yF6VSLn`LHy|t0|kbyw!L-tcj
zIR}{JlqA(zy8{C%WHvc#1W2V^xH+xR@8^E2u6gs<?Vb$O1~lcANniGRo}FuEo}bn~
z?{v`gWz5;n4*ohUa7fG3@K|u-vi&!TqGqZ&Oj`HdyKa`>tkko)+uPHG3uZsRYhO2c
z^3|9F%EvaD$X1*JIS&jr)XU|w1)W*F(H}&2aZk86JAz;Oar`Q-4<*JI&MZ_vaQW;3
i^HA0e?d%K;4e|PtD|HXgzpeHHq}kKe&t;ucLK6U7i(c{o

literal 0
HcmV?d00001

diff --git a/Resources/Textures/Objects/Devices/communication.rsi/old-radio.png b/Resources/Textures/Objects/Devices/communication.rsi/old-radio.png
new file mode 100644
index 0000000000000000000000000000000000000000..23315c58a2c7b98d3587c7696fd24ef507461066
GIT binary patch
literal 401
zcmV;C0dD?@P)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F800044Nkl<Zc%1E&
zze~eV5P&~_BiN=!0u?Lh(8WO~7oFS${{ck@r{d@=f;g0blXE8rL7}tI&B;P>vTFwg
z6_IF42&F1$9ZG}9%gZB0>hQklcz5sa<Awu`M$;vgN~P6nhyNi_EEcsyEQvnV!pZ4b
zY2&B++n`sWP-x|HIpyA64;R(s^LeFBL|Up0kK*Tcelr*~+%PRx);3}fzq~jDXoX2g
z1v<PuKM3Dl|C*190by?V^%FC(7};A%!1wAr-qkQn3(s|!n#r~W-aU5r4~2h@cMcf(
zsspgSwT^Au@dbcjxM5ns+lVvD(dM48KJk`>Ogla~JrC`xEYKP5xejB=6acBr94Upr
zvJLdB3WzpPEtja4OVSwra0By8t3f_2jzUSG+3+!~GytZRrrGcTsNGxvkX={~jiZnr
vqRt&K#w}Ty6tC{!xlZUY>iH$qXf&E{dy$VBeQ!MQ00000NkvXXu0mjfVjZ)E

literal 0
HcmV?d00001