Revert "Fix some friend access violations by allowing others access. (#8594) (#8703)

Content.Client/DoAfter/DoAfterComponent.cs

@@ -3,7 +3,7 @@ using Content.Shared.DoAfter;
 
 namespace Content.Client.DoAfter
 {
-    [RegisterComponent, Access(typeof(DoAfterSystem))]
+    [RegisterComponent, Friend(typeof(DoAfterSystem))]
     public sealed class DoAfterComponent : SharedDoAfterComponent
     {
         public readonly Dictionary<byte, ClientDoAfter> DoAfters = new();

Content.Client/Explosion/TriggerOnProximityComponent.cs

@@ -2,5 +2,5 @@ using Content.Shared.Explosion;
 
 namespace Content.Client.Explosion;
 
-[RegisterComponent, Access(typeof(TriggerSystem))]
+[RegisterComponent, Friend(typeof(TriggerSystem))]
 public sealed class TriggerOnProximityComponent : SharedTriggerOnProximityComponent {}

Content.Client/Flash/FlashableComponent.cs

@@ -5,7 +5,7 @@ using Robust.Shared.GameObjects;
 namespace Content.Client.Flash
 {
     [ComponentReference(typeof(SharedFlashableComponent))]
-    [RegisterComponent, Access(typeof(FlashSystem))]
+    [RegisterComponent, Friend(typeof(FlashSystem))]
     public sealed class FlashableComponent : SharedFlashableComponent
     {
     }

Content.Client/Hands/HandsComponent.cs

@@ -4,7 +4,7 @@ namespace Content.Client.Hands
 {
     [RegisterComponent]
     [ComponentReference(typeof(SharedHandsComponent))]
-    [Access(typeof(HandsSystem))]
+    [Friend(typeof(HandsSystem))]
     public sealed class HandsComponent : SharedHandsComponent
     {
         /// <summary>

Content.Client/Inventory/ClientInventoryComponent.cs

@@ -16,7 +16,7 @@ namespace Content.Client.Inventory
     /// </summary>
     [RegisterComponent]
     [ComponentReference(typeof(InventoryComponent))]
-    [Access(typeof(ClientInventorySystem))]
+    [Friend(typeof(ClientInventorySystem))]
     public sealed class ClientInventoryComponent : InventoryComponent
     {
         public Control BottomLeftButtons = default!;
@@ -34,7 +34,6 @@ namespace Content.Client.Inventory
         ///     Data about the current layers that have been added to the players sprite due to the items in each equipment slot.
         /// </summary>
         [ViewVariables]
-        [Access(typeof(ClientInventorySystem), Other = AccessPermissions.ReadWriteExecute)] // FIXME Friends
         public readonly Dictionary<string, HashSet<string>> VisualLayerKeys = new();
 
         public bool AttachedToGameHud;

Content.Client/Light/Components/HandheldLightComponent.cs

@@ -9,7 +9,7 @@ using static Robust.Client.UserInterface.Controls.BoxContainer;
 namespace Content.Client.Light.Components
 {
     [RegisterComponent]
-    [Access(typeof(HandheldLightSystem))]
+    [Friend(typeof(HandheldLightSystem))]
     public sealed class HandheldLightComponent : SharedHandheldLightComponent, IItemStatus
     {
         public byte? Level;

Content.Client/Movement/Components/ClimbableComponent.cs

@@ -3,6 +3,6 @@ using Content.Shared.Climbing;
 namespace Content.Client.Movement.Components;
 
 [RegisterComponent]
-[Access(typeof(ClimbSystem))]
+[Friend(typeof(ClimbSystem))]
 [ComponentReference(typeof(SharedClimbableComponent))]
 public sealed class ClimbableComponent : SharedClimbableComponent { }

Content.Client/Movement/Components/ClimbingComponent.cs

@@ -3,6 +3,6 @@
 namespace Content.Client.Movement.Components;
 
 [RegisterComponent]
-[Access(typeof(ClimbSystem))]
+[Friend(typeof(ClimbSystem))]
 [ComponentReference(typeof(SharedClimbingComponent))]
 public sealed class ClimbingComponent : SharedClimbingComponent { }

Content.Client/Stack/StackComponent.cs

@@ -8,7 +8,7 @@ using Robust.Shared.Timing;
 
 namespace Content.Client.Stack
 {
-    [RegisterComponent, Access(typeof(StackSystem), typeof(StatusControl))]
+    [RegisterComponent, Friend(typeof(StackSystem), typeof(StatusControl))]
     [ComponentReference(typeof(SharedStackComponent))]
     public sealed class StackComponent : SharedStackComponent, IItemStatus
     {

Content.Client/Tools/Components/WelderComponent.cs

@@ -13,7 +13,7 @@ using Robust.Shared.ViewVariables;
 
 namespace Content.Client.Tools.Components
 {
-    [RegisterComponent, Access(typeof(ToolSystem), typeof(StatusControl))]
+    [RegisterComponent, Friend(typeof(ToolSystem), typeof(StatusControl))]
     public sealed class WelderComponent : SharedWelderComponent, IItemStatus
     {
         [ViewVariables(VVAccess.ReadWrite)]

Content.Client/Weapons/Ranged/Components/MagazineVisualsComponent.cs

@@ -5,7 +5,7 @@ namespace Content.Client.Weapons.Ranged.Components;
 /// <summary>
 /// Visualizer for gun mag presence; can change states based on ammo count or toggle visibility entirely.
 /// </summary>
-[RegisterComponent, Access(typeof(GunSystem))]
+[RegisterComponent, Friend(typeof(GunSystem))]
 public sealed class MagazineVisualsComponent : Component
 {
     /// <summary>

Content.Client/Weapons/Ranged/Components/SpentAmmoVisualsComponent.cs

@@ -2,7 +2,7 @@ using Content.Client.Weapons.Ranged.Systems;
 
 namespace Content.Client.Weapons.Ranged.Components;
 
-[RegisterComponent, Access(typeof(GunSystem))]
+[RegisterComponent, Friend(typeof(GunSystem))]
 public sealed class SpentAmmoVisualsComponent : Component
 {
     /// <summary>