ECS damageable (#4529)

* ECS and damage Data

* Comments and newlines

* Added Comments

* Make TryChangeDamageEvent immutable

* Remove SetAllDamage event

Use public SetAllDamage function instead

* Undo destructible mistakes

That was some shit code.

* Rename DamageData to DamageSpecifier

And misc small edits

misc

* Cache trigger prototypes.

* Renaming destructible classes & functions

* Revert "Cache trigger prototypes."

This reverts commit 86bae15ba6616884dba75f552dfdfbe2d1fb6586.

* Replace prototypes with prototype IDs.

* Split damage.yml into individual files

* move get/handle component state to system

* Update HealthChange doc

* Make godmode call Dirty() on damageable component

* Add Initialize() to fix damage test

* Make non-static

* uncache resistance set prototype and trim DamageableComponentState

* Remove unnecessary Dirty() calls during initialization

* RemoveTryChangeDamageEvent

* revert Dirty()

* Fix MobState relying on DamageableComponent.Dirty()

* Fix DisposalUnit Tests.

These were previously failing, but because the async was not await-ed, this never raised the exception.

After I fixed MobState component, this exception stopped happening and instead the assertions started being tested & failing

* Disposal test 2: electric boogaloo

* Fix typos/mistakes

also add comments and fix spacing.

* Use Uids instead of IEntity

* fix merge

* Comments, a merge issue, and making some damage ignore resistances

* Extend DamageSpecifier and use it for DamageableComponent

* fix master merge

* Fix Disposal unit test. Again.

Snapgrids were removed in master

* Execute Exectute

Content.Server/Weapon/Melee/MeleeWeaponSystem.cs

@@ -6,7 +6,7 @@ using Content.Server.Chemistry.Components;
 using Content.Server.Cooldown;
 using Content.Server.Weapon.Melee.Components;
 using Content.Shared.Chemistry.EntitySystems;
-using Content.Shared.Damage.Components;
+using Content.Shared.Damage;
 using Content.Shared.Hands;
 using Content.Shared.Interaction;
 using Content.Shared.Physics;
@@ -25,6 +25,7 @@ namespace Content.Server.Weapon.Melee
     public sealed class MeleeWeaponSystem : EntitySystem
     {
         [Dependency] private IGameTiming _gameTiming = default!;
+        [Dependency] private readonly DamageableSystem _damageableSystem = default!;
         [Dependency] private SolutionContainerSystem _solutionsSystem = default!;
 
         public override void Initialize()
@@ -87,12 +88,7 @@ namespace Content.Server.Weapon.Melee
                 {
                     var targets = new[] { target };
                     SendAnimation(comp.ClickArc, angle, args.User, owner, targets, comp.ClickAttackEffect, false);
-
-                    if (target.TryGetComponent(out IDamageableComponent? damageableComponent))
-                    {
-                        damageableComponent.TryChangeDamage(comp.DamageType, comp.Damage);
-                    }
-
+                    _damageableSystem.TryChangeDamage(target.Uid, comp.Damage);
                     SoundSystem.Play(Filter.Pvs(owner), comp.HitSound.GetSound(), target);
                 }
             }
@@ -133,7 +129,7 @@ namespace Content.Server.Weapon.Melee
                 if (!entity.Transform.IsMapTransform || entity == args.User)
                     continue;
 
-                if (ComponentManager.HasComponent<IDamageableComponent>(entity.Uid))
+                if (ComponentManager.HasComponent<DamageableComponent>(entity.Uid))
                 {
                     hitEntities.Add(entity);
                 }
@@ -157,10 +153,7 @@ namespace Content.Server.Weapon.Melee
 
                 foreach (var entity in hitEntities)
                 {
-                    if (entity.TryGetComponent<IDamageableComponent>(out var damageComponent))
-                    {
-                        damageComponent.TryChangeDamage(comp.DamageType, comp.Damage);
-                    }
+                    _damageableSystem.TryChangeDamage(entity.Uid, comp.Damage);
                 }
             }