[CHANGES PROTOTYPE ID] Clean up lantern (#18526)

- Fix the un-cased proto ID
- Remove the give-away name and description from the Syndicate item
- Remove the same-value inherited fields from PointLight
- Better uplink catalog description

Resources/Locale/en-US/store/uplink-catalog.ftl

@@ -259,7 +259,7 @@ uplink-soap-name = Soap
 uplink-soap-desc = An untrustworthy bar of soap. Smells of fear.
 
 uplink-ultrabright-lantern-name = Extra-Bright Lantern
-uplink-ultrabright-lantern-desc = Blinding.
+uplink-ultrabright-lantern-desc = It can be used to blind people like a flash.
 
 uplink-nocturine-chemistry-bottle-name = Nocturine Bottle
 uplink-nocturine-chemistry-bottle-desc = A chemical that makes it very hard for your target to stand up.

Resources/Prototypes/Catalog/Fills/Lockers/misc.yml

@@ -93,7 +93,7 @@
   components:
     - type: StorageFill
       contents:
-        - id: lantern
+        - id: Lantern
           prob: 0.50
         - id: Wirecutter
           prob: 0.33
@@ -178,7 +178,7 @@
   components:
   - type: StorageFill
     contents:
-        - id: lantern
+        - id: Lantern
           prob: 0.50
         - id: Wirecutter
           prob: 0.33

Resources/Prototypes/Catalog/uplink_catalog.yml

@@ -1105,7 +1105,7 @@
   id: UplinkUltrabrightLantern
   name: uplink-ultrabright-lantern-name
   description: uplink-ultrabright-lantern-desc
-  productEntity: lanternextrabright #why is this item id not capitalized???
+  productEntity: LanternFlash
   cost:
     Telecrystal: 2
   categories:

Resources/Prototypes/Entities/Markers/Spawners/Random/maintenance.yml

@@ -77,7 +77,7 @@
           state: high
     - type: RandomSpawner
       rarePrototypes:
-        - lanternextrabright
+        - LanternFlash
         - PowerCellHigh
         - NetProbeCartridge
       rareChance: 0.08

Resources/Prototypes/Entities/Objects/Tools/lantern.yml

@@ -1,7 +1,7 @@
 - type: entity
   name: lantern
   parent: BaseItem
-  id: lantern
+  id: Lantern
   description: The holy light guides the way.
   components:
     - type: HandheldLight
@@ -60,10 +60,9 @@
         cell_slot: !type:ContainerSlot {}
 
 - type: entity
-  name: extra-bright lantern
+  parent: Lantern
-  parent: lantern
+  id: LanternFlash
-  id: lanternextrabright
+  suffix: Flash
-  description: Blinding.
   components:
     - type: Sprite
       sprite: Objects/Tools/lantern.rsi
@@ -78,10 +77,8 @@
         map: [ "enum.FlashVisuals.LightLayer" ]
         visible: false
     - type: PointLight
-      enabled: false
       radius: 5
       energy: 10
-      color: "#FFC458"
     - type: Flash
     - type: LimitedCharges
       maxCharges: 15

Resources/migration.yml

@@ -114,3 +114,7 @@ ForensicGloves: ClothingHandsGlovesForensic
 
 # 2023-07-24
 ClothingEyesGlassesBeer: ClothingEyesHudBeer
+
+# 2023-08-01
+lantern: Lantern
+lanternextrabright: LanternFlash