Revert "Glowy lights - light fixtures now actually glow (#23428)"

This reverts commit 1a531342c5.

# Conflicts:
#	Resources/Prototypes/Entities/Structures/Lighting/base_lighting.yml
#	Resources/Textures/Structures/Wallmounts/Lighting/light_tube.rsi/glow.png
#	Resources/Textures/Structures/Wallmounts/Lighting/light_tube.rsi/meta.json

Content.Client/Light/Visualizers/PoweredLightVisualizerSystem.cs

@@ -30,9 +30,6 @@ public sealed class PoweredLightVisualizerSystem : VisualizerSystem<PoweredLight
         if (comp.SpriteStateMap.TryGetValue(state, out var spriteState))
             args.Sprite.LayerSetState(PoweredLightLayers.Base, spriteState);
 
-        if (args.Sprite.LayerExists(PoweredLightLayers.Glow))
-            args.Sprite.LayerSetVisible(PoweredLightLayers.Glow, state == PoweredLightState.On);
-
         SetBlinkingAnimation(
             uid,
             state == PoweredLightState.On

Content.Shared/Light/SharedPoweredLightVisuals.cs

@@ -21,7 +21,6 @@ namespace Content.Shared.Light
 
     public enum PoweredLightLayers : byte
     {
-        Base,
+        Base
-        Glow
     }
 }

Resources/Prototypes/Entities/Structures/Lighting/base_lighting.yml

@@ -25,12 +25,9 @@
     sprite: Structures/Wallmounts/Lighting/light_tube.rsi
     drawdepth: WallMountedItems
     layers:
-    - map: ["enum.PoweredLightLayers.Base"]
+    - state: on
-      state: base
+      map: ["enum.PoweredLightLayers.Base"]
-    - map: ["enum.PoweredLightLayers.Glow"]
+    state: on
-      state: glow
-      shader: unshaded
-    state: base
   - type: PointLight
     color: "#FFE4CE" # 5000K color temp
     energy: 0.8
@@ -111,12 +108,6 @@
   - type: PoweredLightVisuals
     blinkingSound:
       path: "/Audio/Machines/light_tube_on.ogg"
-    spriteStateMap:
-      empty: empty
-      off: base
-      on: base
-      broken: broken
-      burned: burned
 
 - type: entity
   id: Poweredlight
@@ -125,7 +116,7 @@
   parent: PoweredlightEmpty
   components:
   - type: Sprite
-    state: base
+    state: off
   - type: PointLight
     enabled: true
   - type: PoweredLight
@@ -227,7 +218,7 @@
         path: /Audio/Ambience/Objects/light_hum.ogg
     - type: Sprite
       sprite: Structures/Wallmounts/Lighting/light_small.rsi
-      state: base
+      state: on
     - type: PointLight
       energy: 1.0
       radius: 6
@@ -291,15 +282,6 @@
     range: 200
   - type: Appearance
   - type: PoweredLightVisuals
-    spriteStateMap:
-      empty: empty
-      off: base
-      on: base
-      broken: broken
-      burned: burned
-  - type: DeviceLinkSource
-    ports:
-    - LightStatus
   - type: DeviceLinkSink
     ports:
       - On
@@ -312,7 +294,7 @@
   parent: PoweredSmallLightEmpty
   components:
   - type: Sprite
-    state: base
+    state: off
   - type: PointLight
     enabled: true
   - type: PoweredLight

Resources/Prototypes/Entities/Structures/Wallmounts/service_light.yml

@@ -8,12 +8,9 @@
     sprite: Structures/Wallmounts/service_light.rsi
     drawdepth: WallMountedItems
     layers:
-    - map: ["enum.PoweredLightLayers.Base"]
+    - state: off
-      state: base
+      map: ["enum.PoweredLightLayers.Base"]
-    - map: ["enum.PoweredLightLayers.Glow"]
+    state: off
-      state: glow
-      shader: unshaded
-    state: base
   - type: PointLight
     radius: 1.5
     energy: 0.45

Resources/Prototypes/Recipes/Construction/structures.yml

@@ -1059,7 +1059,7 @@
   description: A wall light fixture. Use light tubes.
   icon:
     sprite: Structures/Wallmounts/Lighting/light_tube.rsi
-    state: base
+    state: off
   objectType: Structure
   placementMode: SnapgridCenter
   canRotate: true
@@ -1079,7 +1079,7 @@
   description: A wall light fixture. Use light bulbs.
   icon:
     sprite: Structures/Wallmounts/Lighting/light_small.rsi
-    state: base
+    state: off
   objectType: Structure
   placementMode: SnapgridCenter
   canRotate: true

Resources/Textures/Structures/Wallmounts/Lighting/light_small.rsi/meta.json

@@ -1 +1 @@
-{"version": 1, "size": {"x": 32, "y": 32}, "license": "CC-BY-SA-3.0", "copyright": "https://github.com/discordia-space/CEV-Eris/blob/2b969adc2dfd3e9621bf3597c5cbffeb3ac8c9f0/icons/obj/lighting.dmi", "states": [{"name": "broken", "directions": 4}, {"name": "burned", "directions": 4}, {"name": "empty", "directions": 4}, {"name": "base", "directions": 4}, {"name": "glow", "directions": 4}]}
+{"version": 1, "size": {"x": 32, "y": 32}, "license": "CC-BY-SA-3.0", "copyright": "https://github.com/discordia-space/CEV-Eris/blob/2b969adc2dfd3e9621bf3597c5cbffeb3ac8c9f0/icons/obj/lighting.dmi", "states": [{"name": "broken", "directions": 4}, {"name": "burned", "directions": 4}, {"name": "empty", "directions": 4}, {"name": "off", "directions": 4}, {"name": "on", "directions": 4}]}

Resources/Textures/Structures/Wallmounts/Lighting/light_tube.rsi/meta.json

@@ -1,31 +1,101 @@
 {
   "version": 1,
-  "license": "CC-BY-SA-3.0",
-  "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24",
   "size": {
     "x": 32,
     "y": 32
   },
+  "license": "CC-BY-SA-3.0",
+  "copyright": "https://github.com/discordia-space/CEV-Eris/blob/2b969adc2dfd3e9621bf3597c5cbffeb3ac8c9f0/icons/obj/lighting.dmi",
   "states": [
     {
       "name": "broken",
-      "directions": 4
+      "directions": 4,
+      "delays": [
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ]
+      ]
     },
     {
       "name": "burned",
-      "directions": 4
+      "directions": 4,
-    },
+      "delays": [
-    {
+        [
-      "name": "base",
+          1
-      "directions": 4
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ]
+      ]
     },
     {
       "name": "empty",
-      "directions": 4
+      "directions": 4,
+      "delays": [
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ]
+      ]
     },
     {
-      "name": "glow",
+      "name": "off",
-      "directions": 4
+      "directions": 4,
+      "delays": [
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ]
+      ]
+    },
+    {
+      "name": "on",
+      "directions": 4,
+      "delays": [
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ],
+        [
+          1
+        ]
+      ]
     }
   ]
 }

Resources/Textures/Structures/Wallmounts/service_light.rsi/meta.json

@@ -20,11 +20,11 @@
             "directions": 4
         },
         {
-            "name": "base",
+            "name": "off",
             "directions": 4
         },
         {
-            "name": "glow",
+            "name": "on",
             "directions": 4,
             "delays": [
                 [