Seal/abstract/virtual everything (#6739)

This commit is contained in:
mirrorcult
2022-02-16 00:23:23 -07:00
committed by GitHub
parent 4dfcacb86a
commit ec4d4688c7
1771 changed files with 2216 additions and 2164 deletions

View File

@@ -11,7 +11,7 @@ namespace Content.Shared.Construction.Conditions
{
[UsedImplicitly]
[DataDefinition]
public class EmptyOrWindowValidInTile : IConstructionCondition
public sealed class EmptyOrWindowValidInTile : IConstructionCondition
{
[DataField("tileNotBlocked")]
private readonly TileNotBlocked _tileNotBlocked = new();

View File

@@ -11,7 +11,7 @@ namespace Content.Shared.Construction.Conditions
{
[UsedImplicitly]
[DataDefinition]
public class NoWindowsInTile : IConstructionCondition
public sealed class NoWindowsInTile : IConstructionCondition
{
public bool Condition(EntityUid user, EntityCoordinates location, Direction direction)
{

View File

@@ -9,7 +9,7 @@ namespace Content.Shared.Construction.Conditions
{
[UsedImplicitly]
[DataDefinition]
public class TileNotBlocked : IConstructionCondition
public sealed class TileNotBlocked : IConstructionCondition
{
[DataField("filterMobs")] private bool _filterMobs = false;
[DataField("failIfSpace")] private bool _failIfSpace = true;

View File

@@ -11,7 +11,7 @@ namespace Content.Shared.Construction.Conditions
{
[UsedImplicitly]
[DataDefinition]
public class TileType : IConstructionCondition
public sealed class TileType : IConstructionCondition
{
[DataField("targets")]
public List<string> TargetTiles { get; } = new();

View File

@@ -15,7 +15,7 @@ namespace Content.Shared.Construction.Conditions
{
[UsedImplicitly]
[DataDefinition]
public class WallmountCondition : IConstructionCondition
public sealed class WallmountCondition : IConstructionCondition
{
public bool Condition(EntityUid user, EntityCoordinates location, Direction direction)
{

View File

@@ -8,7 +8,7 @@ namespace Content.Shared.Construction
{
[Serializable]
[DataDefinition]
public class ConstructionGraphEdge
public sealed class ConstructionGraphEdge
{
[DataField("steps")]
private ConstructionGraphStep[] _steps = Array.Empty<ConstructionGraphStep>();

View File

@@ -8,7 +8,7 @@ namespace Content.Shared.Construction
{
[Serializable]
[DataDefinition]
public class ConstructionGraphNode
public sealed class ConstructionGraphNode
{
[DataField("actions", serverOnly: true)]
private IGraphAction[] _actions = Array.Empty<IGraphAction>();

View File

@@ -11,7 +11,7 @@ using Robust.Shared.ViewVariables;
namespace Content.Shared.Construction.Prototypes
{
[Prototype("constructionGraph")]
public class ConstructionGraphPrototype : IPrototype, ISerializationHooks
public sealed class ConstructionGraphPrototype : IPrototype, ISerializationHooks
{
private readonly Dictionary<string, ConstructionGraphNode> _nodes = new();
private readonly Dictionary<(string, string), ConstructionGraphNode[]?> _paths = new();

View File

@@ -9,7 +9,7 @@ using Robust.Shared.ViewVariables;
namespace Content.Shared.Construction.Prototypes
{
[Prototype("construction")]
public class ConstructionPrototype : IPrototype
public sealed class ConstructionPrototype : IPrototype
{
[DataField("conditions")] private List<IConstructionCondition> _conditions = new();

View File

@@ -3,7 +3,7 @@
namespace Content.Shared.Construction
{
[RegisterComponent]
public class SharedCanBuildWindowOnTopComponent : Component
public sealed class SharedCanBuildWindowOnTopComponent : Component
{
}
}

View File

@@ -6,14 +6,14 @@ using Robust.Shared.Serialization;
namespace Content.Shared.Construction
{
public class SharedConstructionSystem : EntitySystem
public abstract class SharedConstructionSystem : EntitySystem
{
/// <summary>
/// Sent client -> server to to tell the server that we started building
/// a structure-construction.
/// </summary>
[Serializable, NetSerializable]
public class TryStartStructureConstructionMessage : EntityEventArgs
public sealed class TryStartStructureConstructionMessage : EntityEventArgs
{
/// <summary>
/// Position to start building.
@@ -46,7 +46,7 @@ namespace Content.Shared.Construction
/// an item-construction.
/// </summary>
[Serializable, NetSerializable]
public class TryStartItemConstructionMessage : EntityEventArgs
public sealed class TryStartItemConstructionMessage : EntityEventArgs
{
/// <summary>
/// The construction prototype to start building.
@@ -63,7 +63,7 @@ namespace Content.Shared.Construction
/// Sent server -> client to tell the client that a ghost has started to be constructed.
/// </summary>
[Serializable, NetSerializable]
public class AckStructureConstructionMessage : EntityEventArgs
public sealed class AckStructureConstructionMessage : EntityEventArgs
{
public readonly int GhostId;
@@ -77,7 +77,7 @@ namespace Content.Shared.Construction
/// Sent client -> server to request a specific construction guide.
/// </summary>
[Serializable, NetSerializable]
public class RequestConstructionGuide : EntityEventArgs
public sealed class RequestConstructionGuide : EntityEventArgs
{
public readonly string ConstructionId;
@@ -91,7 +91,7 @@ namespace Content.Shared.Construction
/// Sent server -> client as a response to a <see cref="RequestConstructionGuide"/> net message.
/// </summary>
[Serializable, NetSerializable]
public class ResponseConstructionGuide : EntityEventArgs
public sealed class ResponseConstructionGuide : EntityEventArgs
{
public readonly string ConstructionId;
public readonly ConstructionGuide Guide;

View File

@@ -6,7 +6,7 @@ using Robust.Shared.Serialization.Manager.Attributes;
namespace Content.Shared.Construction.Steps
{
[DataDefinition]
public class ComponentConstructionGraphStep : ArbitraryInsertConstructionGraphStep
public sealed class ComponentConstructionGraphStep : ArbitraryInsertConstructionGraphStep
{
[DataField("component")] public string Component { get; } = string.Empty;

View File

@@ -10,7 +10,7 @@ using Robust.Shared.Serialization.TypeSerializers.Interfaces;
namespace Content.Shared.Construction.Steps
{
[TypeSerializer]
public class ConstructionGraphStepTypeSerializer : ITypeReader<ConstructionGraphStep, MappingDataNode>
public sealed class ConstructionGraphStepTypeSerializer : ITypeReader<ConstructionGraphStep, MappingDataNode>
{
private Type? GetType(MappingDataNode node)
{

View File

@@ -11,7 +11,7 @@ using Robust.Shared.Serialization.TypeSerializers.Implementations.Custom.Prototy
namespace Content.Shared.Construction.Steps
{
[DataDefinition]
public class MaterialConstructionGraphStep : EntityInsertConstructionGraphStep
public sealed class MaterialConstructionGraphStep : EntityInsertConstructionGraphStep
{
// TODO: Make this use the material system.
// TODO TODO: Make the material system not shit.

View File

@@ -5,7 +5,7 @@ using Robust.Shared.Serialization.Manager.Attributes;
namespace Content.Shared.Construction.Steps
{
public class MultipleTagsConstructionGraphStep : ArbitraryInsertConstructionGraphStep
public sealed class MultipleTagsConstructionGraphStep : ArbitraryInsertConstructionGraphStep
{
[DataField("allTags")]
private List<string>? _allTags;

View File

@@ -6,7 +6,7 @@ using Robust.Shared.Serialization.Manager.Attributes;
namespace Content.Shared.Construction.Steps
{
[DataDefinition]
public class PrototypeConstructionGraphStep : ArbitraryInsertConstructionGraphStep
public sealed class PrototypeConstructionGraphStep : ArbitraryInsertConstructionGraphStep
{
[DataField("prototype")] public string Prototype { get; } = string.Empty;

View File

@@ -5,7 +5,7 @@ using Robust.Shared.Serialization.Manager.Attributes;
namespace Content.Shared.Construction.Steps
{
[DataDefinition]
public class TagConstructionGraphStep : ArbitraryInsertConstructionGraphStep
public sealed class TagConstructionGraphStep : ArbitraryInsertConstructionGraphStep
{
[DataField("tag")]
private string? _tag = null;

View File

@@ -12,7 +12,7 @@ using Robust.Shared.Utility;
namespace Content.Shared.Construction.Steps
{
[DataDefinition]
public class ToolConstructionGraphStep : ConstructionGraphStep
public sealed class ToolConstructionGraphStep : ConstructionGraphStep
{
[DataField("tool", required:true, customTypeSerializer:typeof(PrototypeIdSerializer<ToolQualityPrototype>))]
public string Tool { get; } = string.Empty;