Piping sprites cleanup (#3022)

* Moves piping visualizers to own folder

* Pump visualizer update

* Siphon and vent visualiser only set enabled visibility

* PipeVisualizer cleanup

* Replaces off vent/scrubber sprites

* Gas filter sprite update

* Revert "Gas filter sprite update"

This reverts commit 676e5d55e1157a229b1445eeea53a5c8032dbbb5.

* Rotates gas filter sprites to match T-junction pipe directions

* Removes pipes from scruber and vent state

* Makes sprite components use layers

* disabled sprite netsync on piping entities

* piping meta.json cleanup

Co-authored-by: py01 <pyronetics01@gmail.com>

Resources/Prototypes/Entities/Constructible/Ground/gascanisterports.yml

@@ -10,15 +10,12 @@
   - type: SnapGrid
     offset: Center
   - type: Sprite
+    netsync: false
     sprite: Constructible/Atmos/gascanisterport.rsi
-    state: gasCanisterPort
-  - type: Icon
-    sprite: Constructible/Atmos/gascanisterport.rsi
-    state: gasCanisterPort
-  - type: Appearance
-    visuals:
-    - type: PipeVisualizer
-      pipeRSI: Constructible/Atmos/pipe.rsi
+    layers:
+    - sprite: Constructible/Atmos/pipe.rsi
+      state: pipeHalf
+    - state: gasCanisterPort
   - type: Damageable
   - type: Destructible
     thresholds:

Resources/Prototypes/Entities/Constructible/Ground/gasfilters.yml

@@ -17,19 +17,23 @@
         behaviors:
         - !type:DoActsBehavior
           acts: ["Destruction"]
-
+  - type: Sprite
+    netsync: false
+    sprite: Constructible/Atmos/gasfilter.rsi
+    layers:
+    - sprite: Constructible/Atmos/pipe.rsi
+      state: pipeTJunction
+    - state: gasFilter
+  - type: Appearance
+    visuals:
+    - type: GasFilterVisualizer
+    
 - type: entity
   parent: GasFilterBase
   id: GasFilter
   name: Gas Filter
   description: It filters gases.
   components:
-  - type: Sprite
-    sprite: Constructible/Atmos/gasfilter.rsi
-    state: gasFilter
-  - type: Icon
-    sprite: Constructible/Atmos/gasfilter.rsi
-    state: gasFilter
   - type: NodeContainer
     nodes:
     - !type:PipeNode
@@ -45,7 +49,3 @@
     inletDirection: South
     filterOutletDirection: East
     outletDirection: North 
-  - type: Appearance
-    visuals:
-    - type: GasFilterVisualizer
-      filerEnabledState: gasFilterOn

Resources/Prototypes/Entities/Constructible/Ground/pipes.yml

@@ -19,10 +19,10 @@
         - !type:DoActsBehavior
           acts: ["Destruction"]
   - type: Sprite
+    netsync: false
   - type: Appearance
     visuals:
     - type: PipeVisualizer
-      pipeRSI: Constructible/Atmos/pipe.rsi
   - type: Icon
     sprite: Constructible/Atmos/pipe.rsi
 

Resources/Prototypes/Entities/Constructible/Ground/pumps.yml

@@ -18,9 +18,15 @@
         - !type:DoActsBehavior
           acts: ["Destruction"]
   - type: Sprite
+    netsync: false
     sprite: Constructible/Atmos/pump.rsi
-  - type: Icon
-    sprite: Constructible/Atmos/pump.rsi
+    layers:
+    - sprite: Constructible/Atmos/pipe.rsi
+      state: pipeStraight
+    - state: pumpPressure
+  - type: Appearance
+    visuals:
+    - type: PumpVisualizer
 
 - type: entity
   parent: PumpBase
@@ -38,11 +44,4 @@
   - type: PressurePump
     inletDirection: West
     outletDirection: East
-  - type: Sprite
-    state: pumpPressure
-  - type: Icon
-    state: pumpPressure
-  - type: Appearance
-    visuals:
-    - type: PumpVisualizer
-      pumpEnabledState: pumpPressureOn
+    

Resources/Prototypes/Entities/Constructible/Ground/scrubbers.yml

@@ -9,16 +9,6 @@
   - type: Physics
   - type: SnapGrid
     offset: Center
-
-  - type: Sprite
-    sprite: Constructible/Atmos/pipeitems.rsi
-    state: scrubber
-  - type: Appearance
-    visuals:
-    - type: PipeVisualizer
-      pipeRSI: Constructible/Atmos/pipe.rsi
-    - type: SiphonVisualizer
-      siphonRSI: Constructible/Atmos/scrubber.rsi
   - type: Damageable
     resistances: metallicResistances
   - type: Destructible
@@ -27,7 +17,17 @@
         behaviors:
         - !type:DoActsBehavior
           acts: ["Destruction"]
-
+  - type: Sprite
+    netsync: false
+    sprite: Constructible/Atmos/scrubber.rsi
+    layers:
+    - sprite: Constructible/Atmos/pipe.rsi
+      state: pipeHalf
+    - state: scrubOff
+  - type: Appearance
+    visuals:
+    - type: SiphonVisualizer
+      
 - type: entity
   parent: ScrubberBase
   id: Scrubber

Resources/Prototypes/Entities/Constructible/Ground/vents.yml

@@ -9,16 +9,6 @@
   - type: Physics
   - type: SnapGrid
     offset: Center
-
-  - type: Sprite
-    sprite: Constructible/Atmos/pipeitems.rsi
-    state: vent
-  - type: Appearance
-    visuals:
-    - type: PipeVisualizer
-      pipeRSI: Constructible/Atmos/pipe.rsi
-    - type: VentVisualizer
-      ventRSI: Constructible/Atmos/vent.rsi
   - type: Damageable
     resistances: metallicResistances
   - type: Destructible
@@ -27,7 +17,17 @@
         behaviors:
         - !type:DoActsBehavior
           acts: ["Destruction"]
-
+  - type: Sprite
+    netsync: false
+    sprite: Constructible/Atmos/vent.rsi
+    layers:
+    - sprite: Constructible/Atmos/pipe.rsi
+      state: pipeHalf
+    - state: ventOff      
+  - type: Appearance
+    visuals:
+    - type: VentVisualizer
+    
 - type: entity
   parent: VentBase
   id: Vent