Gun refactor (#8301)
Co-authored-by: Kara <lunarautomaton6@gmail.com> Co-authored-by: T-Stalker <le0nel_1van@hotmail.com> Co-authored-by: T-Stalker <43253663+DogZeroX@users.noreply.github.com> Co-authored-by: ElectroJr <leonsfriedrich@gmail.com> Co-authored-by: metalgearsloth <metalgearsloth@gmail.com>
This commit is contained in:
@@ -15,29 +15,26 @@ namespace Content.Server.Power.Components
|
||||
private CellChargerStatus _status;
|
||||
|
||||
[DataField("chargeRate")]
|
||||
private int _chargeRate = 100;
|
||||
|
||||
[DataField("transferEfficiency")]
|
||||
private float _transferEfficiency = 0.85f;
|
||||
public int ChargeRate = 20;
|
||||
|
||||
[DataField("chargerSlot", required: true)]
|
||||
public ItemSlot ChargerSlot = new();
|
||||
|
||||
private CellChargerStatus GetStatus()
|
||||
{
|
||||
if (_entMan.TryGetComponent(Owner, out ApcPowerReceiverComponent? receiver) &&
|
||||
!receiver.Powered)
|
||||
if (!_entMan.TryGetComponent<TransformComponent>(Owner, out var xform) ||
|
||||
!xform.Anchored ||
|
||||
_entMan.TryGetComponent(Owner, out ApcPowerReceiverComponent? receiver) && !receiver.Powered)
|
||||
{
|
||||
return CellChargerStatus.Off;
|
||||
}
|
||||
|
||||
if (!ChargerSlot.HasItem)
|
||||
{
|
||||
return CellChargerStatus.Empty;
|
||||
}
|
||||
|
||||
if (HeldBattery != null && Math.Abs(HeldBattery.MaxCharge - HeldBattery.CurrentCharge) < 0.01)
|
||||
{
|
||||
return CellChargerStatus.Charged;
|
||||
}
|
||||
|
||||
return CellChargerStatus.Charging;
|
||||
}
|
||||
|
||||
@@ -66,7 +63,7 @@ namespace Content.Server.Power.Components
|
||||
appearance?.SetData(CellVisual.Light, CellChargerStatus.Empty);
|
||||
break;
|
||||
case CellChargerStatus.Charging:
|
||||
receiver.Load = (int) (_chargeRate / _transferEfficiency);
|
||||
receiver.Load = ChargeRate;
|
||||
appearance?.SetData(CellVisual.Light, CellChargerStatus.Charging);
|
||||
break;
|
||||
case CellChargerStatus.Charged:
|
||||
@@ -83,9 +80,8 @@ namespace Content.Server.Power.Components
|
||||
public void OnUpdate(float frameTime) //todo: make single system for this
|
||||
{
|
||||
if (_status == CellChargerStatus.Empty || _status == CellChargerStatus.Charged || !ChargerSlot.HasItem)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
TransferPower(frameTime);
|
||||
}
|
||||
|
||||
@@ -98,16 +94,15 @@ namespace Content.Server.Power.Components
|
||||
}
|
||||
|
||||
if (HeldBattery == null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
HeldBattery.CurrentCharge += _chargeRate * frameTime;
|
||||
HeldBattery.CurrentCharge += ChargeRate * frameTime;
|
||||
// Just so the sprite won't be set to 99.99999% visibility
|
||||
if (HeldBattery.MaxCharge - HeldBattery.CurrentCharge < 0.01)
|
||||
{
|
||||
HeldBattery.CurrentCharge = HeldBattery.MaxCharge;
|
||||
}
|
||||
|
||||
UpdateStatus();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
using Content.Server.Power.Components;
|
||||
using Content.Server.PowerCell;
|
||||
using Content.Shared.Containers.ItemSlots;
|
||||
using Content.Shared.Examine;
|
||||
using Content.Shared.PowerCell.Components;
|
||||
using JetBrains.Annotations;
|
||||
using Robust.Shared.Containers;
|
||||
@@ -15,16 +16,18 @@ internal sealed class ChargerSystem : EntitySystem
|
||||
|
||||
public override void Initialize()
|
||||
{
|
||||
base.Initialize();
|
||||
|
||||
SubscribeLocalEvent<ChargerComponent, ComponentInit>(OnChargerInit);
|
||||
SubscribeLocalEvent<ChargerComponent, ComponentRemove>(OnChargerRemove);
|
||||
|
||||
SubscribeLocalEvent<ChargerComponent, PowerChangedEvent>(OnPowerChanged);
|
||||
|
||||
SubscribeLocalEvent<ChargerComponent, EntInsertedIntoContainerMessage>(OnInserted);
|
||||
SubscribeLocalEvent<ChargerComponent, EntRemovedFromContainerMessage>(OnRemoved);
|
||||
SubscribeLocalEvent<ChargerComponent, ContainerIsInsertingAttemptEvent>(OnInsertAttempt);
|
||||
SubscribeLocalEvent<ChargerComponent, ExaminedEvent>(OnChargerExamine);
|
||||
}
|
||||
|
||||
private void OnChargerExamine(EntityUid uid, ChargerComponent component, ExaminedEvent args)
|
||||
{
|
||||
args.PushMarkup(Loc.GetString("charger-examine", ("color", "yellow"), ("chargeRate", component.ChargeRate)));
|
||||
}
|
||||
|
||||
public override void Update(float frameTime)
|
||||
@@ -63,7 +66,7 @@ internal sealed class ChargerSystem : EntitySystem
|
||||
// or by checking for a power cell slot on the inserted entity
|
||||
_cellSystem.TryGetBatteryFromSlot(args.Entity, out component.HeldBattery);
|
||||
}
|
||||
|
||||
|
||||
component.UpdateStatus();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user