pvs content (#5484)

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>

Content.Shared/Actions/Components/SharedActionsComponent.cs

@@ -75,7 +75,7 @@ namespace Content.Shared.Actions.Components
         }
 
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new ActionComponentState(_actions, _itemActions);
         }

Content.Shared/Alert/SharedAlertsComponent.cs

@@ -36,7 +36,7 @@ namespace Content.Shared.Alert
             _alerts = state.Alerts;
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new AlertsComponentState(_alerts);
         }

Content.Shared/Body/Components/SharedBodyComponent.cs

@@ -547,7 +547,7 @@ namespace Content.Shared.Body.Components
             return SlotParts.ElementAt(index);
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             var parts = new (string slot, EntityUid partId)[SlotParts.Count];
 

Content.Shared/Body/Components/SharedBodyPartComponent.cs

@@ -138,7 +138,7 @@ namespace Content.Shared.Body.Components
             Dirty();
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             var mechanismIds = new EntityUid[_mechanisms.Count];
 

Content.Shared/Chemistry/Components/MovespeedModifierMetabolismComponent.cs

@@ -31,7 +31,7 @@ namespace Content.Shared.Chemistry.Components
         [ViewVariables]
         public TimeSpan ModifierTimer { get; set; } = TimeSpan.Zero;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new MovespeedModifierMetabolismComponentState(WalkSpeedModifier, SprintSpeedModifier, ModifierTimer);
         }

Content.Shared/CombatMode/SharedCombatModeComponent.cs

@@ -65,7 +65,7 @@ namespace Content.Shared.CombatMode
         }
 
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new CombatModeComponentState(IsInCombatMode, ActiveZone);
         }

Content.Shared/Cooldown/ItemCooldownComponent.cs

@@ -53,7 +53,7 @@ namespace Content.Shared.Cooldown
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new ItemCooldownComponentState
             {

Content.Shared/Disposal/Components/SharedDisposalUnitComponent.cs

@@ -68,7 +68,7 @@ namespace Content.Shared.Disposal.Components
             Pressurizing
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new DisposalUnitComponentState(RecentlyEjected);
         }

Content.Shared/Emoting/SharedEmotingComponent.cs

@@ -28,7 +28,7 @@ namespace Content.Shared.Emoting
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new EmotingComponentState(Enabled);
         }

Content.Shared/Flash/SharedFlashSystem.cs

@@ -10,14 +10,18 @@ namespace Content.Shared.Flash
             base.Initialize();
 
             SubscribeLocalEvent<SharedFlashableComponent, ComponentGetState>(OnFlashableGetState);
+            SubscribeLocalEvent<SharedFlashableComponent, ComponentGetStateAttemptEvent>(OnGetStateAttempt);
+        }
+
+        private void OnGetStateAttempt(EntityUid uid, SharedFlashableComponent component, ComponentGetStateAttemptEvent args)
+        {
+            // Only send state to the player attached to the entity.
+            if (args.Player.AttachedEntityUid != uid)
+                args.Cancel();
         }
 
         private void OnFlashableGetState(EntityUid uid, SharedFlashableComponent component, ref ComponentGetState args)
         {
-            // Only send state to the player attached to the entity.
-            if (args.Player.AttachedEntityUid != uid)
-                return;
-
             args.State = new FlashableComponentState(component.Duration, component.LastFlash);
         }
     }

Content.Shared/Friction/TileFrictionModifier.cs

@@ -31,7 +31,7 @@ namespace Content.Shared.Friction
         [DataField("modifier")]
         private float _modifier = 1.0f;
 
-        public override ComponentState GetComponentState(ICommonSession session)
+        public override ComponentState GetComponentState()
         {
             return new TileFrictionComponentState(_modifier);
         }

Content.Shared/Ghost/SharedGhostComponent.cs

@@ -47,7 +47,7 @@ namespace Content.Shared.Ghost
         [DataField("canReturnToBody")]
         private bool _canReturnToBody;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new GhostComponentState(CanReturnToBody, CanGhostInteract);
         }

Content.Shared/Gravity/GravityComponent.cs

@@ -41,7 +41,7 @@ namespace Content.Shared.Gravity
 
         private bool _enabled;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new GravityComponentState(_enabled);
         }

Content.Shared/Hands/Components/HandVirtualItemComponent.cs

@@ -26,7 +26,7 @@ namespace Content.Shared.Hands.Components
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new VirtualItemComponentState(BlockingEntity);
         }

Content.Shared/Hands/Components/SharedHandsComponent.cs

@@ -78,7 +78,7 @@ namespace Content.Shared.Hands.Components
         [ViewVariables(VVAccess.ReadWrite)]
         public float ThrowRange { get; set; } = 8f;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             var hands = new HandState[Hands.Count];
 

Content.Shared/Item/SharedItemComponent.cs

@@ -88,7 +88,7 @@ namespace Content.Shared.Item
         [DataField("sprite")]
         private string? _rsiPath;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new ItemComponentState(Size, EquippedPrefix, Color, RsiPath);
         }

Content.Shared/MobState/Components/MobStateComponent.cs

@@ -73,7 +73,7 @@ namespace Content.Shared.MobState.Components
             base.OnRemove();
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new MobStateComponentState(CurrentThreshold);
         }

Content.Shared/Movement/Components/SharedPlayerInputMoverComponent.cs

@@ -198,7 +198,7 @@ namespace Content.Shared.Movement.Components
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new MoverComponentState(_heldMoveButtons);
         }

Content.Shared/Movement/Components/SharedPlayerMobMoverComponent.cs

@@ -91,7 +91,7 @@ namespace Content.Shared.Movement.Components
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession session)
+        public override ComponentState GetComponentState()
         {
             return new PlayerMobMoverComponentState(_grabRange, _pushStrength, _weightlessStrength);
         }

Content.Shared/Placeable/PlaceableSurfaceComponent.cs

@@ -28,7 +28,7 @@ namespace Content.Shared.Placeable
         [DataField("positionOffset")]
         public Vector2 PositionOffset { get; set; }
 
-        public override ComponentState GetComponentState(ICommonSession session)
+        public override ComponentState GetComponentState()
         {
             return new PlaceableSurfaceComponentState(IsPlaceable,PlaceCentered, PositionOffset);
         }

Content.Shared/Pulling/Components/PullableComponent.cs

@@ -38,7 +38,7 @@ namespace Content.Shared.Pulling.Components
 
         public EntityCoordinates? MovingTo { get; set; }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new PullableComponentState(Puller?.Uid);
         }

Content.Shared/Shuttles/Components/PilotComponent.cs

@@ -47,7 +47,7 @@ namespace Content.Shared.Shuttles.Components
             Console = shuttleConsoleComponent;
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new PilotComponentState(Console?.OwnerUid);
         }

Content.Shared/Singularity/Components/SingularityDistortionComponent.cs

@@ -34,7 +34,7 @@ namespace Content.Shared.Singularity.Components
             set => this.SetAndDirtyIfChanged(ref _falloff, value);
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new SingularityDistortionComponentState(Intensity, Falloff);
         }

Content.Shared/Slippery/SlipperyComponent.cs

@@ -138,7 +138,7 @@ namespace Content.Shared.Slippery
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new SlipperyComponentState(ParalyzeTime, IntersectPercentage, RequiredSlipSpeed, LaunchForwardsMultiplier, Slippery, SlipSound.GetSound(), Slipped.ToArray());
         }

Content.Shared/Standing/StandingStateComponent.cs

@@ -24,7 +24,7 @@ namespace Content.Shared.Standing
         [DataField("standing")]
         public bool Standing { get; set; } = true;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new StandingComponentState(Standing);
         }

Content.Shared/SubFloor/SubFloorHideComponent.cs

@@ -35,7 +35,7 @@ namespace Content.Shared.SubFloor
         [DataField("requireAnchored")]
         public bool RequireAnchored { get; set; } = true;
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             return new SubFloorHideComponentState(Enabled, RequireAnchored);
         }

Content.Shared/Tag/TagComponent.cs

@@ -32,7 +32,7 @@ namespace Content.Shared.Tag
             }
         }
 
-        public override ComponentState GetComponentState(ICommonSession player)
+        public override ComponentState GetComponentState()
         {
             var tags = new string[_tags.Count];
             var i = 0;