Refactor AdvertiseComponent to be ECS, improve performance. (#4676)

2021-09-23 18:02:22 +02:00
parent c4ec9a143d
commit 08184bc928
3 changed files with 156 additions and 130 deletions
--- a/Content.Server/Advertise/AdvertiseSystem.cs
+++ b/Content.Server/Advertise/AdvertiseSystem.cs
@@ -0,0 +1,136 @@
+using System;
+using Content.Server.Advertisements;
+using Content.Server.Chat.Managers;
+using Content.Server.Power.Components;
+using Content.Server.VendingMachines;
+using Content.Shared.Acts;
+using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
+using Robust.Shared.Localization;
+using Robust.Shared.Prototypes;
+using Robust.Shared.Random;
+using Robust.Shared.Timing;
+
+namespace Content.Server.Advertise
+{
+    public class AdvertiseSystem : EntitySystem
+    {
+        [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
+        [Dependency] private readonly IRobustRandom _random = default!;
+        [Dependency] private readonly IChatManager _chatManager = default!;
+        [Dependency] private readonly IGameTiming _gameTiming = default!;
+
+        private const float UpdateTimer = 5f;
+
+        private float _timer = 0f;
+
+        public override void Initialize()
+        {
+            SubscribeLocalEvent<AdvertiseComponent, ComponentInit>(OnComponentInit);
+            SubscribeLocalEvent<AdvertiseComponent, PowerChangedEvent>(OnPowerChanged);
+
+            SubscribeLocalEvent<ApcPowerReceiverComponent, AdvertiseEnableChangeAttemptEvent>(OnPowerReceiverEnableChangeAttempt);
+            SubscribeLocalEvent<VendingMachineComponent, AdvertiseEnableChangeAttemptEvent>(OnVendingEnableChangeAttempt);
+        }
+
+        private void OnComponentInit(EntityUid uid, AdvertiseComponent advertise, ComponentInit args)
+        {
+            RefreshTimer(uid, true, advertise);
+        }
+
+        private void OnPowerChanged(EntityUid uid, AdvertiseComponent advertise, PowerChangedEvent args)
+        {
+            SetEnabled(uid, args.Powered, advertise);
+        }
+
+        public void RefreshTimer(EntityUid uid, bool minimumBound = true, AdvertiseComponent? advertise = null)
+        {
+            if (!Resolve(uid, ref advertise))
+                return;
+
+            var minWait = Math.Max(1, advertise.MinimumWait);
+            var maxWait = Math.Max(minWait, advertise.MaximumWait);
+
+            var waitSeconds = minimumBound ? _random.Next(minWait, maxWait) : _random.Next(maxWait);
+            advertise.NextAdvertisementTime = _gameTiming.CurTime.Add(TimeSpan.FromSeconds(waitSeconds));
+        }
+
+        public void SayAdvertisement(EntityUid uid, bool refresh = true, AdvertiseComponent? advertise = null)
+        {
+            if (!Resolve(uid, ref advertise))
+                return;
+
+            if (_prototypeManager.TryIndex(advertise.PackPrototypeId, out AdvertisementsPackPrototype? advertisements))
+                _chatManager.EntitySay(advertise.Owner, Loc.GetString(_random.Pick(advertisements.Advertisements)));
+
+            if(refresh)
+                RefreshTimer(uid, true, advertise);
+        }
+
+        public void SetEnabled(EntityUid uid, bool enabled, AdvertiseComponent? advertise = null)
+        {
+            if (!Resolve(uid, ref advertise))
+                return;
+
+            var attemptEvent = new AdvertiseEnableChangeAttemptEvent(enabled, advertise.Enabled);
+            RaiseLocalEvent(uid, attemptEvent, false);
+
+            if (attemptEvent.Cancelled)
+                return;
+
+            if(enabled)
+                RefreshTimer(uid, !advertise.Enabled, advertise);
+
+            advertise.Enabled = enabled;
+        }
+
+        private void OnPowerReceiverEnableChangeAttempt(EntityUid uid, ApcPowerReceiverComponent component, AdvertiseEnableChangeAttemptEvent args)
+        {
+            if(args.NewState && !component.Powered)
+                args.Cancel();
+        }
+
+        private void OnVendingEnableChangeAttempt(EntityUid uid, VendingMachineComponent component, AdvertiseEnableChangeAttemptEvent args)
+        {
+            // TODO: Improve this...
+            if(args.NewState && component.Broken)
+                args.Cancel();
+        }
+
+        public override void Update(float frameTime)
+        {
+            _timer += frameTime;
+
+            if (_timer < UpdateTimer)
+                return;
+
+            _timer -= UpdateTimer;
+
+            var curTime = _gameTiming.CurTime;
+
+            foreach (var advertise in ComponentManager.EntityQuery<AdvertiseComponent>())
+            {
+                if (!advertise.Enabled)
+                    continue;
+
+                // If it's still not time for the advertisement, do nothing.
+                if (advertise.NextAdvertisementTime > curTime)
+                    continue;
+
+                SayAdvertisement(advertise.Owner.Uid, true, advertise);
+            }
+        }
+    }
+
+    public class AdvertiseEnableChangeAttemptEvent : CancellableEntityEventArgs
+    {
+        public bool NewState { get; }
+        public bool OldState { get; }
+
+        public AdvertiseEnableChangeAttemptEvent(bool newState, bool oldEnabledState)
+        {
+            NewState = newState;
+            OldState = oldEnabledState;
+        }
+    }
+}