Return Detective to Security (#25986)

* Revert "detective patch (#24739)"

This reverts commit 8ef69ff2e1.

* Revert "Detectives gain independency (#23114)"

This reverts commit 807f5facbb.

Resources/Locale/en-US/job/job-description.ftl

@@ -16,7 +16,7 @@ job-description-chemist = Produce medicinal drugs for the doctors to use, resear
 job-description-clown = Entertain the crew through elaborate slapstick routines or terrible jokes.
 job-description-cmo = Manage the resources and personnel of the medical department to keep the crew alive.
 job-description-paramedic = Rescue critically injured patients all over the station, sometimes outside too. Stablize them, give them a ride to medbay, and get back out there!
-job-description-detective = Answer requests for help, investigate crime scenes using forensic tools, and have a couple smokes.
+job-description-detective = Investigate crime scenes using forensic tools, ensure that the guilty party is found, and have a couple smokes.
 job-description-doctor = Diagnose and heal crewmembers through medicinal chemicals, advanced medicine, and defibrillators. Make sure the dead don't rot, and that cadavers are in the morgue.
 job-description-engineer = Keep the station's main engine & solars active, optimize the power network, and make emergency repairs using your hardsuit in spaced areas.
 job-description-ertengineer = Ensure that the station has power and clean air.

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/backpack.yml

@@ -31,12 +31,13 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpack
+  parent: ClothingBackpackSecurity
-  id: ClothingBackpackFilledDetective
+  id: ClothingBackpackSecurityFilledDetective
   components:
   - type: StorageFill
     contents:
-      - id: BoxSurvival
+      - id: BoxSurvivalSecurity
+      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/duffelbag.yml

@@ -30,12 +30,13 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpackDuffel
+  parent: ClothingBackpackDuffelSecurity
-  id: ClothingBackpackDuffelFilledDetective
+  id: ClothingBackpackDuffelSecurityFilledDetective
   components:
   - type: StorageFill
     contents:
-      - id: BoxSurvival
+      - id: BoxSurvivalSecurity
+      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Catalog/Fills/Backpacks/StarterGear/satchel.yml

@@ -44,12 +44,13 @@
 
 - type: entity
   noSpawn: true
-  parent: ClothingBackpackSatchel
+  parent: ClothingBackpackSatchelSecurity
-  id: ClothingBackpackSatchelFilledDetective
+  id: ClothingBackpackSatchelSecurityFilledDetective
   components:
   - type: StorageFill
     contents:
-      - id: BoxSurvival
+      - id: BoxSurvivalSecurity
+      - id: Flash
       - id: ForensicPad
       - id: ForensicScanner
 

Resources/Prototypes/Roles/Jobs/Security/detective.yml

@@ -1,39 +1,38 @@
-- type: job
+- type: job
-  id: Detective
+  id: Detective
-  name: job-name-detective
+  name: job-name-detective
-  description: job-description-detective
+  description: job-description-detective
-  playTimeTracker: JobDetective
+  playTimeTracker: JobDetective
-  requirements:
+  requirements:
-  - !type:DepartmentTimeRequirement
+  - !type:DepartmentTimeRequirement
-    department: Security
+    department: Security
-    time: 36000 # 10 hours
+    time: 54000 # 15 hours
-  - !type:DepartmentTimeRequirement
+  startingGear: DetectiveGear
-    department: Civilian
+  icon: "JobIconDetective"
-    time: 18000 # 5 hours
+  supervisors: job-supervisors-hos
-  startingGear: DetectiveGear
+  canBeAntag: false
-  icon: "JobIconDetective"
+  access:
-  supervisors: job-supervisors-hop
+  - Security
-  canBeAntag: true
+  - Brig
-  access:
+  - Maintenance
-  - Brig
+  - Service
-  - Maintenance
+  - Detective
-  - Service
+  special:
-  - Detective
+  - !type:AddImplantSpecial
-  extendedAccess:
+    implants: [ MindShieldImplant ]
-  - Security
+
-
+- type: startingGear
-- type: startingGear
+  id: DetectiveGear
-  id: DetectiveGear
+  equipment:
-  equipment:
+    jumpsuit: ClothingUniformJumpsuitDetective
-    jumpsuit: ClothingUniformJumpsuitDetective
+    back: ClothingBackpackSecurityFilledDetective
-    outerClothing: ClothingOuterVestDetective
+    shoes: ClothingShoesBootsCombatFilled
-    back: ClothingBackpackFilledDetective
+    eyes: ClothingEyesGlassesSunglasses
-    shoes: ClothingShoesBootsJack
+    head: ClothingHeadHatFedoraBrown
-    eyes: ClothingEyesGlassesSunglasses
+    outerClothing: ClothingOuterVestDetective
-    head: ClothingHeadHatFedoraBrown
+    id: DetectivePDA
-    id: DetectivePDA
+    ears: ClothingHeadsetSecurity
-    ears: ClothingHeadsetSecurity
+    belt: ClothingBeltHolsterFilled
-    belt: ClothingBeltHolsterFilled
+  innerClothingSkirt: ClothingUniformJumpskirtDetective
-  innerClothingSkirt: ClothingUniformJumpskirtDetective
+  satchel: ClothingBackpackSatchelSecurityFilledDetective
-  satchel: ClothingBackpackSatchelFilledDetective
+  duffelbag: ClothingBackpackDuffelSecurityFilledDetective
-  duffelbag: ClothingBackpackDuffelFilledDetective

Resources/Prototypes/Roles/Jobs/departments.yml

@@ -30,7 +30,6 @@
   - Reporter
   - Visitor
   - Zookeeper
-  - Detective
   - ServiceWorker
 
 - type: department
@@ -80,6 +79,7 @@
   - HeadOfSecurity
   - SecurityCadet
   - SecurityOfficer
+  - Detective
   - Warden
 
 - type: department

Resources/migration.yml

@@ -166,10 +166,10 @@ ClothingHeadHelmetVoidParamed: null
 # 2024-01-19
 DefaultStationBeaconTeslaEngine: null
 
-#2024-01-27
+# 2024-01-27 (Reverted on 2024-03-10)
-ClothingBackpackSecurityFilledDetective: ClothingBackpackFilledDetective
+# ClothingBackpackSecurityFilledDetective: ClothingBackpackFilledDetective
-ClothingBackpackDuffelSecurityFilledDetective: ClothingBackpackDuffelFilledDetective
+# ClothingBackpackDuffelSecurityFilledDetective: ClothingBackpackDuffelFilledDetective
-ClothingBackpackSatchelSecurityFilledDetective: ClothingBackpackSatchelFilledDetective
+# ClothingBackpackSatchelSecurityFilledDetective: ClothingBackpackSatchelFilledDetective
 
 # 2024-01-28
 FoodBoxDonkpocketGondola: FoodBoxDonkpocketPizza
@@ -236,3 +236,8 @@ AirlockExternalEasyPryLocked: AirlockExternalLocked
 AirlockExternalGlassEasyPryLocked: AirlockExternalGlassLocked
 AirlockGlassShuttleEasyPryLocked: AirlockExternalGlassShuttleLocked
 AirlockShuttleEasyPryLocked: AirlockExternalShuttleLocked
+
+#2024-03-10
+ClothingBackpackFilledDetective: ClothingBackpackSecurityFilledDetective
+ClothingBackpackDuffelFilledDetective: ClothingBackpackDuffelSecurityFilledDetective
+ClothingBackpackSatchelFilledDetective: ClothingBackpackSatchelSecurityFilledDetective