Data-driven NPC factions (#3249)

* Data-driven NPC factions

* Minor re-factor so it's settable via yaml instead. Any changes made during runtime aren't saved back.
* Still uses enums given bitmasks go BRRT

* private setters whoops

* nullables

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>

Content.Server/GameObjects/Components/AI/AiFactionPrototype.cs

@@ -0,0 +1,27 @@
+#nullable enable
+using System.Collections.Generic;
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization;
+using YamlDotNet.RepresentationModel;
+
+namespace Content.Server.GameObjects.Components.AI
+{
+    [Prototype("aiFaction")]
+    public class AiFactionPrototype : IIndexedPrototype, IPrototype
+    {
+        // These are immutable so any dynamic changes aren't saved back over.
+        // AiFactionSystem will just read these and then store them.
+
+        public string ID { get; private set; } = default!;
+
+        public IReadOnlyList<string> Hostile { get; private set; } = default!;
+
+        public void LoadFrom(YamlMappingNode mapping)
+        {
+            var serializer = YamlObjectSerializer.NewReader(mapping);
+
+            serializer.DataField(this, x => x.ID, "id", string.Empty);
+            serializer.DataField(this, x => x.Hostile, "hostile", new List<string>());
+        }
+    }
+}

Content.Server/GameObjects/Components/AI/AiFactionTagComponent.cs

@@ -1,5 +1,7 @@
+#nullable enable
 using System;
 using System.Collections.Generic;
+using Content.Server.GameObjects.EntitySystems.AI;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Serialization;
 
@@ -35,15 +37,4 @@ namespace Content.Server.GameObjects.Components.AI
                 });
         }
     }
-
-    [Flags]
-    public enum Faction
-    {
-        None = 0,
-        NanoTrasen = 1 << 0,
-        SimpleHostile = 1 << 1,
-        SimpleNeutral = 1 << 2,
-        Syndicate = 1 << 3,
-        Xeno = 1 << 4,
-    }
 }